iked(8): fix wrong "break" placement

2020-04-02 Thread Wataru Ashihara
Found by Yasuhiro Ohishi @iij. ok? Index: sbin/iked/control.c === RCS file: /cvs/src/sbin/iked/control.c,v retrieving revision 1.28 diff -u -r1.28 control.c --- sbin/iked/control.c 22 Mar 2020 15:59:05 - 1.28 +++

Re: iked(8): fix ntohs/htons inversion

2020-04-02 Thread Wataru Ashihara
Sorry, I forgot to set my name in the email's "From" header. I'm Wataru Ashihara. On 2020/04/03 13:11 w...@iij.ad.jp wrote: > ok? > > > Index: sbin/iked/iked.c > === > RCS file: /cvs/src/sbin/iked/iked.c,v > retrieving revision

iked(8): fix ntohs/htons inversion

2020-04-02 Thread wsh
ok? Index: sbin/iked/iked.c === RCS file: /cvs/src/sbin/iked/iked.c,v retrieving revision 1.41 diff -u -r1.41 iked.c --- sbin/iked/iked.c16 Jan 2020 20:05:00 - 1.41 +++ sbin/iked/iked.c3 Apr 2020 04:07:19 - @@

Avoid selwakeup() in kqueue_wakeup()

2020-04-02 Thread Visa Hankala
selwakeup(sip) calls KNOTE(>si_note, 0), which implies that kqueue_wakeup() should not call selwakeup() directly. Otherwise, a contrived program can trigger deep recursion. The diff below moves selwakeup() from kqueue_wakeup() to kqueue_task(). In addition to preventing the recursion, this change

Re: EV_SET(2) shadows variable

2020-04-02 Thread Philip Guenther
On Tue, Mar 31, 2020 at 11:24 PM Martin Pieuchot wrote: > The current form of EV_SET(2) declares a `kevp' variable. This can > cause to subtle bugs hard to discover if one uses a variable of the > same to retrieve events. > > Diff below prefixes the locally declared variable by an underscore, >

vi: add expandtab option

2020-04-02 Thread Todd C . Miller
In vim, the expandtab option expands tabs to spaces in insert mode as well as when shifting and indenting/outdenting. This is very useful when working on a code-base where the style dictates using spaces instead of tabs for indentation. NetBSD added an implementation of expandtab to their vi

Re: macppc libunwind without altivec

2020-04-02 Thread Mark Kettenis
> Date: Thu, 2 Apr 2020 16:05:09 -0400 > From: George Koehler > > Hello tech, > > powerpc libunwind is broken on machines without altivec. It crashes > SIGILL when code (built with base-clang++) throws a C++ exception, > because libunwind always saves the altivec registers. You don't have >

mixerctl: use /dev/audioctl0 instead of /dev/mixer by default

2020-04-02 Thread Alexandre Ratchov
The /dev/audioctlN files, when used in O_WRONLY mode offer the same functionality as /dev/mixerN. Ports don't use /dev/mixerN anymore, by switching mixerctl(4) to /dev/audioctlN too, we remove the last /dev/mixerN user. OK? Index: mixerctl.1

Re: libossaudio: start using sndio

2020-04-02 Thread Alexandre Ratchov
On Thu, Apr 02, 2020 at 05:21:45PM +0100, Stuart Henderson wrote: > On 2020/04/02 17:13, Landry Breuil wrote: > > On Wed, Apr 01, 2020 at 07:27:12PM +0200, Alexandre Ratchov wrote: > > > ping! > > > > > > FWIW, the diff below affects the following ports: > > > - emulators/gambatte > > > -

macppc libunwind without altivec

2020-04-02 Thread George Koehler
Hello tech, powerpc libunwind is broken on machines without altivec. It crashes SIGILL when code (built with base-clang++) throws a C++ exception, because libunwind always saves the altivec registers. You don't have altivec if sysctl machdep.altivec is 0. I believe that G3 cpus don't have

Re: libossaudio: start using sndio

2020-04-02 Thread Alexandre Ratchov
On Thu, Apr 02, 2020 at 05:13:49PM +0200, Landry Breuil wrote: > On Wed, Apr 01, 2020 at 07:27:12PM +0200, Alexandre Ratchov wrote: > > ping! > > > > FWIW, the diff below affects the following ports: > > - emulators/gambatte > > - gstreamer-0.10 mixer plugin > > - sysutils/conky > >

UPDATE: xserver 1.20.8

2020-04-02 Thread Matthieu Herrb
Hi, The patch below updates the X server to version 1.20.8. Apply the patch in ${XSRCDIR}/xserver with patch -p0 -E and then rebuild Xenocara according to release(8). Comments, ok ? Index: ChangeLog === RCS file:

Re: PATCH: rad(8) Better PIO default lifetimes

2020-04-02 Thread Fernando Gont
Hi, Florian, On 2/4/20 15:08, Florian Obser wrote: [...] After talking to Fernando I came up with this much simpler patch: Will come back with comments on your patch, but wanted to note a couple of things bellow: [...] Other aspects of draft-gont-6man-slaac-renum are still being

Re: d_poll() inconsistencies

2020-04-02 Thread Mark Kettenis
> Date: Thu, 2 Apr 2020 20:12:08 +0200 > From: Martin Pieuchot > Content-Type: text/plain; charset=utf-8 > > While reviewing the all current .d_poll() functions I found those two > which are incoherent with the rest. > > - Most of the devices return POLLERR when the device is no longer valid, >

d_poll() inconsistencies

2020-04-02 Thread Martin Pieuchot
While reviewing the all current .d_poll() functions I found those two which are incoherent with the rest. - Most of the devices return POLLERR when the device is no longer valid, for whatever reason, uhid(4) returns POLLHUP in one of the cases. - fusepoll() return EINVAL which isn't a POLL*

Re: PATCH: rad(8) Better PIO default lifetimes (was: Re: Improve handling of IPv6 SLAAC renumbering scenarios)

2020-04-02 Thread Florian Obser
On Fri, Mar 27, 2020 at 11:10:25PM -0300, Fernando Gont wrote: > Florian/folks, > > This is an improved version: > > Essentially, if the lifetime of a prefix is not specified (i.e., the admin > relies on the default values), the Preferred Lifetime is set to the Router > Lifetime, and the Valid

Re: pipex(4) man page fix

2020-04-02 Thread Iain R. Learmonth
Hi, On 02/04/2020 12:47, Vitaliy Makkoveev wrote: > +.Xr pppax 4 , I guess you meant pppac here. Thanks, Iain.

Re: libossaudio: start using sndio

2020-04-02 Thread Stuart Henderson
On 2020/04/02 17:13, Landry Breuil wrote: > On Wed, Apr 01, 2020 at 07:27:12PM +0200, Alexandre Ratchov wrote: > > ping! > > > > FWIW, the diff below affects the following ports: > > - emulators/gambatte > > - gstreamer-0.10 mixer plugin > > - sysutils/conky > > - sysutils/gkrellm

iked(8): boolify

2020-04-02 Thread Wataru Ashihara
It would save our time of thinking and reading the source (i.e. eliminate the process of "what if the variable 'mobike' was 2 or more? ...aha it's just a bool"). This is still work in progress. I would continue if you maintainers are positive on this proposal. Index: sbin/iked/config.c

Re: libossaudio: start using sndio

2020-04-02 Thread Landry Breuil
On Wed, Apr 01, 2020 at 07:27:12PM +0200, Alexandre Ratchov wrote: > ping! > > FWIW, the diff below affects the following ports: > - emulators/gambatte > - gstreamer-0.10 mixer plugin > - sysutils/conky > - sysutils/gkrellm > - sysutil/tpb > -

iwm/iwx: fix tx result reporting

2020-04-02 Thread Stefan Sperling
While working on iwm Tx aggregation and revisiting some parts of MiRA, I have noticed a rate-control problem in iwm and iwx (this also affects iwn, but I am leaving that for later since iwn already does Tx aggregation and requires a more elaborate fix). Rate control algorithms will choose a Tx

Re: Fix pipex(4) pipex_ioctl() access to not owned sessions (kernel crash too)

2020-04-02 Thread Vitaliy Makkoveev
Sorry, screenshot was from pached kernel. Screenshot from clean kernel included.

Fix pipex(4) pipex_ioctl() access to not owned sessions (kernel crash too)

2020-04-02 Thread Vitaliy Makkoveev
pipex(4) has pipex_ioctl() interface for pipex_session related routines. pipex_ioctl() calls should be done with pipex_iface_contex, so any operations should be done with pipex_sessions owned by passed pipex_iface_contex. pipex_session check ownership is missing within pipex_ioctl() so anybody can

Re: pipex(4) man page fix

2020-04-02 Thread Vitaliy Makkoveev
On Thu, Apr 02, 2020 at 09:07:23AM +0200, Martin Pieuchot wrote: > On 29/03/20(Sun) 00:16, Vitaliy Makkoveev wrote: > > pipex not used with tun(4) > > It seems an oversight from the addition of the new pppac(4) driver. See > net/if_tun.c commits from January this year. > > So the right fix

Re: usb(4): use cacheable buffers for data transfers (massive speedup)

2020-04-02 Thread Patrick Wildt
On Wed, Apr 01, 2020 at 12:23:53PM +0200, Patrick Wildt wrote: > On Wed, Apr 01, 2020 at 12:04:25PM +0200, Patrick Wildt wrote: > > On Wed, Apr 01, 2020 at 09:40:06AM +0200, Patrick Wildt wrote: > > > On Wed, Apr 01, 2020 at 09:22:07AM +0200, Patrick Wildt wrote: > > > > On Wed, Apr 01, 2020 at

[patch] mandoc: Remove argument names from function prototypes

2020-04-02 Thread Martin
Hi there! I think these are superfluous. Best, Martin Index: cgi.c === RCS file: /cvs/src/usr.bin/mandoc/cgi.c,v retrieving revision 1.109 diff -u -p -r1.109 cgi.c --- cgi.c 10 Jan 2020 15:20:49 - 1.109 +++ cgi.c

Re: Dedulpicate pipex(4) and pppx(4) code

2020-04-02 Thread Vitaliy Makkoveev
On Thu, Apr 02, 2020 at 09:26:23AM +0200, Martin Pieuchot wrote: > Hello Vitaliy, > > On 01/04/20(Wed) 12:59, Vitaliy Makkoveev wrote: > > Updated diff. The idea is to use already existing pipex API for > > pipex_session creation and destruction. pppx_if now holds a reference > > to

Fix occasional signify regression test fail

2020-04-02 Thread Christian Ludwig
The signify regression test creates a tar archive from the test's directory. Without a symlink to the obj directory, the output tarball is part of the input file list. This makes tar complain that archive.tgz was modified during copy to archive. Avoid including the output archive by reducing the

Re: Dedulpicate pipex(4) and pppx(4) code

2020-04-02 Thread Martin Pieuchot
Hello Vitaliy, On 01/04/20(Wed) 12:59, Vitaliy Makkoveev wrote: > Updated diff. The idea is to use already existing pipex API for > pipex_session creation and destruction. pppx_if now holds a reference > to pipex_session. This is great! There are many things in this diff which makes it

Re: pipex(4) man page fix

2020-04-02 Thread Martin Pieuchot
On 29/03/20(Sun) 00:16, Vitaliy Makkoveev wrote: > pipex not used with tun(4) It seems an oversight from the addition of the new pppac(4) driver. See net/if_tun.c commits from January this year. So the right fix would be to replace tun(4) with pppac(4) and add a pppac.4 manpage. Do you feel