vi.beginner diff and analysis (vi.advanced to follow)

2020-05-23 Thread Andras Farkas
I went through vi.beginner. It works both with vi's regular settings, and with the settings applied via EXINIT in vi.tut.csh. I have a diff attached. I was mostly light and gentle with my changes, but I indeed did change some outdated info and incorrect info. I seriously doubt vi.tut.csh's

Re: Remove useless line from daemon class in login.conf

2020-05-23 Thread Daniel Jakots
On Sat, 23 May 2020 22:08:11 +0100, Stuart Henderson wrote: > I think bumping the minimum to 2^9 would be reasonable, there's a more > noticeable delay on some machines but I think that's fair enough (any > cracking is likely to be done on a fast machine, and the user can > force it lower

vmd(8) and thread safety: a quick proof of concept using libevent 2.1 from ports

2020-05-23 Thread Dave Voutila
Hello tech@, Attached is a diff that patches vmd(8) to utilize libevent 2.1 (from ports) in an attempt to test the hypothesis that thread safety will help stabilize Linux guest support. There's some longer detail below about this hypothesis, but let me cut to the chase: ** This is *not* a

[patch] httpd remove unused struct

2020-05-23 Thread Edgar Pettijohn
Remove an unused struct from parse.y. Index: parse.y === RCS file: /cvs/src/usr.sbin/httpd/parse.y,v retrieving revision 1.114 diff -u -p -u -r1.114 parse.y --- parse.y 9 Feb 2020 09:44:04 - 1.114 +++ parse.y 24 May

[patch] smtpd add timeout to filter registration

2020-05-23 Thread Edgar Pettijohn
Following patch adds a timeout to filter registration. Its easy to have a filter fail to register due to buffering or just experimenting. With the timeout smtpd will die and let the user know why instead of remaining in an unresponsive state. Index: lka_filter.c

tmux(1): fix args_string_percentage error strings

2020-05-23 Thread Kris Katterjohn
Hey, In tmux(1) there are two error strings in args_string_percentage that are backwards. If taking a percentage yields a value that is too small then an error string saying "too large" is used and vice versa. One way to see an incorrect message is with display-popup -h 0% which complains

Re: Remove useless line from daemon class in login.conf

2020-05-23 Thread Stuart Henderson
On 2020/05/22 16:04, Theo de Raadt wrote: > Stuart Henderson wrote: > > > On 2020/05/22 17:06, Daniel Jakots wrote: > > > Hi, > > > > > > We used to have different numbers of blowfish rounds between the > > > default and daemon classes in login.conf. On Jun 26, 2016, tedu > > > committed

tmux(1): fix resize-pane -y error message

2020-05-23 Thread Kris Katterjohn
Hey, A small diff is below to fix the error message from tmux(1) when an invalid value is passed to resize-pane -y. It has mentioned "width" instead of "height". Cheers, Kris Katterjohn Index: usr.bin/tmux/cmd-resize-pane.c ===

[patch] fuse_main.3 - fix example to compile without warnings and apply style changes

2020-05-23 Thread Edgar Pettijohn
Index: fuse_main.3 === RCS file: /cvs/src/lib/libfuse/fuse_main.3,v retrieving revision 1.6 diff -u -p -u -r1.6 fuse_main.3 --- fuse_main.3 28 Nov 2018 21:19:11 - 1.6 +++ fuse_main.3 23 May 2020 18:11:16 - @@ -56,39

Re: vmm timer for linux guests

2020-05-23 Thread Sivaram Gowkanapalli
Hello Pratik, Thanks for the patch. I am about to test it out too. If you do not mind sharing, do you have your patches hosted somewhere? Thanks From: Pratik Vyas [m...@pd.io] Sent: Friday, May 22, 2020 6:15 AM To: Renato Aguiar Cc: tech@openbsd.org;

Fix manpage links in upgrade67.html

2020-05-23 Thread Andre Stoebe
Hello, following patch fixes two manpage links that point to the wrong section. Regards, Andre Index: faq/upgrade67.html === RCS file: /cvs/www/faq/upgrade67.html,v retrieving revision 1.9 diff -u -p -r1.9 upgrade67.html ---

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-23 Thread Vitaliy Makkoveev
> On 23 May 2020, at 12:54, Martin Pieuchot wrote: > > On 22/05/20(Fri) 13:25, Vitaliy Makkoveev wrote: >> On Fri, May 22, 2020 at 07:57:13AM +1000, David Gwynne wrote: >>> [...] >>> can you try the following diff? >>> >> >> I tested this diff and it works for me. But the problem I pointed

Re: [PATCH] pipex(4): rework PPP input

2020-05-23 Thread Vitaliy Makkoveev
> On 23 May 2020, at 13:11, Sergey Ryazanov wrote: > > Hello, > > On Wed, May 20, 2020 at 10:13 PM Vitaliy Makkoveev > wrote: >> On Wed, May 20, 2020 at 04:08:01AM +0300, Sergey Ryazanov wrote: >>> On Tue, May 19, 2020 at 12:11 PM Vitaliy Makkoveev >>> wrote: On Mon, May 04, 2020 at

iwx: fix firmware error when leaving AUTH state

2020-05-23 Thread Stefan Sperling
When moving from AUTH state to INIT or SCAN state the iwx(4) driver performs the following two steps: 1. Remove the formerly chosen access point from the firmware's station table 2. Flush firmware Tx queues This order of operations was inherited from iwm(4) where it works fine. But iwx(4)

iwx: fix binding command

2020-05-23 Thread Stefan Sperling
The iwx(4) binding command can fail with 5 Ghz channels. Some firmware versions don't expect LMAC_5G_INDEX in the binding command. I have no idea what "CDB" stands for, but this check matches what the Linux driver does and makes the command work on -48 firmware. The Linux driver actually checks

iwx: beacon filter command v4

2020-05-23 Thread Stefan Sperling
I have started looking into updating iwx(4) to newer firmware. This newer firmware is not working yet but I already have a few simple changes which could be reviewed and committed. This is the first one: Newer iwx(4) firmware versions will require a larger beacon filter command. The extra fields

Re: OpenSMTPD: unprivileged mode - now with diff

2020-05-23 Thread Todd C . Miller
On Sat, 23 May 2020 15:53:05 +0200, Christopher Zimmermann wrote: > Ok to commit the below change? OK millert@ - todd

Re: OpenSMTPD: unprivileged mode - now with diff

2020-05-23 Thread Christopher Zimmermann
On Sun, Apr 26, 2020 at 08:55:14AM +, gil...@poolp.org wrote: April 26, 2020 10:34 AM, "Christopher Zimmermann" wrote: Hi, I further developed my approach to allow running smtpd with fewer privileges. This diff does two things: - always run lmtp deliveries as SMTPD_USER. The change to

ldomctl: reject vdisk, vnet and iodevice parameters for primary domain

2020-05-23 Thread Klemens Nanni
In analogy to guest domains requiring vcpu, memory and at least one bootable device (vdisk, vnet or iodevice), the primary domain must not be configured with vdisk, vnet or iodevice parameters; it does make sense to provide virtual disks or interfaces to it and PCIe devices not assigned to guest

Re: carp: send only IPv4 carp packets on dual stack interface

2020-05-23 Thread Christopher Zimmermann
On Sat, May 23, 2020 at 01:55:54PM +1000, David Gwynne wrote: On 23 May 2020, at 8:44 am, Christopher Zimmermann wrote: On Sun, Jan 19, 2020 at 01:32:17PM +, Stuart Henderson wrote: On 2020/01/19 00:11, Sebastian Benoit wrote: chr...@openbsd.org(chr...@openbsd.org) on 2020.01.18

Re: ldomctl: Fail on duplicate vcpu and memory parameters

2020-05-23 Thread Klemens Nanni
On Sat, May 23, 2020 at 02:38:03PM +0200, Mark Kettenis wrote: > Looks reasonable. I'd change the message for iodevice though to "iodevice %s > already assigned". Done, thanks.

Re: ldomctl: Fail on duplicate vcpu and memory parameters

2020-05-23 Thread Mark Kettenis
> Date: Sat, 23 May 2020 11:35:46 +0200 > From: Klemens Nanni > > On Mon, Jan 13, 2020 at 12:59:23PM +0100, Klemens Nanni wrote: > > On Sun, Jan 05, 2020 at 07:09:46PM +0100, Klemens Nanni wrote: > > > Domains get to define their cores and memory only once unlike the other > > > parameters of

Re: Kill unused cdev_pc_init()

2020-05-23 Thread Mark Kettenis
> Date: Sat, 23 May 2020 13:32:33 +0200 > From: Martin Pieuchot > > ok? sure > Index: arch/amd64/amd64/conf.c > === > RCS file: /cvs/src/sys/arch/amd64/amd64/conf.c,v > retrieving revision 1.69 > diff -u -p -r1.69 conf.c > ---

Kill unused cdev_pc_init()

2020-05-23 Thread Martin Pieuchot
ok? Index: arch/amd64/amd64/conf.c === RCS file: /cvs/src/sys/arch/amd64/amd64/conf.c,v retrieving revision 1.69 diff -u -p -r1.69 conf.c --- arch/amd64/amd64/conf.c 13 May 2020 08:32:43 - 1.69 +++

Re: vldcp(4/sparc64), magma(4) and spif(4) kqfilter

2020-05-23 Thread Mark Kettenis
> Date: Sat, 23 May 2020 12:42:04 +0200 > From: Martin Pieuchot > > On 21/05/20(Thu) 14:44, Mark Kettenis wrote: > > > Date: Wed, 20 May 2020 14:39:05 +0200 > > > From: Martin Pieuchot > > > Cc: tech@openbsd.org > > > [...] > > > Diff below fixed the cbus_intr_setenabled() line and `avail'

Re: vldcp(4/sparc64), magma(4) and spif(4) kqfilter

2020-05-23 Thread Martin Pieuchot
On 21/05/20(Thu) 14:44, Mark Kettenis wrote: > > Date: Wed, 20 May 2020 14:39:05 +0200 > > From: Martin Pieuchot > > Cc: tech@openbsd.org > > [...] > > Diff below fixed the cbus_intr_setenabled() line and `avail' calculation. > > Is it what you were pointing? > > Yes. But I think it still isn't

Re: fix pppx(4) with net/ifq.c rev 1.38

2020-05-23 Thread Martin Pieuchot
On 22/05/20(Fri) 13:25, Vitaliy Makkoveev wrote: > On Fri, May 22, 2020 at 07:57:13AM +1000, David Gwynne wrote: > > [...] > > can you try the following diff? > > > > I tested this diff and it works for me. But the problem I pointed is > about pipex(4) locking. > > pipex(4) requires NET_LOCK()

Re: [PATCH] pipex(4): rework PPP input

2020-05-23 Thread Sergey Ryazanov
Hello, On Wed, May 20, 2020 at 10:13 PM Vitaliy Makkoveev wrote: > On Wed, May 20, 2020 at 04:08:01AM +0300, Sergey Ryazanov wrote: > > On Tue, May 19, 2020 at 12:11 PM Vitaliy Makkoveev > > wrote: > > > On Mon, May 04, 2020 at 10:03:40PM +0300, Sergey Ryazanov wrote: > > > > Split checks from

Retire

2020-05-23 Thread Visa Hankala
The header is not used any longer. Consequently, it should be safe to remove the following files: sys/arch/alpha/include/varargs.h sys/arch/hppa/include/varargs.h sys/arch/i386/include/varargs.h sys/arch/landisk/include/varargs.h sys/arch/loongson/include/varargs.h

Re: ldomctl: Fail on duplicate vcpu and memory parameters

2020-05-23 Thread Klemens Nanni
On Mon, Jan 13, 2020 at 12:59:23PM +0100, Klemens Nanni wrote: > On Sun, Jan 05, 2020 at 07:09:46PM +0100, Klemens Nanni wrote: > > Domains get to define their cores and memory only once unlike the other > > parameters of which it makes sense to have more than one. > > > > $ cat dup.conf > >

Re: userland clock_gettime proof of concept

2020-05-23 Thread Paul Irofti
> Discussions. > > - /sbin/init init_main.c!start_init() map page? (deraadt@) > -> that is not the problem, the page should be mapped even there >by the sys_execve() call Robert found the proper solution to this: move the find_timekeep bits in _libc_preinit! This helps with a lot

Re: ldomctl: Make init-sytem -n check vcpu and memory constraints

2020-05-23 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Fri, 22 May 2020 17:57:37 -0600 > > There is an internal VCPU #define, but the keyword is vcpu, and there > appears to be nothing coming from the system which is an uppercase VCPU > > We don't have pfctl spitting out messages like: invalid RDOMAIN, because >

ospfctl json support

2020-05-23 Thread Richard Chivers
Hi, I have attached the first iteration of the ospf json support. Sorry about the large commit, but it had to come in one go, if we didn't want a broken implementation. I will go back and update output.c and output_json.c to remove the detail flag and instead pass through the cli parse_result as