> From: "Theo de Raadt" <[email protected]> > Date: Fri, 22 May 2020 17:57:37 -0600 > > There is an internal VCPU #define, but the keyword is vcpu, and there > appears to be nothing coming from the system which is an uppercase VCPU > > We don't have pfctl spitting out messages like: invalid RDOMAIN, because > rdomain is the keyword, there is no reason to arbitrarily change things > from LOWERCASE to UPPERCASE or even CamelCase. > > That's why I asked twice.
The error message is not referring to the keyword. It is saying in plain english that the configuration you created isn't correct because it exceeds the available rsources. In plain english we spell CPU with capital letters becuse it is an abreviation. So VCPU gets spelled the same way. > > Index: config.c > =================================================================== > RCS file: /cvs/src/usr.sbin/ldomctl/config.c,v > retrieving revision 1.38 > diff -u -p -u -r1.38 config.c > --- config.c 22 May 2020 21:54:20 -0000 1.38 > +++ config.c 22 May 2020 23:53:34 -0000 > @@ -162,7 +162,7 @@ pri_link_core(struct md *md, struct md_n > > cpu = pri_find_cpu(pid); > if (cpu == NULL) > - errx(1, "couldn't determine core for VCPU > %lld\n", pid); > + errx(1, "couldn't determine core for vcpu > %lld\n", pid); > cpu->core = core; > } > } > @@ -2819,7 +2819,7 @@ build_config(const char *filename, int n > if (primary_memory == 0 && total_memory > memory) > primary_memory = total_memory - memory; > if (num_cpus > total_cpus || primary_num_cpus == 0) > - errx(1, "not enough VCPU resources available"); > + errx(1, "not enough vcpu resources available"); > if (memory > total_memory || primary_memory == 0) > errx(1, "not enough memory available"); > > >
