A concerning commit which breaks compatibility

2020-07-23 Thread goldeneagle96
Hello OpenBSD devs. It has come to my attention that a mysterious commit , unlogged by CVS, has appeared. This commit changes language, breaking compatibility on header and source files. Thankfully, it was logged by the Github mirror. The commit's author is the Github username "djmdjm", and the

Re: pf: route-to least-states

2020-07-23 Thread Alexandr Nedvedicky
Hello Yasuoka, > - interface is not selected properly if selected table entry specifies > an interface. to be honest I don't quite understand what's going on here. can you share some details of configuration/scenario, which triggers the bug your diff is fixing? the part of

Re: A concerning commit which breaks compatibility

2020-07-23 Thread Todd C . Miller
Go away troll. - todd

Re: A concerning commit which breaks compatibility

2020-07-23 Thread Bryan Steele
On Thu, Jul 23, 2020 at 09:54:56PM +, goldeneagle96 wrote: > Hello OpenBSD devs. It has come to my attention that a mysterious commit > , unlogged by CVS, has appeared. This commit changes language, breaking > compatibility on header and source files. > Thankfully, it was logged by the Github

Re: mailwrapper: hostsat and purgestat symlinks

2020-07-23 Thread Theo de Raadt
Since there are mailers which want these features, I think removing this out of base is silly. mailwrapper exists to abstract it, and why shouldn't it remain as-is? Todd C. Miller wrote: > On Thu, 23 Jul 2020 21:41:53 +0200, Klemens Nanni wrote: > > > Ping. > > > > Feedback? Objections? OK? >

Re: top: add / as alias for g (grep)

2020-07-23 Thread Todd C . Miller
On Thu, 23 Jul 2020 22:04:24 +0200, Klemens Nanni wrote: > I've somehow hit the slash way to often for searching a particular > command, would anyone object if I added it as a command character? No objection from me. - todd

Re: mailwrapper: hostsat and purgestat symlinks

2020-07-23 Thread Todd C . Miller
On Thu, 23 Jul 2020 21:41:53 +0200, Klemens Nanni wrote: > Ping. > > Feedback? Objections? OK? Not OK as-is. This will break hoststat/purgestat for anyone who uses the sendmail port. See mail/sendmail/files/mailer.conf.sendmail in ports for how this is used. However, since these are really

Re: mailwrapper: hostsat and purgestat symlinks

2020-07-23 Thread Klemens Nanni
On Thu, Jul 23, 2020 at 10:25:01PM +0100, Jason McIntyre wrote: > yes, i supplied feedback to this diff on the day you mailed it. my reply > was: > > sendmail. they add compatibility for sendmail-compatible mailers. some > folks are used to having them around. > > i guess

Re: top: add / as alias for g (grep)

2020-07-23 Thread Jason McIntyre
On Thu, Jul 23, 2020 at 10:04:24PM +0200, Klemens Nanni wrote: > I've somehow hit the slash way to often for searching a particular > command, would anyone object if I added it as a command character? > > While here, what's up with the weird markup in top.1 for `n|# count'? > I've simplified that

Re: mailwrapper: hostsat and purgestat symlinks

2020-07-23 Thread Jason McIntyre
On Thu, Jul 23, 2020 at 09:41:53PM +0200, Klemens Nanni wrote: > On Mon, Jun 22, 2020 at 04:09:49AM +0200, Klemens Nanni wrote: > > Doing "*stat " in my shell I came across those two entries > > under /usr/bin/ which are undocumented: > > > > $ man -k any~'^(host|purge)stat$' > > man:

top: add / as alias for g (grep)

2020-07-23 Thread Klemens Nanni
I've somehow hit the slash way to often for searching a particular command, would anyone object if I added it as a command character? While here, what's up with the weird markup in top.1 for `n|# count'? I've simplified that before adopting it, `mandoc -Tlint ./top.1' is happy with it. Feedback?

Re: mailwrapper: hostsat and purgestat symlinks

2020-07-23 Thread Klemens Nanni
On Mon, Jun 22, 2020 at 04:09:49AM +0200, Klemens Nanni wrote: > Doing "*stat " in my shell I came across those two entries > under /usr/bin/ which are undocumented: > > $ man -k any~'^(host|purge)stat$' > man: nothing appropriate > > /etc/mailer.conf has no entries for them but

Re: Add ability to set control values with video(1)

2020-07-23 Thread Marcus Glocker
Hi Laurie, On Thu, 23 Jul 2020 21:07:26 +0100 Laurence Tratt wrote: > On Thu, Jul 23, 2020 at 09:56:39PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > We read the current value of the white balance temperature auto > > control (since this gets set correctly during the reset), and just

Re: Add ability to set control values with video(1)

2020-07-23 Thread Laurence Tratt
On Thu, Jul 23, 2020 at 09:56:39PM +0200, Marcus Glocker wrote: Hello Marcus, > We read the current value of the white balance temperature auto control > (since this gets set correctly during the reset), and just reset it again > on the next cam start up after the video stream has been started?

Re: Add ability to set control values with video(1)

2020-07-23 Thread Marcus Glocker
On Wed, 22 Jul 2020 21:52:27 +0100 Laurence Tratt wrote: > On Wed, Jul 22, 2020 at 10:23:19PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > > I've tested this here as well in the meantime by leaving > > mmap_init() on its original location (doesn't get involved for '-c > > reset') with

Re: pf: route-to {random,srchash} in an anchor

2020-07-23 Thread Alexandr Nedvedicky
Hello Yasuok, On Thu, Jul 23, 2020 at 08:01:18PM +0900, YASUOKA Masahiko wrote: > Hi, > > Last month, I fixed the problem "route-to least-state" in an anchor > didn't work. > > https://marc.info/?t=15911745782=1=2 > > I noticed the same problem happens on "random" and "srchash" as well. >

Re: join(1) remove redundant memory copy

2020-07-23 Thread Ingo Schwarze
Hi Martijn, this is a nice simplification, OK schwarze@. A few nits: * The MAXIMUM() macro is now unused, so i prefer that you delete the definition. * The second getline(3) argument should be size_t, not u_long, so change that in the struct declaration (it's not used anywhere else).

Re: pf: route-to least-states

2020-07-23 Thread Joerg Jung
> On 23. Jul 2020, at 13:23, YASUOKA Masahiko wrote: > > The diff fixes 2 problems of "least-states": > > - states whose address is selected by sticky-address is not counted > for the number of states. > - interface is not selected properly if selected table entry specifies > an interface.

pf: route-to least-states

2020-07-23 Thread YASUOKA Masahiko
Hi, The diff fixes 2 problems of "least-states": - states whose address is selected by sticky-address is not counted for the number of states. - interface is not selected properly if selected table entry specifies an interface. ok? Increase state counter for least-states when the address

pf: route-to {random,srchash} in an anchor

2020-07-23 Thread YASUOKA Masahiko
Hi, Last month, I fixed the problem "route-to least-state" in an anchor didn't work. https://marc.info/?t=15911745782=1=2 I noticed the same problem happens on "random" and "srchash" as well. ok? Use the table on root always if current table is not active. Index: sys/net/pf_lb.c