newfs_msdos(8): fix FAT32 partitions formatting

2021-04-26 Thread Denis Fondras
The 16-bit total count of sectors is set by newfs_msdos(8) when the number of sectors is less than MAXU16 even if asked to format in FAT32. This diff fixes that according to the FAT32 spec : "For FAT32 volumes, this field [BPB_TotSec16] must be 0" OK ? Index: newfs_msdos.c

Re: enable dt(4)

2021-04-26 Thread Stuart Henderson
On 2021/04/26 17:13, Sebastien Marie wrote: > On Mon, Apr 26, 2021 at 12:35:11PM +0200, Patrick Wildt wrote: > > Hi, > > > > as proposed by bluhm@ recently, this is the diff to enable dt(4) in > > GENERIC. The overhead should be small, and I have been using it on > > arm64 to successfully debug

Re: show negotiated capabilities in bgpctl show neighbor output

2021-04-26 Thread Denis Fondras
Le Mon, Apr 26, 2021 at 04:21:16PM +0200, Claudio Jeker a écrit : > The bgpctl show neighbor output is a bit missleading for capabilities. > It currently shows the capabilities sent by the neighbor and not the ones > that then got selected for the session. This matters especially for the >

Re: [External] : Re: pf_state_key_link_reverse() is prone to race on parallel forwarding

2021-04-26 Thread Alexander Bluhm
I have oked it. It shoud be commited before network becomes parallel. sasha: Is anything blocking this diff? On Fri, Apr 23, 2021 at 01:01:26AM +0200, Alexandr Nedvedicky wrote: > 8<---8<---8<--8< > diff --git a/sys/net/pf.c b/sys/net/pf.c

Re: Driver for Zynq-7000 system-level control registers

2021-04-26 Thread Mark Kettenis
> Date: Mon, 26 Apr 2021 14:19:38 + > From: Visa Hankala > > The following diff adds a preliminary driver for the system-level > control registers of Xilinx Zynq-7000. It enables system reset. It also > adds clock bits for use with the SDIO and Gigabit Ethernet controllers. > > On some

Re: enable dt(4)

2021-04-26 Thread Sebastien Marie
On Mon, Apr 26, 2021 at 12:35:11PM +0200, Patrick Wildt wrote: > Hi, > > as proposed by bluhm@ recently, this is the diff to enable dt(4) in > GENERIC. The overhead should be small, and I have been using it on > arm64 to successfully debug issues for a while now. I would be fine with dt(4)

show negotiated capabilities in bgpctl show neighbor output

2021-04-26 Thread Claudio Jeker
The bgpctl show neighbor output is a bit missleading for capabilities. It currently shows the capabilities sent by the neighbor and not the ones that then got selected for the session. This matters especially for the multiprotocol capability. I added the negotiated capability in the output (which

Driver for Zynq-7000 system-level control registers

2021-04-26 Thread Visa Hankala
The following diff adds a preliminary driver for the system-level control registers of Xilinx Zynq-7000. It enables system reset. It also adds clock bits for use with the SDIO and Gigabit Ethernet controllers. On some arm64 and armv7 platforms, there are separate drivers for clocks and resets.

Re: enable dt(4)

2021-04-26 Thread Alexander Bluhm
On Mon, Apr 26, 2021 at 11:27:34PM +1000, Jonathan Gray wrote: > On Mon, Apr 26, 2021 at 03:01:58PM +0200, Alexander Bluhm wrote: > > Compiled, booted, set kern.allowdt=1, created kstack on i386, amd64, > > arm64, powerpc64. > > > > does not link on armv7 > > > also missing on alpha, landisk,

Re: enable dt(4)

2021-04-26 Thread Jonathan Gray
On Mon, Apr 26, 2021 at 03:01:58PM +0200, Alexander Bluhm wrote: > On Mon, Apr 26, 2021 at 12:35:11PM +0200, Patrick Wildt wrote: > > I can't vouch that it builds for all architectures... Did anyone do > > that? Number 1 rule: don't break Theo's build. > > Compiled, booted, set kern.allowdt=1,

Re: enable dt(4)

2021-04-26 Thread Alexander Bluhm
On Mon, Apr 26, 2021 at 12:35:11PM +0200, Patrick Wildt wrote: > I can't vouch that it builds for all architectures... Did anyone do > that? Number 1 rule: don't break Theo's build. Compiled, booted, set kern.allowdt=1, created kstack on i386, amd64, arm64, powerpc64. does not link on armv7 ld

Re: iscsid/iscsictl: Introduce poll-and-wait delay during reload

2021-04-26 Thread Ashton Fagg
Claudio Jeker writes: > Hi Ashton, > > I adjusted your diff a bit (mainly cleanup of spacing and other style > changes). Please have a look. I think this version should be > committed. > > Cheers Hi Claudio, Apologies for the late reply. Thank you for the review and I'm very pleased this has

[patch] gdb: correct kernel core backtrace

2021-04-26 Thread Masato Asou
I have investigated the kernel core with gdb and found that the backtrace command does not work correctly. $ doas /usr/bin/gdb /usr/obj/sys/arch/amd64/compile/GENERIC.MP/bsd.gdb doas (a...@asou-kernelcore-tmp.soum.co.jp) password: GNU gdb 6.3 Copyright 2004 Free Software Foundation, Inc. GDB is

Re: Unlock top part of uvm_fault()

2021-04-26 Thread Alexander Bluhm
On Mon, Apr 26, 2021 at 12:57:33PM +0200, Mark Kettenis wrote: > > I did measure kernel build time make -j 4 on a 4 core machine. > > System time goes down by 7.7%, real time stays the same. > > That basically suggests that contention of the kernel lock isn't the > major bottleneck for this

Re: Unlock top part of uvm_fault()

2021-04-26 Thread Mark Kettenis
> Date: Mon, 26 Apr 2021 12:43:27 +0200 > From: Alexander Bluhm > > On Thu, Apr 22, 2021 at 03:38:53PM +0200, Martin Pieuchot wrote: > > Diff below remove the KERNEL_LOCK()/UNLOCK() dance from uvm_fault() for > > both amd64 and sparc64. That means the kernel lock will only be taken > > for

Re: Unlock top part of uvm_fault()

2021-04-26 Thread Alexander Bluhm
On Thu, Apr 22, 2021 at 03:38:53PM +0200, Martin Pieuchot wrote: > Diff below remove the KERNEL_LOCK()/UNLOCK() dance from uvm_fault() for > both amd64 and sparc64. That means the kernel lock will only be taken > for lower faults and some amap/anon code will now run without it. > > I'd be

enable dt(4)

2021-04-26 Thread Patrick Wildt
Hi, as proposed by bluhm@ recently, this is the diff to enable dt(4) in GENERIC. The overhead should be small, and I have been using it on arm64 to successfully debug issues for a while now. I can't vouch that it builds for all architectures... Did anyone do that? Number 1 rule: don't break

Re: vmd(8): fix vmctl wait state corruption

2021-04-26 Thread Mischa
> On 24 Apr 2021, at 20:56, Dave Voutila wrote: > > > Dave Voutila writes: > >> Dave Voutila writes: >> >>> vmd(8) users of tech@, >>> >>> NOTE: I have no intention to try to commit this prior to 6.9's release >>> due to its complexity, but I didn't want to "wait" to solicit testers or >>>

Re: [External] : arp mbuf queue

2021-04-26 Thread Alexandr Nedvedicky
Hello, > > > > would it make sense to have let's say > > > > mq_move2mlist(struct mbuf_queue *, struct mbuf_list *) > > This already exists, it's called mq_delist() > thanks, I've missed that when skimming through sources. > > > > This would allow as to move whole