Re: Non-statically compiled utilities in /sbin

2021-11-13 Thread Theo de Raadt
Hey you have the source code, and could have figured this out in a few minutes. iked/Makefile: revision 1.14 date: 2015/10/22 15:14:27; author: reyk; state: Exp; lines: +4 -1; commitid: H3YSN6oyq ntUT6Jo; Stop linking iked -static: It was inherited from isakmpd that is -static for

Non-statically compiled utilities in /sbin

2021-11-13 Thread Alessandro De Laurenzis
Greeting, From hier(7): /sbin/ System programs and administration utilities fundamental to both single and multi-user environments. These programs are statically compiled and therefore do not depend on any system libraries to run. I see 2 exceptions here:

Re: ifconfig.8: autoconf implies up

2021-11-13 Thread Theo de Raadt
It was a bit of a battle getting here ("dhcp" did it, but the others didn't, and some people complained it changed their configs). Yes, it can be documented now. Klemens Nanni wrote: > Since march 2021 setting AUTOCONF{4,6} sets UP as well unconditionally. > I have lots of hostname.if files

Re: IPsec tdb ref counting

2021-11-13 Thread Vitaliy Makkoveev
Hi, Do you have panics with this diff? Index: sys/net/if_bridge.c === RCS file: /cvs/src/sys/net/if_bridge.c,v retrieving revision 1.358 diff -u -p -r1.358 if_bridge.c --- sys/net/if_bridge.c 11 Nov 2021 18:08:17 - 1.358

ifconfig.8: autoconf implies up

2021-11-13 Thread Klemens Nanni
Since march 2021 setting AUTOCONF{4,6} sets UP as well unconditionally. I have lots of hostname.if files containing only "inet6 autoconf" without "up" and it works, but I noticed this isn't documented anywhere. Neither do we remove UP and/or RUNNING on `-autoconf' and neither do we document this.

Re: IPsec tdb ref counting

2021-11-13 Thread Vitaliy Makkoveev
On Sat, Nov 13, 2021 at 09:49:31PM +, Stuart Henderson wrote: > On 2021/11/13 18:04, Alexander Bluhm wrote: > > Hi, > > > > To make IPsec MP safe we need refcounting for the tdb. The diff > > below is part of something bigger we have at genua. Although it > > does not cover timeouts and the

Re: IPsec tdb ref counting

2021-11-13 Thread Stuart Henderson
On 2021/11/13 23:05, Stuart Henderson wrote: > On 2021/11/13 22:41, Stuart Henderson wrote: > > On 2021/11/13 21:49, Stuart Henderson wrote: > > > On 2021/11/13 18:04, Alexander Bluhm wrote: > > > > Hi, > > > > > > > > To make IPsec MP safe we need refcounting for the tdb. The diff > > > > below

vport: set UP on ip assign

2021-11-13 Thread Klemens Nanni
Practically all interfaces pull itself up when IPs get assigned, but vport(4) does not. This broke IPv4 networking for me on a router I switched from bridge(4) to veb(4) because hostname.vport0 only contained the equivalent of descr LAN inet 192.0.2.1 inet6 2001:db8::1

Re: snmpd: tweak listen on

2021-11-13 Thread Martijn van Duren
On Sat, 2021-11-13 at 13:23 +, Stuart Henderson wrote: > On 2021/08/09 20:55, Martijn van Duren wrote: > > On Mon, 2021-08-09 at 11:57 +0200, Martijn van Duren wrote: > > > > > > This diff fixes all of the above: > > > - Allow any to be used resolving to 0.0.0.0 and :: > > > - Set

Re: IPsec tdb ref counting

2021-11-13 Thread Stuart Henderson
On 2021/11/13 22:41, Stuart Henderson wrote: > On 2021/11/13 21:49, Stuart Henderson wrote: > > On 2021/11/13 18:04, Alexander Bluhm wrote: > > > Hi, > > > > > > To make IPsec MP safe we need refcounting for the tdb. The diff > > > below is part of something bigger we have at genua. Although it

Re: IPsec tdb ref counting

2021-11-13 Thread Stuart Henderson
On 2021/11/13 21:49, Stuart Henderson wrote: > On 2021/11/13 18:04, Alexander Bluhm wrote: > > Hi, > > > > To make IPsec MP safe we need refcounting for the tdb. The diff > > below is part of something bigger we have at genua. Although it > > does not cover timeouts and the tdb reaper yet, I

Re: Remove stale note from poll/select manual pages

2021-11-13 Thread Todd C . Miller
On Sat, 13 Nov 2021 08:41:58 -0700, "Theo de Raadt" wrote: > Great that it is fixed now for us, however this remains a big problem on > older systems. So the question is should we mention this as a coding > hazard for developers, or should we ignore the problem. This is an implementation detail

Re: IPsec tdb ref counting

2021-11-13 Thread Stuart Henderson
On 2021/11/13 18:04, Alexander Bluhm wrote: > Hi, > > To make IPsec MP safe we need refcounting for the tdb. The diff > below is part of something bigger we have at genua. Although it > does not cover timeouts and the tdb reaper yet, I want to get this > in as a frist step. > > It passes

IPsec tdb ref counting

2021-11-13 Thread Alexander Bluhm
Hi, To make IPsec MP safe we need refcounting for the tdb. The diff below is part of something bigger we have at genua. Although it does not cover timeouts and the tdb reaper yet, I want to get this in as a frist step. It passes regress but there are setups that are not covered. Bridge and

urndis0: IOERROR

2021-11-13 Thread Mikhail
Hello, I get aforesaid error when trying to plug in my 4G usb modem, it works well on another laptop with windows 10. I enabled debug info, but seem the failure somewhere deeper in usb stack and I wasn't able to catch it, can someone advice me on further debugging efforts? urndis0 at uhub3 port

Re: UNIX sockets: move garbage collector data out from `unp_lock'

2021-11-13 Thread Vitaliy Makkoveev
On Fri, Nov 12, 2021 at 03:28:42AM +0300, Vitaliy Makkoveev wrote: > The final step before rework UNIX sockets to fine grained locks. Except > `unp_ino' this leaves only per-socket data protected by `unp_lock'. The > `unp_ino' protection is not the big deal and will be done with mutex(9) > in the

Re: Remove stale note from poll/select manual pages

2021-11-13 Thread Theo de Raadt
Great that it is fixed now for us, however this remains a big problem on older systems. So the question is should we mention this as a coding hazard for developers, or should we ignore the problem. Visa Hankala wrote: > The poll(2) and select(2) manual pages say that the system calls perform >

Re: snmpd: tweak listen on

2021-11-13 Thread Theo de Raadt
Stuart Henderson wrote: > On 2021/08/09 20:55, Martijn van Duren wrote: > > On Mon, 2021-08-09 at 11:57 +0200, Martijn van Duren wrote: > > > > > > This diff fixes all of the above: > > > - Allow any to be used resolving to 0.0.0.0 and :: > > > - Set SO_REUSEADDR on sockets, so we can listen on

Re: snmpd: tweak listen on

2021-11-13 Thread Stuart Henderson
On 2021/08/09 20:55, Martijn van Duren wrote: > On Mon, 2021-08-09 at 11:57 +0200, Martijn van Duren wrote: > > > > This diff fixes all of the above: > > - Allow any to be used resolving to 0.0.0.0 and :: > > - Set SO_REUSEADDR on sockets, so we can listen on both any and > >   localhost > > -

Re: installer: prompt for WEP only if available

2021-11-13 Thread Klemens Nanni
On Tue, Nov 02, 2021 at 05:43:03PM +, Klemens Nanni wrote: > On Tue, Nov 02, 2021 at 05:26:17PM +, Klemens Nanni wrote: > > At least bwfm(4) does not support WEP: > > > > # ifconfig bwfm0 nwkey 12345 > > ifconfig: SIOCS80211NWKEY: Operation not supported by device > >

Remove stale note from poll/select manual pages

2021-11-13 Thread Visa Hankala
The poll(2) and select(2) manual pages say that the system calls perform poorly if there is overlapping monitoring. This note can be removed as the kqueue-based code does not suffer from select collisions. OK? Index: lib/libc/sys/poll.2

Use nowake when poll/select has no fds to monitor

2021-11-13 Thread Visa Hankala
The poll(2) and select(2) system calls block until: * the monitored set of file descriptors has a pending event, * the timeout expires, or * a signal has been received. If the monitored fd set is empty, the system calls block until timeout or signal. This is handled by special cases in the

Re: make.1: sync variable substitution bits with NetBSD

2021-11-13 Thread Klemens Nanni
On Sat, Dec 26, 2020 at 05:19:55PM +0100, Klemens Nanni wrote: > Our make(1) is behind NetBSD's and FreeBSD's make(1) on at least the > rules of variable substitution. > > Our DESCRIPION says > > There are seven different types of lines in a makefile: dependency lines, > shell