usbd_new_device: consolidate error paths

2021-12-02 Thread Anton Lindqvist
Hi, Consolidate error paths in usbd_new_device, shaving of 14 lines. Comments? OK? diff --git sys/dev/usb/usb_subr.c sys/dev/usb/usb_subr.c index a11bc448ece..74fe4c3b4db 100644 --- sys/dev/usb/usb_subr.c +++ sys/dev/usb/usb_subr.c @@ -1086,11 +1086,8 @@ usbd_new_device(struct device *parent,

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-02 Thread Tom Murphy
Hi, I've tested the second diff (containing the bug fix and I get a lock order reversal on bootup. On the first patch I was getting the same lock order reversal while using X and sometimes (only sometimes) would crash X. witness: lock order reversal: 1st 0xfd83fef05248 uobjlk (>vmobjlock)

Re: Rework UNIX sockets locking to be fine grained

2021-12-02 Thread Vitaliy Makkoveev
Thanks! Bulk build make us sure all packages have been built with new headers. > On 2 Dec 2021, at 16:26, Christian Weisgerber wrote: > > Vitaliy Makkoveev: > >> Include missing "sys/refcnt.h" header to unpcb.h to fix libkvm and >> netstat(1) build. No functional changes. > > I ran an amd64

Re: bsd.upgrade fails `umount /mnt` with a single partition disk.

2021-12-02 Thread Florian Obser
This reads correct. OK florian On 2021-12-02 00:01 -07, "Theo de Raadt" wrote: > Yuichiro NAITO wrote: > >> bsd.upgrade fails and shows following messages with a single partition disk. >> >> ``` >> Force checking of clean non-root filesystems? [no] no >> umount: /mnt: Device busy >> Can't

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-02 Thread Klemens Nanni
On Mon, Nov 29, 2021 at 10:50:32PM +0100, Martin Pieuchot wrote: > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > Diff below unlock the bottom part of the UVM fault handler. I'm > > interested in squashing the remaining bugs. Please test with your usual > > setup & report back. > > Thanks

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-12-02 Thread Alexander Bluhm
On Mon, Nov 29, 2021 at 10:50:32PM +0100, Martin Pieuchot wrote: > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > Diff below unlock the bottom part of the UVM fault handler. I'm > > interested in squashing the remaining bugs. Please test with your usual > > setup & report back. > > Thanks

Re: Rework UNIX sockets locking to be fine grained

2021-12-02 Thread Christian Weisgerber
Vitaliy Makkoveev: > Include missing "sys/refcnt.h" header to unpcb.h to fix libkvm and > netstat(1) build. No functional changes. I ran an amd64 package bulk build with this, four ncpu=4 machines. No problems. (Other than for dpb's ssh connection multiplexing, I don't think Unix domain sockets

Re: sppp(4)/pppoe(4) - avoid endless loop in remote ip negotiation

2021-12-02 Thread Mikolaj Kucharski
On Fri, Nov 26, 2021 at 01:35:14PM +0100, Krzysztof Kanas wrote: > Hi. When remote side in sppp doesn't reply for to PPP IPCP IP-Address > sppp will try to negotiate remote IP in endless loop. Instead use > 10.64.64.1 + if_index as remote IP. > Okay, but why it doesn't reply? I don't use

Re: sppp(4)/pppoe(4) - avoid endless loop in remote ip negotiation

2021-12-02 Thread Stuart Henderson
On 2021/12/01 20:58, Krzysztof Kanas wrote: > On 2021-12-01 10:21, Klemens Nanni wrote: > > On Fri, Nov 26, 2021 at 01:35:14PM +0100, Krzysztof Kanas wrote: > > > Hi. When remote side in sppp doesn't reply for to PPP IPCP IP-Address > > > sppp will try to negotiate remote IP in endless loop.

Re: ipsec useless inner header

2021-12-02 Thread Klemens Nanni
On Thu, Dec 02, 2021 at 01:24:36AM +0100, Alexander Bluhm wrote: > ipsec_common_input_cb() extracts the inner IP header of IPsec > tunnels. It is never used, so this is useless code. OK kn