On Sun, Jan 16, 2022 at 06:17:16AM +, Visa Hankala wrote:
> On Sun, Jan 16, 2022 at 02:41:46PM +1000, David Gwynne wrote:
> > if you're in bpfclose or tun/tap close, you're the last one out. this
> > means that there shouldn't be anything else in poll/select/kevent/etc
> > because you're the
On Sun, Jan 16, 2022 at 02:41:46PM +1000, David Gwynne wrote:
> if you're in bpfclose or tun/tap close, you're the last one out. this
> means that there shouldn't be anything else in poll/select/kevent/etc
> because you're the last one out.
>
> from what i can tell, tun and bpf are the only
Hello, OpenBSD Developers!
Here's my code which implements this new feature, however it doesn't always
work as intended:
-
https://github.com/time-killer-games/bugs/blob/679d333cd947cb4cbec7c45485157b305aa0757b/apifilesystem/filesystem.cpp#L55-L62
-
if you're in bpfclose or tun/tap close, you're the last one out. this
means that there shouldn't be anything else in poll/select/kevent/etc
because you're the last one out.
from what i can tell, tun and bpf are the only drivers that do this, and
i dont think they need to.
ok?
Index: bpf.c
On Sat, Jan 15, 2022 at 12:36 PM Christian Weisgerber
wrote:
> sbin/isakmpd: fix -Wunused-but-set-variable warnings
>
> The one in pf_key_v2.c could use an extra set of eyes, but I don't
> think there are any side effects.
>
The involved variables in pf_key_v2.c were added in 2000 as part of
On Wed, Dec 08, 2021 at 07:45:50PM -0600, Brian Conway wrote:
> Ping with complete diff. Thanks.
>
> Brian Conway
>
Catching up on old emails. Committed. Thanks.
-ml
> diff --git usr.sbin/vmd/mc146818.c usr.sbin/vmd/mc146818.c
> index e3599c685..001c1a055 100644
> --- usr.sbin/vmd/mc146818.c
>
sbin/isakmpd: fix -Wunused-but-set-variable warnings
The one in pf_key_v2.c could use an extra set of eyes, but I don't
think there are any side effects.
M sbin/isakmpd/ipsec.c
M sbin/isakmpd/pf_key_v2.c
M sbin/isakmpd/udp_encap.c
M sbin/isakmpd/x509.c
diff
sbin/pfctl: fix -Wunused-but-set-variable warning
M sbin/pfctl/pfctl_optimize.c
diff 7c5dd09ecd1ff078b868c9ab52aac9754cde7761
6e5c342a53c05496c18849837c67b7dc05ce3792
blob - 1ab170a832dd183a2895774549ff93896803039a
blob + 5736a0d7b0ba04afeed855daa61fc6b5ef3894e4
---
Since the switch to LLVM 13, there are a number of compiler warnings
in base about variables that are assigned to but never used. Let's
start picking the low-hanging fruit, ok?
lib/libfuse: fix -Wunused-but-set-variable warning
M lib/libfuse/fuse_opt.c
diff
On Sat, Jan 15, 2022 at 01:34:35PM +0100, Mark Kettenis wrote:
> > Date: Sat, 15 Jan 2022 12:21:59 +
> > From: Visa Hankala
> >
> > If the ending address in sfcc_cache_wbinv_range(), pa + len, is not
> > cache-line-aligned, the function spins because len wraps around.
> > The following patch
On Sat, Jan 15, 2022 at 11:54:00PM +1100, Jonathan Gray wrote:
> On Sat, Jan 15, 2022 at 12:21:59PM +, Visa Hankala wrote:
> > If the ending address in sfcc_cache_wbinv_range(), pa + len, is not
> > cache-line-aligned, the function spins because len wraps around.
> > The following patch fixes
> Date: Sat, 15 Jan 2022 23:54:00 +1100
> From: Jonathan Gray
>
> On Sat, Jan 15, 2022 at 12:21:59PM +, Visa Hankala wrote:
> > If the ending address in sfcc_cache_wbinv_range(), pa + len, is not
> > cache-line-aligned, the function spins because len wraps around.
> > The following patch
On Sat, Jan 15, 2022 at 12:21:59PM +, Visa Hankala wrote:
> If the ending address in sfcc_cache_wbinv_range(), pa + len, is not
> cache-line-aligned, the function spins because len wraps around.
> The following patch fixes this.
>
> There still is a subtle detail. If len is zero but pa is
> Date: Sat, 15 Jan 2022 12:21:59 +
> From: Visa Hankala
>
> If the ending address in sfcc_cache_wbinv_range(), pa + len, is not
> cache-line-aligned, the function spins because len wraps around.
> The following patch fixes this.
>
> There still is a subtle detail. If len is zero but pa is
If the ending address in sfcc_cache_wbinv_range(), pa + len, is not
cache-line-aligned, the function spins because len wraps around.
The following patch fixes this.
There still is a subtle detail. If len is zero but pa is non-aligned,
the function is not a no-op. However, shouldn't upper layers
15 matches
Mail list logo
