rc.d/unbound: enable configtest

2023-09-16 Thread Bjorn Ketelaars
Currently /etc/rc.d/unbound only checks a configuration (using unbound-checkconf) upon starting as part of rc_pre(). It would would be nice to have a configtest, which checks a configuration before restarting/reloading as well. I recently got bitten by a cron script, which made _invalid_ changes

Re: pf.conf / scrub resulting in invalid checksum

2022-10-09 Thread Bjorn Ketelaars
On Sun 09/10/2022 17:10, Björn Ketelaars wrote: > I'm using mcast-proxy from ports as multicast routing proxy for use with > my ISP's iptv platform. After some setting up i noticed from > mcast-proxy's logging that all incoming packets are dropped because of > IP invalid checksums [0]. At first I

Re: pppoe(4): reorder interface destruction and initialization

2022-07-09 Thread Bjorn Ketelaars
On Tue 05/07/2022 21:15, Vitaliy Makkoveev wrote: > pppoe_timeout() and pppoe_clone_destroy() are both executed with kernel > lock held, but they are not serialized because pppoe_timeout() has the > sleep point provided by netlock. We should use timeout_del_barrier(9) to > ensure pppoe_timeout()

Re: unwind(8): simplify query parsing

2022-03-13 Thread Bjorn Ketelaars
On Sun 13/03/2022 14:06, Florian Obser wrote: > anyone? > > On 2022-03-03 19:57 +01, Florian Obser wrote: > > parse_packet() is used by unbound(8) to parse response packets, not > > queries. There is no need to do all this work just to get access to > > the query id and flags. This is what

typo in comment lib/libssl/ssl_ciph.c

2022-03-04 Thread Bjorn Ketelaars
Small typo in lib/libssl/ssl_ciph.c, `ssl_cipher_get_aead_evp` should read `ssl_cipher_get_evp_aead`. OK? diff --git lib/libssl/ssl_ciph.c lib/libssl/ssl_ciph.c index 13dcd905255..160a0dea8eb 100644 --- lib/libssl/ssl_ciph.c +++ lib/libssl/ssl_ciph.c @@ -448,7 +448,7 @@ ssl_cipher_get_evp(const

Re: dhcpleased(8): host name DHCP option

2022-01-03 Thread Bjorn Ketelaars
On Sat 01/01/2022 11:37, Florian Obser wrote: > ping > On 2021-12-24 10:16 +01, Florian Obser wrote: > > Make host name DHCP option configurable. > > Diff from ha...@sdf.org, tweaks by me. > > > > RFC 2132 says a host name must have a lenght of at least 1, so we can > > use strlen(h_name) == 0 to

Print learned DNS from sppp(4) in ifconfig(8)

2021-11-16 Thread Bjorn Ketelaars
Like umb(4), sppp(4) natively learns DNS information. Among the differences between these two devices is that umb prints this information from ifconfig(8) and sppp does not. I would like to equalize this behaviour, and add the necessary bits to sppp(4) and ifconfig(8). Diff below is largely based

Re: Teach manpages of resolv(8) and unwindctl(8) about sppp(4)

2021-11-10 Thread Bjorn Ketelaars
On Wed 10/11/2021 21:20, Klemens Nanni wrote: > I think only unwind(8) should list all the inputs and unwindctl(8) > should just say "Show learned nameservers". > > unwind(8) is already incomplete regardless of sppp(4) and unwindctl(8) > is a poor duplicate of it. I agree with unwindctl(8). For

Re: give sppp(4) its own RTM_PROPOSAL priority

2021-11-10 Thread Bjorn Ketelaars
On Wed 10/11/2021 16:53, Sebastien Marie wrote: > On Wed, Nov 10, 2021 at 04:22:49PM +0100, Bjorn Ketelaars wrote: > > sppp(4) is currently using RTP_PROPOSAL_STATIC for sending DNS > > proposals, whereas all others sources, e.g. umb(4), are using a specific > > va

Teach manpages of resolv(8) and unwindctl(8) about sppp(4)

2021-11-10 Thread Bjorn Ketelaars
Like umb(4), sppp(4) is natively learning DNS information. Diff below adds this information to the manpages of resolv(8) and unwindctl(8). While here, also mention umb(4) in unwindctl's manpage. Thanks to kn@ for noticing the above. Comments/OK? diff --git sbin/resolvd/resolvd.8

give sppp(4) its own RTM_PROPOSAL priority

2021-11-10 Thread Bjorn Ketelaars
sppp(4) is currently using RTP_PROPOSAL_STATIC for sending DNS proposals, whereas all others sources, e.g. umb(4), are using a specific value. Diff below fixes this by adding RTP_PROPOSAL_PPP. Although the diff is limited in size it touches several pieces: - sppp(4) - route(4) - route(8) -

Re: sppp(4)/pppoe(4) - DNS configuration via resolvd(8)

2021-11-09 Thread Bjorn Ketelaars
On Mon 08/11/2021 11:52, Bjorn Ketelaars wrote: > Diff below does two things: > 1. add PPP IPCP extensions for name server addresses (rfc1877) to >sppp(4) > 2. propose negotiated name servers from sppp(4) to resolvd(8) using >RTM_PROPOSAL_STATIC route messages. Updated di

sppp(4)/pppoe(4) - DNS configuration via resolvd(8)

2021-11-08 Thread Bjorn Ketelaars
Diff below does two things: 1. add PPP IPCP extensions for name server addresses (rfc1877) to sppp(4) 2. propose negotiated name servers from sppp(4) to resolvd(8) using RTM_PROPOSAL_STATIC route messages. With this I'm able to use DNS servers as provided by my ISP who uses PPPoE.

Re: dhcpleased(8): ignore servers / parts of lease

2021-08-08 Thread Bjorn Ketelaars
On Sun 08/08/2021 12:37, Florian Obser wrote: > This implements ignoring of nameservers and / or routes in leases as > well as completely ignoring servers (you cannot block rogue DHCP servers > in pf because bpf sees packets before pf). > > Various people voiced the need for these features. >

add /etc/dhcpleased.conf to changelist(5)

2021-07-30 Thread Bjorn Ketelaars
Watch /etc/dhcpleased.conf. OK? Index: changelist === RCS file: /cvs/src/etc/changelist,v retrieving revision 1.127 diff -u -p -r1.127 changelist --- changelist 13 Sep 2020 10:03:46 - 1.127 +++ changelist 30 Jul 2021

Re: dhcpleased: default route with classless static routes option

2021-07-18 Thread Bjorn Ketelaars
On Sun 18/07/2021 10:38, Florian Obser wrote: > On 2021-07-18 01:02 +02, Bjorn Ketelaars wrote: > > On Sat 17/07/2021 17:12, Florian Obser wrote: > >> > >> > >> On 17 July 2021 13:16:59 CEST, Bjorn Ketelaars wrote: > >> >An inconsistency e

Re: dhcpleased: default route with classless static routes option

2021-07-17 Thread Bjorn Ketelaars
On Sat 17/07/2021 17:12, Florian Obser wrote: > > > On 17 July 2021 13:16:59 CEST, Bjorn Ketelaars wrote: > >An inconsistency exists between dhclient(8) and dhcpleased(8) when > >receiving the Classless Static Routes option: dhcpleased creates a > >default

dhcpleased: default route with classless static routes option

2021-07-17 Thread Bjorn Ketelaars
An inconsistency exists between dhclient(8) and dhcpleased(8) when receiving the Classless Static Routes option: dhcpleased creates a default route, while dhclient does not. If I'm not mistaken, the behaviour of dhclient is correct. From rfc3442: "If the DHCP server returns both a Classless

Re: iwm(4): Tx aggregation

2021-04-29 Thread Bjorn Ketelaars
On Fri 30/04/2021 00:03, Stefan Sperling wrote: > This is another patch for Tx aggregation support in iwm(4). > I have tested 7265, 8265, and 9560, and they seem to work. > > Causes of various fatal firmware errors from my earlier attempts at > getting this to work have been identified and fixed

Re: install rc.d script for resolvd

2021-02-27 Thread Bjorn Ketelaars
On Sat 27/02/2021 07:37, Bjorn Ketelaars wrote: > resolvd will not start at boot without its rc.d script. > > OK? Additionally register rc.d/resolvd in sets list. Index: distrib/sets/lists/base/mi === RCS file: /cvs/sr

dpb.1 - reuse DPB_PROPERTIES=tag mechanism

2021-02-27 Thread Bjorn Ketelaars
Change the description of the 'tag' property to something more generic: - There are no more ports that have DPB_PROPERTIES=tag:{kde3,kde4} set in their Makefile; - Explain that only one tag set can be used. The 'tag' property comes in handy to solve a dpb build issue with the two audacious

install rc.d script for resolvd

2021-02-26 Thread Bjorn Ketelaars
resolvd will not start at boot without its rc.d script. OK? Index: Makefile === RCS file: /cvs/src/etc/Makefile,v retrieving revision 1.481 diff -u -p -r1.481 Makefile --- Makefile26 Feb 2021 17:18:41 - 1.481 +++

Re: m_defrag(9) leak

2020-09-02 Thread Bjorn Ketelaars
On Tue 25/08/2020 08:42, Martin Pieuchot wrote: > Maxime Villard mentioned a leak due to a missing m_freem() in wg(4): > https://marc.info/?l=netbsd-tech-net=159827988018641=2 > > It seems to be that such leak is present in other uses of m_defrag() in > the tree. I won't take the time to

Re: net80211: use QoS frames for A-MPDUs only

2020-03-03 Thread Bjorn Ketelaars
On Tue 03/03/2020 11:06, Stefan Sperling wrote: > Since I currently don't have any iwn(4) hardware with me I would appreciate > if someone could test this diff with iwn(4) in 11n mode. > Just checking whether an 11n wifi connection on a WPA2 network still works > is good enough for testing this.