Re: smtpd: use libtls signer

2022-02-12 Thread Eric Faurot
On Sun, Jan 30, 2022 at 10:55:40AM +0100, Eric Faurot wrote: > Hi. > > This diff makes use of the new libtls signer api to simplify tls privsep. Updated diff after libtls signer api tweak by jsing@ Eric. Index: ca.c ===

smtpd: use libtls signer

2022-01-30 Thread Eric Faurot
Hi. This diff makes use of the new libtls signer api to simplify tls privsep. Eric. Index: ca.c === RCS file: /cvs/src/usr.sbin/smtpd/ca.c,v retrieving revision 1.40 diff -u -p -r1.40 ca.c --- ca.c14 Jun 2021 17:58:15 -

Re: iwx(4) 40MHz channel support

2021-10-12 Thread Eric Auge
+1 improvement here too. before: ~50 mbit/s after: ~75 mbit/s hth, cheers, eric. On Tue, Oct 12, 2021 at 8:27 PM Felix Kronlage-Dammers wrote: > > On Tue, Oct 12, 2021 at 04:29:47PM +0200, Hrvoje Popovski wrote: > > > > Please sync your source tree before attempting t

smtpd: srs and ruleset evaluation

2021-09-22 Thread Eric Faurot
Hi. A user reported that decoded SRS addresses are not correctly evaluated against the ruleset. That's because the ruleset always matches against the expanded address ("dest") and not the original address ("rcpt"). This diff should fix it. Eric.

Re: updated patch for iwx(4) Tx aggregation

2021-09-11 Thread Eric Auge
oad speed.. Upload: 74.45 Mbit/s HTH, Eric. On Sat, Sep 11, 2021 at 12:15 PM Stefan Sperling wrote: > > On Fri, Sep 10, 2021 at 06:49:49PM +0200, Stefan Sperling wrote: > > Here is another attempt at adding T

Re: update xf86-video-amdgpu to latest git

2021-07-09 Thread Eric Auge
Hello, X1 gen5 continues to work fine. X1 gen9 x11 stopped crashing and is now usable! (Tiger lake) Thank you! Eric On Thu, 8 Jul 2021 at 09:41, Jonathan Gray wrote: > > The latest xf86-video-amdgpu release was in 2019. > > xf86-video-amdgpu-19.1.0..origin/master > > minus

smtpd: unnecessary "no certificate presented" log message

2021-06-30 Thread Eric Faurot
Except for specific cases, SMTP servers do not expect client certificates for TLS sessions. The log message for missing certificate is not very useful in practice (handshake fails before if it was required anyway), and it is even confusing for people. I think it can go away. Eric. Index

Re: add table_procexec in smtpd

2021-06-12 Thread Eric Faurot
tation could be factorized a bit, but that's a detail at this time. I think the close operation (is it really useful anyway?) should use fclose() instead of kill(), and maybe wait() too? Eric.

Re: smtpd: includes cleanup

2021-06-09 Thread Eric Faurot
Hi. Slightly updated diff, including sys/tree.h in smtpd.h. Eric. Index: aliases.c === RCS file: /cvs/src/usr.sbin/smtpd/aliases.c,v retrieving revision 1.78 diff -u -p -r1.78 aliases.c --- aliases.c 28 Apr 2020 21:46:43 -

Re: smtpd: includes cleanup

2021-05-27 Thread Eric Faurot
On Thu, May 27, 2021 at 08:13:36AM -0600, Todd C. Miller wrote: > On Thu, 27 May 2021 13:14:30 +0200, Eric Faurot wrote: > > > New diff with small tweaks. > > It looks like you are relying on sys/queue.h being included implicitly. > Since smtpd.h uses the TAILQ macros,

Re: smtpd: includes cleanup

2021-05-27 Thread Eric Faurot
New diff with small tweaks. Eric. Index: aliases.c === RCS file: /cvs/src/usr.sbin/smtpd/aliases.c,v retrieving revision 1.78 diff -u -p -r1.78 aliases.c --- aliases.c 28 Apr 2020 21:46:43 - 1.78 +++ aliases.c 26 May

smtpd: includes cleanup

2021-05-26 Thread Eric Faurot
Cruft has accumulated on that front. This diff cleans it up: the few headers that are directly required for smtpd.h are included there, and unnecessary includes are removed from the rest of the files. Eric. Index: aliases.c === RCS

smtpd: err/errx -> fatal/fatalx

2021-05-26 Thread Eric Faurot
() is called early in smtpctl.c, since it uses files (iobuf.c) that uses the log api. It still logs to stderr though. Eric. Index: bounce.c === RCS file: /cvs/src/usr.sbin/smtpd/bounce.c,v retrieving revision 1.83 diff -u -p -r1.83 bounce.c

smtpd: unused code

2021-05-25 Thread Eric Faurot
This diff removes more unused code. Eric. Index: config.c === RCS file: /cvs/src/usr.sbin/smtpd/config.c,v retrieving revision 1.55 diff -u -p -r1.55 config.c --- config.c9 Apr 2021 16:43:43 - 1.55 +++ config.c25

smtp: more tls options

2021-05-22 Thread Eric Faurot
(undocumented) that can be recycled too Eric. Index: smtp.1 === RCS file: /cvs/src/usr.sbin/smtpd/smtp.1,v retrieving revision 1.11 diff -u -p -r1.11 smtp.1 --- smtp.1 22 May 2021 12:16:06 - 1.11 +++ smtp.1 22 May

Re: smtp(1): protocols and ciphers

2021-05-20 Thread Eric Faurot
Here is an updated diff integrating different suggestions I received. - use -T (for TLS) instead of -O - use getsubopt(3) which I didn't know - manpage tweaks Eric. Index: smtp.1 === RCS file: /cvs/src/usr.sbin/smtpd/smtp.1,v

smtp(1): protocols and ciphers

2021-05-14 Thread Eric Faurot
Hello. This diff allows to specify protcols and ciphers in smtp(1). I thought it was cleaner to added a generic -O option flag for this. Eric. Index: smtp.1 === RCS file: /cvs/src/usr.sbin/smtpd/smtp.1,v retrieving revision 1.9

Re: smtpd: remove tls_accept/tls_connect callbacks

2021-04-28 Thread Eric Faurot
On Wed, Apr 21, 2021 at 11:21:51AM +0200, Eric Faurot wrote: > There is actually no reason to defer calls to tls_accept_socket() and > tls_connect_socket() in an event callback. The code can be simplified > by a great deal. It also eliminates the issue of keeping a reference > to

smtpd: remove tls_accept/tls_connect callbacks

2021-04-21 Thread Eric Faurot
There is actually no reason to defer calls to tls_accept_socket() and tls_connect_socket() in an event callback. The code can be simplified by a great deal. It also eliminates the issue of keeping a reference to the listener tls context in the io structure. Eric. Index: ioev.c

Re: smtpd: more unused code

2021-04-20 Thread Eric Faurot
On Sun, Apr 11, 2021 at 01:54:32PM +0200, Eric Faurot wrote: > Certificate verification is done by libtls. The former code is not used > anymore and can be unplugged. Anyone willing to ok this? > Eric. > > Inde

Re: smtpd: more unused code

2021-04-12 Thread Eric Faurot
On Mon, Apr 12, 2021 at 07:56:57AM -0400, Dave Voutila wrote: > > Eric Faurot writes: > > > Certificate verification is done by libtls. The former code is not used > > anymore and can be unplugged. > > Should cert.c be removed? I don't think it's used by smtp{d,ctl}

smtpd: more unused code

2021-04-11 Thread Eric Faurot
Certificate verification is done by libtls. The former code is not used anymore and can be unplugged. Eric. Index: dispatcher.c === RCS file: /cvs/src/usr.sbin/smtpd/dispatcher.c,v retrieving revision 1.2 diff -u -p -r1.2

smtpd: unused files and dependency

2021-04-10 Thread Eric Faurot
Do not build unused files and remove related prototypes. Also remove bogus libm dependency. Index: smtpd.h === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.h,v retrieving revision 1.666 diff -u -p -r1.666 smtpd.h --- smtpd.h 10 Apr

smtp: dead code

2021-04-10 Thread Eric Faurot
This diff removes unused code and lib depends from smtp(1). Eric. Index: smtpc.c === RCS file: /cvs/src/usr.sbin/smtpd/smtpc.c,v retrieving revision 1.14 diff -u -p -r1.14 smtpc.c --- smtpc.c 5 Mar 2021 12:37:32 - 1.14

smtpd: tls ciphers and protocols on listeners

2021-04-06 Thread Eric Faurot
Hi, This diff allows to specify tls ciphers and protocols on listen rules, as it's been done already for relay actions. While there, sanitize error checking on protocols config in the mta. Eric. Index: config.c === RCS file: /cvs

smtpd: default mta ciphers

2021-04-01 Thread Eric Faurot
If not cipher list is specified for a relay rule, fallback to the global cipher list if defined, rather than libtls default. This is closer to the previous behavior. Eric. Index: mta.c === RCS file: /cvs/src/usr.sbin/smtpd/mta.c,v

Re: smtpd: trace and vfprintf %s NULL

2021-03-31 Thread Eric Faurot
Any objection or ok? On Sat, Mar 27, 2021 at 12:52:11PM +0100, Eric Faurot wrote: > Hello. > > I get reports from people seeing "vfprintf %s NULL" in their logs > recently. The problem is in a function that should be fixed, > but that function is only expected to

smtpd: trace and vfprintf %s NULL

2021-03-27 Thread Eric Faurot
uated when tracing is not set. Eric. Index: smtpd.h === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.h,v retrieving revision 1.662 diff -u -p -r1.662 smtpd.h --- smtpd.h 5 Mar 2021 12:37:32 - 1.662 +++ smtpd.h 23 Mar 202

smtpd: set protocols and ciphers

2021-03-25 Thread Eric Faurot
Hi. This diff allows to specify the protocol versions and ciphers to use for outgoing TLS sessions on a per relay basis. Eric. Index: mta.c === RCS file: /cvs/src/usr.sbin/smtpd/mta.c,v retrieving revision 1.235 diff -u -p -r1.235

smtpd: use mx name for sni

2021-03-07 Thread Eric Faurot
As spotted by krw@, the mta should use the mx hostname for sni, not the reverse dns for the peer address. Eric. Index: mta_session.c === RCS file: /cvs/src/usr.sbin/smtpd/mta_session.c,v retrieving revision 1.139 diff -u -p -r1.139

Re: smtpd: use libtls

2021-02-13 Thread Eric Faurot
Hi. The diff seems to work for the few people who tested it (thanks). Anyone wants to ok this? Eric. Index: ca.c === RCS file: /cvs/src/usr.sbin/smtpd/ca.c,v retrieving revision 1.37 diff -u -p -r1.37 ca.c --- ca.c31 Dec

Re: smtpd: use libtls

2021-02-05 Thread Eric Faurot
No much report so far. Anybody had a chance to test this? Here is the same diff again with manpage update this time. Eric. Index: ca.c === RCS file: /cvs/src/usr.sbin/smtpd/ca.c,v retrieving revision 1.37 diff -u -p -r1.37 ca.c

smtpd: use libtls

2021-01-27 Thread Eric Faurot
istener must have at least one certificate explicitly set. The extra ones are used for SNI, and only the specified certificates will be used for this listener. So there is no more fallback or global lookup on configured pki names. Tests and comments would be greatly ap

Re: smtp(1) add authentication

2020-12-21 Thread Eric Faurot
ing in place and just need to hook it up. > > OK? ok eric@ > martijn@ > > Index: smtpc.c > === > RCS file: /cvs/src/usr.sbin/smtpd/smtpc.c,v > retrieving revision 1.11 > diff -u -p -r1.11 smtpc.c >

smtpd: simplify codepath

2020-10-14 Thread Eric Faurot
straight-forward and should not change the current behaviour. Please test and report if you are using server-side tls. Eric. Index: smtp_session.c === RCS file: /cvs/src/usr.sbin/smtpd/smtp_session.c,v retrieving revision 1.426 diff

smtpd: fix catch-all in virtual aliases

2020-04-26 Thread Eric Faurot
then "user" expands to "catchall" because it is interpreted as "user@" (empty domain). The catch-all fallback mechanism is really meant for full email addresses in virtual context, and should not happen for usernames. The

smtpd: simplify aliases_get()

2020-04-25 Thread Eric Faurot
Hi, The current code for aliases_get() is a bit contorted I think. This diff makes it clearer. Eric. Index: aliases.c === RCS file: /cvs/src/usr.sbin/smtpd/aliases.c,v retrieving revision 1.77 diff -u -p -r1.77 aliases.c

Re: resolv.conf(5) says options inet6 does nothing

2020-04-23 Thread Eric Faurot
is way, it is also explaining our behaviour in case > of inet6 vs inet4 conditions. > > So... I think it should stay. Eric, do you have an opinion? The doc lies because the inet6 option does not set the RES_USE_INET6 flag as stated. I think we should leave the entry in the doc but

Re: smtpd: trailing CR

2020-04-23 Thread Eric Faurot
On Tue, Apr 21, 2020 at 07:08:48AM +, gil...@poolp.org wrote: > April 21, 2020 4:28 AM, "Todd C. Miller" wrote: > > > On Mon, 20 Apr 2020 15:01:31 +0200, Eric Faurot wrote: > > > >> There has been a discussion a while ago about the issue of trailing CR

smtpd: fix smtpctl discover

2020-04-20 Thread Eric Faurot
the other envelope validation checks that happen at envelope load time. Eric. Index: queue.c === RCS file: /cvs/src/usr.sbin/smtpd/queue.c,v retrieving revision 1.189 diff -u -p -r1.189 queue.c --- queue.c 30 Dec 2018 23:0

smtpd: trailing CR

2020-04-20 Thread Eric Faurot
at the protocol level if needed. So this diffs moves the CR stripping from io level to protocol level for SMTP dialogs. Other uses of io_getline() are internal and expect simple LF line ending. The current behavior should not change. Comments? Eric. Index: bounce.c

smtpd: fix report event format

2020-04-08 Thread Eric Faurot
eld. Note that this is a protocol change, so external filters will have to be updated. Eric. Index: lka_filter.c === RCS file: /cvs/src/usr.sbin/smtpd/lka_filter.c,v retrieving revision 1.60 diff -u -p -r1.60 lka_filter.c --- lka_filter.c

smtpd: use CRLF in local enqueuer

2020-03-15 Thread Eric Faurot
This diff makes the local enqueuer use CRLF line ending during the SMTP dialog, as required by the protocol. Eric. Index: enqueue.c === RCS file: /cvs/src/usr.sbin/smtpd/enqueue.c,v retrieving revision 1.117 diff -u -p -r1.117

Re: smtpd: add support for cidr in hostname resolution for spf walk

2019-11-23 Thread Eric Faurot
all the lookup function. Another point, I don't understand how the parse_sender() function is supposed to work. Can you give examples with cidr4 and cidr6? Eric. > > Index: usr.sbin/smtpd/spfwalk.c > === > RCS file: /

Re: smtpd handling of \r in DATA part

2019-10-03 Thread Eric Faurot
e is a diff for that. Note that it strips the '\r' on all input, not just DATA. Eric. Index: smtp_session.c === RCS file: /cvs/src/usr.sbin/smtpd/smtp_session.c,v retrieving revision 1.414 diff -u -p -r1.414 smtp_session.c --- smtp_session.

Re: smtpd handling of \r in DATA part

2019-09-19 Thread Eric Faurot
ays the client must not transmit them. So maybe we should just discard them at receive time... To me, the only real problem with '\r' is at the end of lines. It's confusing since you never really know whether it's part of the content or the protocol. So I suggest that we strip all '\r' found at the end of a line, and retain the others. Eric.

Re: smtp(1) certificate validation

2019-09-10 Thread Eric Faurot
On Tue, Sep 10, 2019 at 06:12:12PM +0100, Stuart Henderson wrote: > > + if (!SSL_CTX_load_verify_locations(ssl_ctx, "/etc/ssl/cert.pem", NULL)) > > shouldn't that use X509_get_default_cert_file()? Yes, that looks better. Updated locally. Eric.

Re: smtp(1) certificate validation

2019-09-10 Thread Eric Faurot
On Fri, Sep 06, 2019 at 08:41:21AM +0200, Eric Faurot wrote: > Hi, > > This patch adds the missing bits for verifying the server certificate > in smtp(1). Take two: now check the name(s) of the server certificate. I borrowed code from libtls for now. This will be cleaned up whe

smtp(1) certificate validation

2019-09-06 Thread Eric Faurot
Hi, This patch adds the missing bits for verifying the server certificate in smtp(1). Eric. Index: smtpc.c === RCS file: /cvs/src/usr.sbin/smtpd/smtpc.c,v retrieving revision 1.8 diff -u -p -r1.8 smtpc.c --- smtpc.c 2 Sep 2019

Re: pf congestion on low traffic

2019-08-27 Thread Eric Camirand
Hi Richard, I'm still getting congestion using acpihpet0. Not sure about the arp, i don't think there is that much. Older hardware using bsd.mp on the same lan doesn't have this issue. Thanks! On Aug 22, 2019, at 5:57 AM, Richard Procter wrote: Hi Eric, I was unfamiliar with how

pf congestion on low traffic

2019-08-15 Thread Eric Camirand
. Only default daemons and nsd are running. Can somebody help me figure this out ? Thanks ! Eric Camirand === sysctl kern.netlivelocks kern.netlivelocks=2 === Status: Enabled for 0 days 19:25:59 Debug: info Hostid: 0xdc985578 Checksum: 0x5b36311462da2ab76b362f191125df49

Re: gethostbyname return TRY_AGAIN on network outage

2019-06-26 Thread Eric Faurot
ot set on the lookup directive, which feels consistent. I have to review the resolver logic to see if a fix is needed at deeper level. But still, this diff makes sense on its own, so ok eric@. Eric. On Wed, Jun 26, 2019 at 11:57:10AM +0200, Martijn van Duren wrote: > Found this yesterday whi

smtpd: update table api

2018-12-18 Thread Eric Faurot
). Eric. Index: smtpd.h === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.h,v retrieving revision 1.594 diff -u -p -r1.594 smtpd.h --- smtpd.h 13 Dec 2018 17:08:10 - 1.594 +++ smtpd.h 17 Dec 2018 16:33:09 - @@ -375,8 +375,8

Re: Add acpipci(4) on amd64

2018-10-23 Thread Eric Augé
laptop output) tried usb-c yubikey and usb-c harddrive, nothing happens, no new devices, no power to the device HTH, Eric. On Tue, Oct 23, 2018 at 1:11 PM Peter Hessler wrote: > > On 2018 Oct 22 (Mon) at 21:45:06 +0200 (+0200), Mark Kettenis wrote: > :Diff below adds an acpipci(4) driver

smtpd: force TLS when relaying

2018-09-21 Thread Eric Faurot
constistent altogether, and in practice it should not be a problem because most smarthost configurations uses strict TLS. Now, for the secondary MX example, the rule would look like: action "do-backup" relay backup tls Comments? Eric. Index: mta.c ==

smtpd: flags cleanup in mta

2018-09-05 Thread Eric Faurot
With the recent changes in the smarthost syntax, and the removal of the "secure" keyword, it's now possible to clarify the mta code by changing the TLS option from a set flags to exclusive values. This is far less confusing. More cleanup to come in mta_session.c after that. Eric. In

Re: smtpd: improve syntax for relay host

2018-09-02 Thread Eric Faurot
Hi. Same diff with associated manpage update. If there is no objection, I'd like to commit this quickly. Eric. Index: smtpd.conf.5 === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v retrieving revision 1.199 diff -u -p -r1.199

smtpd: improve syntax for relay host

2018-08-29 Thread Eric Faurot
mails would be sent over a secure channel instead of plain text. - an "smtp+tls://" relay would not fallback to plain text if STARTTLS fails, and the mail will tempfail. - in all other cases, the mail will tempfail with a warning. Does that look fine? Eric. Index: to.c

smtpd: improve message parser

2018-07-26 Thread Eric Faurot
the following intended improvements: - Use a more straightforward interface rather than the callback approach. - Avoid unnecessary string copy. - Stop using fixed-size string buffers, especially on the stack. This is a step towards better handling of message line length in the daemon. Please test an

smtpd: improve internal resolver interface

2018-07-20 Thread Eric Faurot
we want to replace this with a simpler set of IMSGs matching the standard resolver interface. The rest of the code will be adapted little by little. Eric. Index: dns.c === RCS file: /cvs/src/usr.sbin/smtpd/dns.c,v retrieving

Re: smtpd: make relay to smarthost to verify TLS by default

2018-05-31 Thread Eric Faurot
your proposal. It makes the documentatino more accurate: the server certificate is always verified, the flag is only meant to accept invalid certificates. It also fixes build (apparently the mta.c chunk was incorrect). Eric. Index: mta.c ==

smtpd: simplify header rewrite code-path

2017-11-10 Thread Eric Faurot
what conditions leads to rewriting the sender. As a bonus, it also fixes a bug (actually not triggerable) in the removed code ("!= 1" should be "== -1"). Please test, especially if you are using the "masquerade" option.

Re: smtpd: remove filter leftovers

2017-08-29 Thread Eric Faurot
On Tue, Aug 29, 2017 at 10:26:19AM +0200, Eric Faurot wrote: > Now that the filter code path has been short-circuited, start removing stub > smtp_filter_*() indirections. I'm doing this one function at a time to keep > the diffs simple, starting with smtp_filter_connect(). Actually the

smtpd: remove filter leftovers

2017-08-29 Thread Eric Faurot
Now that the filter code path has been short-circuited, start removing stub smtp_filter_*() indirections. I'm doing this one function at a time to keep the diffs simple, starting with smtp_filter_connect(). Eric. Index: smtp_session.c

smtpd: tweak static table parser

2017-08-28 Thread Eric Faurot
parsed according to the table type. The "list" type can also be forced by using the "@list" directive in a comment. This allows to define list of entries containing a separator. Existing table files should still be working as expected. As a bonus, parse errors are now logge

smtpd: simplify table parser

2017-08-13 Thread Eric Faurot
Remove the table_static_parse() indirection for parsing the file content. The "type" parameter is useless since the "(t->t_type & type)" test is always true. I think this is a left-over from the old design when table parsing was done in context of its intended use

[patch] remove smtpd filter code

2017-08-04 Thread Eric Faurot
that filter.c can be unhooked. This is what the following diff does: - drop filter configuration, - drop filter events, - simulate a positive reply for all filter queries, - write message content directly to the file. There should be no functionnal change. Eric. Index: pony.c

Re: SSHFP with EDNS0/DNSSEC

2017-07-12 Thread Eric Faurot
;as_ctx->ac_options & RES_USE_DNSSEC); > + as->as_ctx->ac_options & (RES_USE_EDNS0 | RES_USE_DNSSEC)); > if (p.err) { > DPRINT("error packing query"); > errno = EINVAL; The current code is correct, RES_USE_EDNS0 does not imply RES_USE_DNSSEC. The real problem is that there is no resolv.conf option for RES_USE_DNSSEC. It can only be set in user code by tweaking _res.options. Eric.

Re: smtpd session hang

2017-06-16 Thread Eric Faurot
he session if the data_io path > > hits the low water mark. > > > > Mr. Wolk tested this diff against smtpd on 6.1 as well as a against > > -current version of smtpd (compiled on the same system running 6.1). > > > > Nice catch, the diff reads fine to me, I'll commit

Re: asr: support for RES_USE_DNSSEC

2017-02-26 Thread Eric Faurot
d set this meaning it has > authenticated the data. I wrote a patch for DNSSEC (possibly erroneous > by comparing it to you) and posted it to #opensmtpd in hopes that eric > would see it. Much of that functionality is superfluous now but it does > have an "AD_MASK" check. > > Here

Re: asr: support for RES_USE_DNSSEC

2017-02-26 Thread Eric Faurot
stfix or exim. > > Since RES_USE_DNSSEC now actually adds an EDNS0 OPT record to the > outgoing packet, one can be concerned with problems with resolvers out > there. Windows seems to have a way to disable EDNS0, I am not aware of > existing mechanisms elsewhere. > >

Re: asr: support for RES_USE_DNSSEC

2017-02-26 Thread Eric Faurot
gt; Comments welcome. > Well, I like the as_flags cleanup part of the diff. Internal flags should indeed be on the asr_query structure directly, so they are not confused with query-specific parameters. For the flags inheritance, I'm not so sure. I would rather keep the current internal API for no

asr: slightly better error reporting for getnameinfo()

2017-02-20 Thread Eric Faurot
Report the errno set by getifaddrs(3) if the setup for AI_ADDRCONFIG fails, rather than a non-informative EAI_FAIL. Compare to -1 for error detection while here. Eric. Index: asr/getaddrinfo_async.c === RCS file: /cvs/src/lib/libc

Re: asr EDNS0 support

2017-02-18 Thread Eric Faurot
s feature. I'm not > suggesting that we use it by default right now, but this could be > a desirable change. > > ok? Yes, I like it a lot. One small comment tough: better use T_OPT rather than 41 in _asr_pack_edns0(). Besides that, ok eric@ > > In

smtpd: hide struct io

2016-11-28 Thread Eric Faurot
of iobuf_* The diff is mostly mechanical. Eric. Index: bounce.c === RCS file: /cvs/src/usr.sbin/smtpd/bounce.c,v retrieving revision 1.76 diff -u -p -r1.76 bounce.c --- bounce.c22 Nov 2016 07:28:42 - 1.76 +++ bounce.c28

smtpd: more internal cleanups

2016-11-22 Thread Eric Faurot
changes, it's now possible to make it a lot simpler by triggering an event reload internally when data is queued. So the api user does not have to worry about it. Eric. Index: ioev.c === RCS file: /cvs/src/usr.sbin/smtpd/ioev.c,v

smtpd: simplify internal io api

2016-11-21 Thread Eric Faurot
The api user should not have to care about normalizing the io input buffer (i.e. resetting the read/write pos in the buffer). Do it internally when reloading the io event. Eric. Index: bounce.c === RCS file: /cvs/src/usr.sbin/smtpd

smtpd: internal cleanups, part 3

2016-11-17 Thread Eric Faurot
of the daemon. Eric. Index: ioev.c === RCS file: /cvs/src/usr.sbin/smtpd/ioev.c,v retrieving revision 1.28 diff -u -p -r1.28 ioev.c --- ioev.c 17 Nov 2016 07:33:06 - 1.28 +++ ioev.c 17 Nov 2016 14:01:28 -

smtpd: internal cleanups, part 2

2016-11-16 Thread Eric Faurot
This diff removes the IO_TLSVERIFIED which is not a io event, and inlines the necessary code where the callback functions are called for this event. Eric. Index: ioev.c === RCS file: /cvs/src/usr.sbin/smtpd/ioev.c,v retrieving

smtpd: internal cleanups

2016-11-16 Thread Eric Faurot
structure. There are places where the callback function is triggered outside of the io layer. It's not desirable, and it needs to be fixed in a separate diff. Eric. Index: bounce.c === RCS file: /cvs/src/usr.sbin/smtpd/bounce.c,v

smtpd config parsing cleanup

2016-09-09 Thread Eric Faurot
the listener(s) to the current config list of listeners. - make the fallback chain between interface(), host_v4() host_v6() and host_dns() obvious when creating an if_listener. - fix a bug where the specified family was ignored if the listener is given as a hostname. Comments? Eric. Index

smtpd shutdown cleanup

2016-09-06 Thread Eric Faurot
o stop now. When doing so, they log as "debug" instead of "info" because useless logs are useless. This makes the shutdown sequence much saner. Eric. Index: ca.c === RCS file: /cvs/src/usr.sbin/smtpd/ca.c,v retri

Another step in cleaning the smtpd exit path.

2016-09-04 Thread Eric Faurot
The smtpd processes are not expected to ever leave their event loop. So stop pretending that the *_shutdown() functions could ever be called in this context, and just fatal() if event_dispatch() returns. Eric. Index: ca.c === RCS

Re: smtpctl stop

2016-09-03 Thread Eric Faurot
On Sat, Sep 03, 2016 at 08:12:20PM +0200, Gilles Chehade wrote: > On Sat, Sep 03, 2016 at 08:09:25PM +0200, Eric Faurot wrote: > > Hi, > > > > Here is a diff to remove the "smtpctl stop" command. > > The proper way to stop a daemon is kill(1)/pkill(1) only. &g

smtpctl stop

2016-09-03 Thread Eric Faurot
Hi, Here is a diff to remove the "smtpctl stop" command. The proper way to stop a daemon is kill(1)/pkill(1) only. It makes no sense to have different code path for that. Eric. Index: control.c === RCS file: /cvs/src/usr.

Re: smtpd 5.9.1 vs 6.0 & possible corner case / regression

2016-08-20 Thread Eric Faurot
Can you guys try this diff? Eric. Index: rfc2822.c === RCS file: /cvs/src/usr.sbin/smtpd/rfc2822.c,v retrieving revision 1.7 diff -u -p -r1.7 rfc2822.c --- rfc2822.c 4 Feb 2016 22:35:17 - 1.7 +++ rfc2822.c 20 Aug 2016

bgpd dying repeatedly on latest snapshot

2015-10-06 Thread Eric Ripa
-spamd.net Below is the output from "bgpd -d". Could this be related to recent tame changes? BR, Eric Ripa startup rereading config route decision engine ready session engine ready listening on 0.0.0.0 listening on :: SE reconfigured neighbor 217.31.80.170: state change None -> Idle,

Typo in INSTALL.armv7

2015-09-08 Thread Eric Lalonde
--- INSTALL.armv7.orig 2015-09-08 09:48:21.0 -0700 +++ INSTALL.armv7 2015-09-08 09:48:35.0 -0700 @@ -91,7 +91,7 @@ out as follows: A miniroot filesystem to be used for installation; Cubieboard1 version. -

Re: rwho on OpenBSD 5.6

2014-11-09 Thread Eric JACQUOT
that files like /etc/rc.d/rwhod or /usr/bin/rwho should be removed. How much of a catastrophy is this? Question for the community: Do you want the upgrade instructions to be 100% useful, or 100% complete? Hi, IMHO, first useful then complete . -- Eric JACQUOT

Re: rwho on OpenBSD 5.6

2014-11-09 Thread Eric JACQUOT
Neither; 100% is unrealistic. Getting '90%' on either measure exceeds my expectations. The same percentage of flights would be acceptable? I think that problem has been highlighted and we now belongs to all users to check and submit oversights. My 2 cents, Regards, -- Eric JACQUOT

Re: Bug in gethostbyaddr and patch to solve

2014-08-28 Thread Eric Faurot
=1.29f=h Eric.

Re: problem with gethostbyaddr() on OBSD 5.4?

2014-02-03 Thread Eric Faurot
On Sun, Feb 02, 2014 at 03:12:36PM +0100, IMAP List Administration wrote: [I forgot to send this to the list] Hi Eric, On 02/01/2014 11:43 AM, Eric Faurot wrote: The following diff fixes the problems with the example IPs you gave us. - subsequent PTR records are now set as aliases

Re: problem with gethostbyaddr() on OBSD 5.4?

2014-02-01 Thread Eric Faurot
with the example IPs you gave us. - subsequent PTR records are now set as aliases in the hostent - need to accept '/' in dname labels (maybe others?) Please check if it works for you. Eric. Index: asr_utils.c === RCS file: /cvs/src

make async resolver API public

2013-12-26 Thread Eric Faurot
/include before building. Comments welcome. Eric. Index: include/Makefile === RCS file: /cvs/src/include/Makefile,v retrieving revision 1.181 diff -u -p -r1.181 Makefile --- include/Makefile8 Dec 2013 17:05:09 - 1.181

Re: [UPDATE] www/papers/index.html - Eric's OpenSMTPd presentation

2013-04-02 Thread Eric Faurot
--- index.html 23 Mar 2013 17:56:07 - 1.166 +++ index.html 2 Apr 2013 13:01:44 - @@ -18,6 +18,13 @@ h3Presentations: AsiaBSDCon 2013/h3 blockquote font color=#009000strong +a href=https://poolp.org/~eric/asiabsdcon2013-smtpd/;OpenSMTPD: We deliver!/a, +Eric Faurot +/strong

smtpd alias expansion updated, please test

2012-09-27 Thread Eric Faurot
that the change doesn't introduce a regression. So please test and report problems you notice to gil...@openbsd.org and e...@openbsd.org. Thank you. Eric.

Re: ntpd(8) option to provide time even when not being synced

2012-09-07 Thread Eric P. Mangold
Could I ask what your use-case is? -E On Fri, Aug 24, 2012 at 01:41:21PM +0200, Patrick Wildt wrote: the diff below adds an option to the ntpd(8), which has him provide time, even though he's not synced. ok? Index: ntpd.8

Re: http anchor fix [Was: Re: (2) HTTP basic authentication for ftp(1) (RFC 2617)]

2012-08-12 Thread Eric P. Mangold
On Sat, Aug 11, 2012 at 09:47:23PM +0200, Christiano F. Haesbaert wrote: On Tue, Aug 07, 2012 at 11:50:26AM -0400, Eric P. Mangold wrote: [...] I would prefer this to be done on the path processing block, if possible. Just make sure you test the scheme for http/https, sorry for slacking

PATCH: /usr/bin/ftp: Remove fragment/anchor identifier before making request

2011-10-28 Thread Eric P. Mangold
be URL-encoded if it is to appear literally in a URL and not be interpreted as the start of a fragment identifier. Regards, Eric P. Mangold Index: fetch.c === RCS file: /cvs/src/usr.bin/ftp/fetch.c,v retrieving revision 1.103 diff -u

fix/add defines for ehci registers

2011-10-25 Thread Eric Faurot
They are only necessary for split isochronous transactions, which are not currently supported. So nothing uses those at the moment, but it doesn't hurt to have them right. Eric. Index: ehcireg.h === RCS file: /cvs/src/sys/dev/usb

  1   2   >