Re: improve rsync(1) manual page

Hi Christian, Christian Weisgerber wrote on Mon, Apr 01, 2019 at 09:13:27AM +0200: > Ingo Schwarze: >> here are serveral bugfixes and improvements for the rsync(1) manual. > ok Thanks for checking, committed with the following tweaks: > I have some comments, but I think yo

Re: Removing PF

Hi Claudio, Claudio Jeker wrote on Mon, Apr 01, 2019 at 07:01:03AM +0200: > There have been internal discussions about OpenBSD also removing the pf > packet filter after the upcoming 6.5 release. Instead a switch to > using David Gwynne's new bpf filter will happen. > The benefits outweigh the

improve rsync(1) manual page

Hi, here are serveral bugfixes and improvements for the rsync(1) manual. OK? Ingo Bugfixes: * For -D and -l: s/Transfer/Also transfer/. * In the EXAMPLES, the renaming rsync -> openrsync caused a mess; the worst aspect is the --rsync-path in the last example. I don't have a good

Re: rsync: add --del, remove --no-delete

Hi, Ingo Schwarze wrote on Sat, Mar 30, 2019 at 02:14:43PM +0100: > Christian Weisgerber wrote on Sat, Mar 30, 2019 at 10:34:59AM -: >> I think that if openrsync ever grows anywhere near the number of options >> that the GPL rsync has, listing them all in usage/synopsis will b

Re: rsync: add --del, remove --no-delete

Hi, Christian Weisgerber wrote on Sat, Mar 30, 2019 at 10:34:59AM -: > On 2019-03-30, Jason McIntyre wrote: >> we could use: [--del[ete]] >> that looks ugly, but is short and clear. kind of vi(1) style. >> >> we could just note in the description of --delete that it can be >> abbreviated

Re: Unescaped backslashes in manual pages

Hi Peter, Peter Piwowarski wrote on Tue, Mar 19, 2019 at 10:03:20PM -0400: > qsort(3) has in its EXAMPLE a C \n with its backslash unescaped; a quick > grep through manpages showed similar errors in CONF_modules_load_file.3. Ouch! Thanks for the report, committed. Ingo > Index:

Re: EC_POINT_new.3 glitch

Hi Jan, Jan Stary wrote on Mon, Mar 18, 2019 at 08:38:04AM +0100: > This seems to be a missed newline. Committed, thanks. Ingo > Index: EC_POINT_new.3 > === > RCS file: /cvs/src/lib/libcrypto/man/EC_POINT_new.3,v > retrieving

Re: less(1) UTF-8 bugfix and cleanup: search.c

Hi Stefan, Stefan Sperling wrote on Thu, Mar 14, 2019 at 04:11:00PM +0100: > Yes, OK. Thanks for checking. Here is the next step outside line.c, completely cleaning up the file less/filename.c with respect to UTF-8 handling. The loop needed is very similar to the one in search.c except that

less(1) UTF-8 bugfix and cleanup: search.c

Hi, the following is a very simple patch to completely clean up the file less/search.c with respect to UTF-8 handling. It also fixes an outright bug: Searching for uppercase UTF-8 characters currently doesn't work because passing a Unicode codepoint (in this case, the "ch" retrieved with

Re: 63 bit certificate ID is libressl affected?

Hi Tom, Tom Smyth wrote on Wed, Mar 13, 2019 at 08:32:20PM +: > Just saw the following article and i was wondering if libressl > Might be affected by the bug also > Top bit being set to 0 always making an effective 63 bits rather than 64 > bits If i understand the article you quote

less(1) UTF-8 cleanup: pappend()

Hi Todd, Todd C. Miller wrote on Tue, Mar 12, 2019 at 09:14:43AM -0600: > This looks like an improvement to me. OK millert@ Thanks for checking the do_append() patch, i committed it. The next step is to clean up pappend(), which reads one byte of a multibyte character per call and outputs the

less(1) UTF-8 cleanup: do_append()

Hi Nicholas, Nicholas Marriott wrote on Tue, Mar 12, 2019 at 11:05:07AM +: > Sorry, ok nicm if you haven't committed this already. No i hadn't, but now i have, thank you very much for checking the patch. Here is the next step, cleaning up most parts of the crucial function do_append()

Re: Adding fstab(5) fs_mntops to mount_nfs(8)

Hi Kurt, Kurt Mosiejczuk wrote on Mon, Mar 11, 2019 at 09:32:41AM -0400: > As far as I can tell, no man page documents the fs_mntops form of the > mount_nfs(8) options for fstab(5). Most of us who use them either know > from some other documentation, reading the source, or just doing a >

Re: mount(8): remove unnecessary white space in man page

Hi Alessandro, Alessandro Gallo wrote on Sun, Mar 10, 2019 at 02:12:21PM +0100: > There seems to be an unneeded extra space in the mount(8) man page. > The following diff fixes that: Committed, thanks. Ingo > Index: mount.8 >

delete useless setlocale(3) from touch(1)

Hi, i initially thought touch(1) might be tricky because it is concerned with times, but it turned out is does almost all of the parsing by hand, supporting only specific numeric formats and nothing like month names. It does use strptime(3), but only for %F and %T neither of which is

delete useless setlocale(3) in uuencode(1)

Hi, uuencode(1) and uudecode(1) do nothing locale-related and i don't see how they ever might. So delete and setlocale(3). While here, sort headers, make usage() static, return from main rather than exit(3), and drop two redundant case statements. This is also a minimally tweaked version of a

delete useless setlocale(3) in spell(1)

Hi, looking through my trees for diffs that were forgotten, i found this one. Spell uses nothing locale-dependent, and it will never need support for non-English characters because the basic algorithms used are specific to the English language in the first place. So delete and setlocale(3)

Re: xterm and wcwidth()

Hi, Ted Unangst wrote on Fri, Mar 08, 2019 at 03:24:56PM -0500: > Matthieu Herrb wrote: >> I would prefer a diff that just add a &&!defined(__OpenBSD__) to the >> condition before the definition of systemWcwidthOk(). This will cause >> less risk of conflicts in future updates and clearly show

Re: xterm and wcwidth()

Hi, Ted Unangst wrote on Fri, Mar 08, 2019 at 12:57:17PM -0500: > Lauri Tirkkonen wrote: >> in other words, xterm is (and was) using its own idea of how many >> columns characters take up. The way this manifested itself to me was >> that I received some email that contained emoji characters in

Re: xterm and wcwidth()

Hi, Lauri Tirkkonen wrote on Fri, Mar 08, 2019 at 12:43:11PM +0200: > I feel like xterm should just use the system wcwidth() to avoid these > mismatches, so rudimentary diff to do that below. Absolutely, i strongly agree with that sentiment. Having a local character width table in an

Re: xman.man: typo in mandesc section

Hi Alejandro, we normally avoid trivial changes to X11 documentation. Such changes provide little benefit but make life harder for matthieu@. If the typo still exists upstream, please report it upstream, and it will automatically appear in OpenBSD with the next regular update. Yours, Ingo

Re: mandoc -Tlint systat.1 fix

Hi David, David Gwynne wrote on Mon, Mar 04, 2019 at 08:59:12PM +1000: > lint thinks uvm_swap_get() looks like a function name, > so this uses .Fn to mark it up as one. > > ok? Sure. Given that the function uvm_swap_get() appears to be important enough to be mentioned even in a userland

Re: nm(1): return on malloc error

Hi, Benjamin Baier wrote on Sat, Mar 02, 2019 at 10:10:40AM +0100: > On malloc error symtab is unmapped, so proceeding on will lead > to a NULL pointer dereference. > When malloc fails we should return like the MMAP case does. Committed. Thanks for the patch (and to those who checked it).

Re: nm(1): return on malloc error

Hi, Benjamin Baier wrote on Sat, Mar 02, 2019 at 10:10:40AM +0100: > On malloc error symtab is unmapped, so proceeding on will lead > to a NULL pointer dereference. > When malloc fails we should return like the MMAP case does. while i'm certainly not experienced with nm(1), this change looks

less(1) UTF-8 cleanup: backc()

Hi, the first step in cleaning up do_append() is the subroutine backc(), which is only called from a single place, namely in do_append(). Its purpose is to back up over the previous positive-width character during the application of backspace-encoding for "bold" or "underlined". The task here is

less(1) UTF-8 cleanup: store_char()

Hi, Nicholas Marriott wrote on Tue, Feb 26, 2019 at 07:20:47AM +: > Looks good, ok nicm Thanks to all of you for checking. Here is the next step, slowly coming closer to the meat of the matter: Start cleaning up the function store_char(), which takes a wide character, receiving both the

Re: start cleaning up UTF-8 processing in less(1)

Hi Todd, Todd C. Miller wrote on Mon, Feb 25, 2019 at 01:06:02PM -0700: > On Mon, 25 Feb 2019 19:43:36 +0100, Ingo Schwarze wrote: >> Todd C. Miller wrote on Mon, Feb 25, 2019 at 09:45:12AM -0700: >>> On Mon, 25 Feb 2019 12:39:41 +0100, Ingo Schwarze wrote:

Re: start cleaning up UTF-8 processing in less(1)

Hi Todd, Todd C. Miller wrote on Mon, Feb 25, 2019 at 09:45:12AM -0700: > One question inline. > On Mon, 25 Feb 2019 12:39:41 +0100, Ingo Schwarze wrote: >> Index: line.c [...] >> @@ -469,11 +469,10 @@ in_ansi_esc_seq(void) >> * Search backwards for eithe

Re: start cleaning up UTF-8 processing in less(1)

Hi, Nicholas Marriott wrote on Mon, Feb 25, 2019 at 10:14:03AM +: > Ingo Schwarze wrote: >> During the upcoming cleanup steps, let use retain full support for >> the first (ESC-[) syntax and lets us completely delete support for >> the second and third CSI syntaxes (sing

Re: start cleaning up UTF-8 processing in less(1)

Hi, Stefan Sperling wrote on Sat, Feb 23, 2019 at 04:19:02PM +0100: > Your diff looks good to me. > And I can't see how it could make this situation any worse either. thanks for checking; i committed the first patch. To be able to continue with the less cleanup i started, i have to explain

Re: archaic quotes in calendar

Hi, Anthony J. Bentley wrote on Wed, Jan 30, 2019 at 04:01:30AM -0700: > Jason McIntyre writes: >> in the man page you have used Sq. that will make it mark up the same as >> it already does: >> >> (`*') > There's a difference: Ted uses a UTF-8 locale where Sq shows up as > pretty Unicode

start cleaning up UTF-8 processing in less(1)

Hi, Evan Silberman, by posting a well-founded bug report to bugs@, just drew my attention to the pigsty of having a hand-rolled re-implemention of Unicode character property handling within less(1). The root of the evil is the existence of the custom definition typedef unsigned long LWCHAR;

Re: update ctype data to unicode 10

Hi Andrew, Lauri Tirkkonen wrote on Fri, Feb 22, 2019 at 01:57:01AM +0200: > Hi, the recent perl-5.28.1 and related unicore update brought the > unicode data from version 8.0.0 to version 10.0.0. That fixes some > character classifications (eg. emoji characters gained East_Asian_Width > value

Re: update ctype data to unicode 10

Hi Andrew, Andrew Fresh wrote on Thu, Feb 21, 2019 at 08:22:16PM -0700: > On Fri, Feb 22, 2019 at 01:57:01AM +0200, Lauri Tirkkonen wrote: >> Hi, the recent perl-5.28.1 and related unicore update brought the >> unicode data from version 8.0.0 to version 10.0.0. That fixes some >> character

Re: install(1) could fail due to race

Ted Unangst wrote on Sun, Jan 27, 2019 at 10:37:52AM -0500: > Ingo Schwarze wrote: >> If people here agree with the general direction of making -S the >> default and removing the fragile non-S mode (see the patch below), >> i'll run a full make build and make release and then

Re: install(1) could fail due to race

Hi Ted, Ted Unangst wrote on Sun, Jan 27, 2019 at 10:37:52AM -0500: > Ingo Schwarze wrote: >> If people here agree with the general direction of making -S the >> default and removing the fragile non-S mode (see the patch below), >> i'll run a full make build and make release

Re: games/fortune translation fix

Hi Scott, Scott Cheloha wrote on Tue, Feb 05, 2019 at 12:02:39AM -0600: > Oof, folks I think we've missed the forest for the trees here. > > By focussing on the minutiae of the Latin translation we've discarded > the English motto ("through to the stars") that imho > anchored the whole thing.

Re: games/fortune translation fix

Hi Pascal, Pascal Stumpf wrote on Sun, Feb 03, 2019 at 11:13:12AM +0100: > That is not correct because [...] Which illustrates yet again that getting good grades at school doesn't imply real understanding; i dared to try and research the matter anyway because i forgot that with pascal@, we have

Re: games/fortune translation fix

Hi Jason, oh well, these files are a mess, a random collection of funny and not so funny stuff... I dislike this one, too, for several reasons. 1. While "ad astra per aspera" sometimes occurs, the word order "per aspera ad astra" is much more commonly used. It sounds much better - not

Re: ASN1_get_object.3

Hi Kristaps, Kristaps Dzonsons BSD.LV wrote on Wed, Jan 30, 2019 at 12:17:16PM +0100: >> Attached is a manpage for ASN1_get_object(3), ASN1_put_object(3), and >> ASN1_put_eoc(3). > This is not complete without ASN1_object_size(), as otherwise one can't > scan over children, which is necessary

Re: what.1: remove BUGS section

Hi Fabio, Fabio Scotoni wrote on Sun, Jan 20, 2019 at 12:52:18PM +0100: > The what(1) man page has a BUGS section, > which mdoc(7) says is discouraged in OpenBSD. What? Using BUGS sections is perfectly fine. The mdoc(7) manual page does not intend to say that using BUGS sections is

Re: return value check in snprintf(3) example code

Hi Theo and Theo, Theo de Raadt wrote on Fri, Jan 18, 2019 at 08:06:32PM -0700: > Ted Unangst wrote: >> Theo Buehler wrote: >>> According to our documentation and all the standards I checked, >>> snprintf() returns a negative value on error, not necessarily -1. >>> This confused me quite a bit

Re: install(1) could fail due to race

Hi, Lauri Tirkkonen wrote on Mon, Jan 07, 2019 at 08:13:09PM +0200: > Hi, it seems install(1) has a race condition: in create_newfile, it > first unlinks the target file and then tries to open it with > O_CREAT|O_EXCL. > > Normally this would not be a problem, A race condition is almost always

Re: locale in locate(1)

Hi, Jan Stary wrote on Thu, Jan 10, 2019 at 09:35:48PM +0100: > Does locate(1) need to setlocale(3)? Committed as part of a much larger diff. Note that answering that question required substantial code review and code cleanup. When auditing, don't just mechanically look for suspicious

Re: off by one ksh

Hi Ted, Ted Unangst wrote on Sun, Jan 13, 2019 at 08:23:01PM -0500: > Ingo Schwarze wrote: >> Feel free to either commit the complete patch below or commit >> only your part and optionally OK one, two, or three of my additional >> changes. > These look ok with one com

Re: LC_NUMERIC in wprintf(3)

Hi Todd, Todd C. Miller wrote on Sun, Jan 13, 2019 at 08:06:22AM -0700: > On Sun, 13 Jan 2019 05:20:47 +0100, Ingo Schwarze wrote: >> So adding a subsection to the setlocale(3) manual, containing lists >> of functions that are likely to break when you call setlocale(3) >&g

Re: locale in locate(1)

Hi Ted, Ted Unangst wrote on Sun, Jan 13, 2019 at 03:22:41AM -0500: > Ingo Schwarze wrote: >> So, here is some cleanup: >> * garbage collect useless hand-rolled lookup tables >> * merge one-line helper functions into callers >> * garbage collect obfuscating macros

Re: off by one ksh

Hi Ted, Ted Unangst wrote on Sun, Jan 13, 2019 at 03:48:05AM -0500: > By inspection, it appears possible this access will underrun if the > first character is a %. OK schwarze@ That said, i see three more buglets here. 1. If the mailbox filename ends in a percent sign (not saying that is

Re: LC_NUMERIC in wprintf(3)

Hi Todd, Todd C. Miller wrote on Sat, Jan 12, 2019 at 08:04:31PM -0700: > On Sat, 12 Jan 2019 16:45:46 +0100, Ingo Schwarze wrote: >> I did not attempt to hunt down all offenders. >> Would you regard that as a whorthwhile endeavour? >> Note that would not only requ

Re: locale in locate(1)

Hi Scott, Scott Cheloha wrote on Thu, Jan 10, 2019 at 07:18:43PM -0600: > locate(1) uses tolower(3), the results of which can be affected by > locale settings. In general, yes. On OpenBSD, not really: $ man tolower | grep -A 1 always OpenBSD always uses the C locale for these

Re: zic(8) unneeded header

Hi, Jan Stary wrote on Fri, Jan 11, 2019 at 10:05:47PM +0100: > zic.c does not need to include Correct, committed. Ingo revision 1.23 date: 2019/01/12 15:33:17; author: schwarze; state: Exp; lines: +1 -2; delete which was left behind during gettext removal (rev. 1.5) in 2015; no object

Re: LC_NUMERIC in wprintf(3)

Hi Todd, Todd C. Miller wrote on Fri, Jan 11, 2019 at 12:31:02PM -0700: > Don't we have the same issue with printf(3) and scanf(3)? > For example, in src/lib/libc/stdio/vfprintf.c:1022 > > decimal_point = nl_langinfo(RADIXCHAR); > > Also, anything using strtod(3), including scanf(3), is

Re: LC_NUMERIC in wprintf(3)

Hi, Jan Stary wrote on Thu, Jan 10, 2019 at 03:15:38PM +0100: > same for wscanf(3): Fixed, but in a way similar to wprintf(3). Yours, Ingo $ man wscanf | col -b | grep -A 6 ^CAVEATS CAVEATS On systems other than OpenBSD, the LC_NUMERIC locale(1) category can cause parsing

Re: LC_NUMERIC in wprintf(3)

Hi Ted & Scott, Ted Unangst wrote on Fri, Jan 11, 2019 at 04:03:32AM -0500: > Ingo Schwarze wrote: >> That stuff is a very serious trap not only for the unwary, but also >> for experienced programmers. Less than a month ago, i discussed >> the matter with a senio

Re: locale in comm(1)

Hi, Jan Stary wrote on Thu, Jan 10, 2019 at 09:30:19PM +0100: > Does comm(1) need to setlocale(3)? schwarze@cvs $ grep -A 2 '\' ~/TODO-UTF8.txt comm - character case folding (non-standard '-f' flag) [requires wcscasecmp(3)] So yes, it does need setlocale(LC_CTYPE, ""), and no, this diff

Re: LC_TIME in calendar(1)

Hi, Jan Stary wrote on Thu, Jan 10, 2019 at 08:24:58PM +0100: > calendar imho doesn't need to setlocale(LC_TIME, ...) > before and after strftime(3), as LC_TIME is ignored. As it stands, this diff is not OK. The calendar(1) program is also calling setlocale(LC_ALL, "") from main, both in the

Re: LC_NUMERIC in wprintf(3)

Hi Jan, Jan Stary wrote on Thu, Jan 10, 2019 at 02:43:39PM +0100: > The wprintf(3) manpage says > > The decimal point character is defined > in the program's locale (category LC_NUMERIC) > > but LC_NUMERIC is ignored in OpenBSD's C library, > as explained in setlocale(3). Right, i

Re: q to quit grdc

Hi Ted, Ted Unangst wrote on Sat, Jan 05, 2019 at 10:23:58PM -0500: > There should be a nicer way to quit than ctrl-c. This lets you press q to > quit. (and also checks for esc, for users who don't read the manual.) Sure, why not. However, i suggest -will skip seconds. +skips seconds.

Re: adjust rdate example

Hi Theo, Theo de Raadt wrote on Sat, Jan 05, 2019 at 09:23:46PM -0700: > Oh good grief, don't do that. > > Unless you are going to add the same text to every man page in usr.sbin > on the following list. > > ac bgpd dhcpd httpd ldapd mrouted npppctl nsd ntpd radiusd rdate relayd > slaacctl

Re: adjust rdate example

Hi Ted, Theo de Raadt wrote on Sat, Jan 05, 2019 at 08:31:27PM -0700: > Ted Unangst wrote: >> The sample server doesn't work for me, The sample server does work for me: $ host ptbtime1.ptb.de ptbtime1.ptb.de has address 192.53.103.108 $ env TZ=UTC rdate -p ptbtime1.ptb.de Sun Jan 6

Re: mandoc -T html default style

Hi Ted, Ted Unangst wrote on Mon, Dec 24, 2018 at 01:31:50PM -0500: > Ingo Schwarze wrote: >> Todd Miller wrote: >>> That would be fine with me. I definitely think it should be installed >>> somewhere. I found it odd that I had to look for mandoc.css in the &g

Re: mandoc -T html default style

-0700: > On Fri, 21 Dec 2018 00:10:10 +0100, Ingo Schwarze wrote: >> I see the point, and it makes sense to me. >> >> So in case people want a sensible default for "-O style=" as suggested, >> where should the file go? >> >> Maybe /usr/share/mi

Re: mg: Delete region

Hi Hiltjo, Hiltjo Posthuma wrote on Sun, Dec 23, 2018 at 03:34:12PM +0100: > Shouldn't these kind of diffs be OK'd by other developers before > committing though? Not necessarily. When a developer focusses on work in a particular area and takes responsibility to fix anything that breaks there,

Re: mandoc -T html default style

Hi Ted, Ted Unangst wrote on Sat, Dec 22, 2018 at 12:13:35PM -0500: > Ingo Schwarze wrote: >> What about making -O style= *compulsory* unless "option style" is >> defined in man.conf(5)? Just error out when no style sheet is >> configured? That can be comb

Re: mandoc -T html -O toc, nested anchor tags

Hi Raphael, Raphael Graf wrote on Sat, Dec 22, 2018 at 03:32:45PM +0100: > The html output contains nested anchor tags if the TABLE OF CONTENTS > has a second level. > For example, see http://man.openbsd.org/mdoc > > The diff closes the anchor tag before printing the 'ul' of the second level.

Re: mandoc -T html default style

Hi Ted, Ted Unangst wrote on Fri, Dec 21, 2018 at 02:53:19PM -0500: > Ingo Schwarze wrote: >> 2. When calling "mandoc -T html" without specifying "-O style=", >> fall back to "-O style=/var/www/htdocs/mandoc.css" by default. >> That

Re: mandoc -T html default style

Hi Theo, Theo de Raadt wrote on Thu, Dec 20, 2018 at 03:58:31PM -0700: > Ingo Schwarze wrote: >> 1. Install /var/www/htdocs/mandoc.css by default. > I object to adding something to that directory. > > I think it should be empty so that users have nothing else surpr

Re: mandoc -T html default style

Hi Ted, hi Raphael, Ted Unangst wrote on Thu, Dec 20, 2018 at 11:36:06AM -0500: > Raphael Graf wrote: >> The diff inserts some space above the footer. >> This improves readability and makes it similar to the other output formats. >> >> Here is an example found in the wild, demonstrating the

Re: malloc.3: remove left-over from malloc_usable_size commit

Hi Hiltjo, Hiltjo Posthuma wrote on Wed, Dec 05, 2018 at 05:46:53PM +0100: > In the malloc_usable_size() revert commit it was forgotten > to remove one line. > > The below patch fixes this: Committed, thanks. Ingo > diff --git a/lib/libc/stdlib/malloc.3 b/lib/libc/stdlib/malloc.3 > index

Re: cvsintro.7: patch to fix .Bx invocation

Hi, Fabio Scotoni wrote on Wed, Dec 05, 2018 at 02:23:58PM +0100: > The cvsintro(7) man page uses ".Bx -licensed", > which is rendered as "-licensedBSD". You are right, that is incorrect usage. > This patch fixes this to correctly read "BSD-licensed" > in both mandoc and groff. > I'm not

Re: sed(1): disallow invocation without script

Hi Scott, Scott Cheloha wrote on Mon, Dec 03, 2018 at 08:47:23PM -0600: > This diff makes it an error to invoke sed(1) without any command > or script. I'm not convinced this makes anything better for anybody. For people who do not currently call sed(1) without giving a script, it makes no

Use regex search by default in apropos(1)?

Hi, currently, when you call apropos(1) in the default mode without explicitly specifying '=' for substring search or '~' for regular expression search, page names and one-line descriptions are searched case-insensitively for the substring specified. It appears that traditionally, FreeBSD

Re: [patch]Modify the example code in write(2) manual

Hi, Nan Xiao wrote on Wed, Sep 26, 2018 at 09:42:02PM +0800: > Any developer can comment on this patch? Thanks! I think this change is a bad idea and should not be committed. No matter whether or not it can happen on OpenBSD, *if* some implementation of write(2) sometimes returns 0 even for

Re: mandoc: typo fix (?) in mandoc.1

Hi Sascha, Sascha Paunovic wrote on Tue, Sep 18, 2018 at 06:39:51AM +0200: > while reading mandoc(1), I noticed that under the PostScript output > section, it said the line-height was 1.4m, while it is 1.4em. I doubt > the line-height is approximately as tall as a 5th grader, so let's > clarify

Re: syslogd log rotate documentation

Hi Alexander, Alexander Bluhm wrote on Fri, Aug 31, 2018 at 08:59:15PM +0200: > A coworker did not know that he has to send SIGHUP to syslogd after > rotating the log files. I realized that it is not documented. > > ok to add it to the man page? > > While there, replace two 'syslogd' with .Nm

Re: libtls: tls_config_set_ocsp_staple_file(3) wrong parameter type

Hi Mario, Mario Campos wrote on Mon, Aug 20, 2018 at 07:16:21PM -0500: > This is my first contribution. > If I'm doing something wrong here, please let me know. No, your patch is completely correct (it's likely a copy-paste oversight introduced when adding these functions to the manual page),

Re: poll.2: don't encourage use as sleep

Hi Scott, Scott Cheloha wrote on Fri, Aug 17, 2018 at 10:20:09AM -0500: > I don't think we should encourage or even mention the possibility of the > use of poll(2) to effect millisecond timeouts. Even if the standard > library lacks such an interface. > > I'm pretty sure you can't use this

Re: Remove unused variable in usr.bin/openssl/apps.c

Hi, this commit seems wrong to me. The function verify_callback() in the file s_cb.c contains this code: switch (err) { /* ... */ case X509_V_ERR_NO_EXPLICIT_POLICY: policies_print(bio_err, ctx); break; } if (err ==

libpcap supports classful network names only

Hi, tcpdump(8) does support named networks, but only using the following revolting syntax: $ grep fourrev /etc/hosts 0.192.168.4 fourrev $ tcpdump net fourrev $ ping 192.168.4.1 Two aspects are wrong with that: 1. The hosts(5) entry must have

Re: [PATCH] bs(6): removing extra signal()

Hi Martin, Martin Kopta wrote on Sat, Aug 04, 2018 at 11:04:34PM +0200: > The original version from Bruce Holloway in 1986-03-06 [0] did only one > signal(SIGINT), but the call was probably duplicated after code cleanup by ESR > somewhere between 1986 and 1993. > > Please, confirm there is no

Re: paste(1): use getline instead of fgetln

Hi Lauri, Lauri Tirkkonen wrote on Tue, Jul 17, 2018 at 09:14:29PM +0300: > In the same vein as my previous diff for join(1), make paste(1) > use getline instead of fgetln. Committed with my tweks. Thanks for your patch, Ingo

Re: tweaks to namei.9

Hi Jason, Jason McIntyre wrote on Thu, Aug 02, 2018 at 05:41:22PM +0100: > ok by me. Thanks for checking, committed. > you might get away with removing the last sentence of BUGS > now, since HISTORY almost provides the same. Maybe, but i don't know enough about ufs and vfs to judge whether it

Re: tweaks to namei.9

Hi, the first paragraph of the DESCRIPTION is all fluff. Let's just wipe it away completely, we always want the DESCRIPTION to be concise and get to the point. Instead, provide some real HISTORY. DESCRIPTION: minus five lines, same amount of information. HISTORY: plus three lines, but now

Re: paste(1): use getline instead of fgetln

Hi, Lauri Tirkkonen wrote on Tue, Jul 17, 2018 at 09:14:29PM +0300: > In the same vein as my previous diff for join(1), > make paste(1) use getline instead of fgetln. I think it's correct, but i tweaked it a bit for simplicity. In sequential(), the double loop with double getline(), both with

Re: [diff] www/innovations.html: fix link

> +https://man.openbsd.org/man.cgi.8;>man.cgi(8): > Started by Kristaps Dzonsons in November 2008. > Imported April 6, 2009, first released with OpenBSD 4.8. > Now maintained by Ingo Schwarze.

Re: join(1): use getline instead of fgetln

Hi Todd, Todd C. Miller wrote on Tue, Jul 17, 2018 at 01:38:14PM -0600: > On Tue, 17 Jul 2018 13:21:31 -0600, "Todd C. Miller" wrote: >> It probably makes more sense to do the newline check (and decrement >> len if one is present) before newsize is computed. Then you would >> need to

21st century lam(1)

>align == '-') + while (width++ < ip->minwidth && lp + 1 < line + sizeof(line)) + *lp++ = ' '; + *lp = '\0'; return (lp); } Index: utf8.c === RCS file: utf8.c

Re: [PATCH] column(1): -r to right justify

An afterthought... Ingo Schwarze wrote on Sun, Jul 08, 2018 at 08:22:34PM +0200: > If you opt for requiring an argument, > then you can use a cut(1)-like syntax: Alternatively, you can use a syntax similar to tbl(7) "Layout" lines: rrll which allows later extensions like

Re: [PATCH] column(1): -r to right justify

Hi Job, Job Snijders wrote on Wed, Jul 04, 2018 at 02:09:56PM +0200: > Following some back and forth on how disklabel output should be > formatted, I proposed to Kenneth to extend the column(1) utility. > All that was missing is the ability to right justify. I'm not totally sure we should add

Re: pthread_create: fix segfault when attr is NULL

Hi Jason, Jason McIntyre wrote on Sat, Jul 07, 2018 at 07:17:29AM +0100: > the 2/3 pages should really reference the most recent standards too. > it's just the work hasn;t been done. According to my understanding, the difference in policy is deliberate. Some people may want to write C code

Re: pthread_create: fix segfault when attr is NULL

Hi, Scott Cheloha wrote on Fri, Jul 06, 2018 at 07:31:36PM -0500: > On Fri, Jul 06, 2018 at 03:07:12PM +0200, Mark Kettenis wrote: >> Paul Irofti wrote on Fri, 6 Jul 2018 15:36:07 +0300: >>> somebody wrote: POSIX currently says: The behavior is undefined if the value specified

Re: mandoc potential memory leak fix

Hi, Florian Obser wrote on Mon, Jun 18, 2018 at 06:54:49PM +0200: > On Mon, Jun 18, 2018 at 04:37:32PM +0200, Jan Schreiber wrote: >> this patch closes potential memory leaks in the mandoc memory >> wrapper functions and follows the examples in the manpages. > These are not leaks since mandoc

Re: [markup] manual page HTML validation

Hi Anton, li...@wrant.com wrote on Mon, May 28, 2018 at 06:04:50PM +0300: > Thanks for applying the fixes, > can we have HTML 4.01 * web manual pages? No, you can't. > I'll understand if the answer is no, > short listed explanation would do.. While i often advocate using well-established,

Re: [markup] manual page HTML validation

Hi Anton, li...@wrant.com wrote on Mon, May 28, 2018 at 12:39:05PM +0300: > https://validator.w3.org/nu/?doc=http%3A%2F%2Fman.openbsd.org%2Fpf.conf > https://validator.w3.org/nu/?doc=http%3A%2F%2Fman.openbsd.org%2Fifconfig Thanks for spotting these errors. I just fixed them with the commit

Re: [diff] missing quotes in tls_peer_cert_chain_pem(3)

Hi Jack, Jack Burton wrote on Sat, May 26, 2018 at 08:27:54PM +0930: > Just noticed this in passing while working on something else. Committed, thanks. Ingo > Index: lib/libtls/man/tls_conn_version.3 > === > RCS file:

Re: Typo in utf8.7

Hi Ross, Ross L Richardson wrote on Wed, May 16, 2018 at 05:30:08PM +1000: > Two bytes plus a bonus bit :-) Feel free to keep the bonus bit for yourself, no need to return it to the project. :) > Patch below. Committed, thanks for spotting it. Ingo > Index: utf8.7 >

Re: Explain 'S' short-hand in malloc.conf

Hi Christian, Christian Ludwig wrote on Thu, May 03, 2018 at 04:57:55PM +0200: > The 'S' flag in malloc.conf(5) is a short-hand for several other flags. > Explain which flags it sets exactly. Your diff is *not* OK. These details are intentionally undocumented because they change often. This

Re: [PATCH] mv -P

Hi, attila wrote on Sat, Apr 28, 2018 at 11:50:17AM -0500: > I frequently want to move a file from one place to another and shred > the original via the rm(1) -P option. I strongly object to adding another turd on top of the useless rm(1) -P option; it was recently discussed how useless it is,

Re: [patch] Add error handling in usr.bin/time/time.c

Hi, Nan Xiao wrote on Fri, Apr 20, 2018 at 10:11:55PM +0800: > Ingo Schwarze wrote: >> No. Read the manual page and /sys/kern/kern_time.c : >> >> With a valid clock id and a valid address, this function >> cannot fail, so you are just adding dead code. Worse, >&g

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

Hi, Jimmy Hess wrote on Fri, Apr 20, 2018 at 06:53:44AM -0500: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: >> I don't think these are "redundant quotes" but rather ditto marks: > The ditto mark and the quote character are not the same character, > and the

<    1   2   3   4   5   6   7   8   9   10   >