Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-06 Thread Klemens Nanni
06.04.2023 14:48, Christian Weisgerber пишет: > We need to consider > (1) mode: install, upgrade > (2) medium: installXX, other > > installXX.img and .iso carry the sets, and people who choose this > medium typically want to use the sets from the medium. Other media > need to access external

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-06 Thread Christian Weisgerber
On 2023-04-05, Klemens Nanni wrote: >> In conversation with Klemens (kn@) new iteration has been born, it >> follows to what Omar (op@) has suggested - we're not trying to change >> the default answer for all cases, since no one complained for all these >> years, but just flip default for

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-05 Thread Andrew Hewus Fresh
On Wed, Apr 05, 2023 at 11:11:12AM +, Klemens Nanni wrote: > 04.04.2023 19:58, Mikhail пишет: > > In conversation with Klemens (kn@) new iteration has been born, it > > follows to what Omar (op@) has suggested - we're not trying to change > > the default answer for all cases, since no one

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-05 Thread Klemens Nanni
04.04.2023 19:58, Mikhail пишет: > In conversation with Klemens (kn@) new iteration has been born, it > follows to what Omar (op@) has suggested - we're not trying to change > the default answer for all cases, since no one complained for all these > years, but just flip default for installation

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-04 Thread Mikhail
On Sat, Apr 01, 2023 at 04:33:39PM +0300, Mikhail wrote: > Currently default answer for the question is 'yes', which is not true > for install case, but correct for upgrade one. > > Changing default answer depending on the mode of the installer looks > like a good approach. Idea by Christian

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-02 Thread Mikhail
On Sat, Apr 01, 2023 at 04:31:59PM +, Klemens Nanni wrote: > 01.04.2023 13:33, Mikhail пишет: > $_answer may be unset, but you still pass it and thus rely on ask_yn()'s > default 'no' answer. > > I'd just default-initialise up front and flip if conditions are met. > This should read and

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-01 Thread Klemens Nanni
01.04.2023 13:33, Mikhail пишет: > Currently default answer for the question is 'yes', which is not true > for install case, but correct for upgrade one. True for sysupgrade(8) (at least with default /home/_sysupgrade), but certainly not true in general for every update scenario. > Changing

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-01 Thread Omar Polo
On 2023/04/01 16:33:39 +0300, Mikhail wrote: > Currently default answer for the question is 'yes', which is not true > for install case, but correct for upgrade one. > > Changing default answer depending on the mode of the installer looks > like a good approach. Idea by Christian (naddy@),

[installer] default answer to "Is the disk partition already mounted?"

2023-04-01 Thread Mikhail
Currently default answer for the question is 'yes', which is not true for install case, but correct for upgrade one. Changing default answer depending on the mode of the installer looks like a good approach. Idea by Christian (naddy@), implementation and testing are mine. diff /usr/src commit -