Re: Fix incorrect checksum generation in sr_meta_init

2022-04-07 Thread Leo Unglaub
Hey, i cannot comment on the correctness of the change, but i have it in my tree running for 5 days now without any problems. This is not an OK, just feedback. Greetings Leo On 27.03.22 01:20, Crystal Kolipe wrote: --- softraid.c.dist Sat Mar 26 19:40:51 2022 +++ softraid.c Sat Mar 26

Re: Fix incorrect checksum generation in sr_meta_init

2022-03-28 Thread Theo de Raadt
kqueue uses a userland data structure. The netbsd PR is saying that the userland data structure gets corrupted, so that the event doesn't arrive. Thus the process stops. That PR says their kernel is not buggy, but the kqueue handling. If they are updated on libuv, maybe they are seeing the

Fix incorrect checksum generation in sr_meta_init

2022-03-26 Thread Crystal Kolipe
Summary: In function sr_meta_init in softraid.c, there are two bugs which cause the chunk checksum stored in scm_checksum to be incorrectly calculated. This affects all newly created softraid volumes. Details: The MD5 checksum in scm_checksum should be calculated over the first 72 bytes of