Re: Keyboard resume (zzz) diff

2016-05-03 Thread sid77
- Original Message - > - Original Message - > > Since it worked before, start bisecting diffs. Once you've narrowed it > > down, > > let us know. > > Tried to do that but I can't boot past the 4th April softraid update :-/ Small update: I spent some time on this over the weekend

Re: Keyboard resume (zzz) diff

2016-04-23 Thread sid77
- Original Message - > Since it worked before, start bisecting diffs. Once you've narrowed it down, > let us know. Tried to do that but I can't boot past the 4th April softraid update :-/ -- Marco Bonetti

Re: Keyboard resume (zzz) diff

2016-04-21 Thread Mike Larkin
On Fri, Apr 22, 2016 at 12:12:58AM +0200, si...@slackware.it wrote: > - Original Message - > > Considering you don't even have a pckbd, I think this is not likely caused > > by the pckbd zzz diff committed last week. > AH! Good to know :D > > > If you want to be sure, revert that single

Re: Keyboard resume (zzz) diff

2016-04-21 Thread sid77
- Original Message - > Considering you don't even have a pckbd, I think this is not likely caused > by the pckbd zzz diff committed last week. AH! Good to know :D > If you want to be sure, revert that single commit and check it again. Yup, obviously confirmed: no changes with pckbd.c

Re: Keyboard resume (zzz) diff

2016-04-21 Thread Mike Larkin
On Thu, Apr 21, 2016 at 07:29:56PM +0200, si...@slackware.it wrote: > Coming late to the party for a negative report: OpenBSD 5.9-current on a > MacBookAir5,2 is suspending and hibernating OK but on resuming the keyboard > is not working correctly any more, it used to work fine on OpenBSD >

Re: Keyboard resume (zzz) diff

2016-04-21 Thread sid77
Coming late to the party for a negative report: OpenBSD 5.9-current on a MacBookAir5,2 is suspending and hibernating OK but on resuming the keyboard is not working correctly any more, it used to work fine on OpenBSD 5.9-release. If needed, dmesg is below. OpenBSD 5.9-current (GENERIC.MP)

Re: Keyboard resume (zzz) diff

2016-04-12 Thread Miod Vallat
> I think the best idea is to proceed with the diff as posted, with > the added check to make sure the keyboard is enabled, and to always > call config_activate_children on all paths through pckbd_activate? > > In other words, no changes to wskbd_enable or wskbd_activate. > > Sound right? I

Re: Keyboard resume (zzz) diff

2016-04-12 Thread Mike Larkin
On Tue, Apr 12, 2016 at 06:24:10AM +, Miod Vallat wrote: > > wskbd_enable (calls pckbd_enable) does not appear to be called from > > wskbd_activate, perhaps just calling wskbd_enable from there would be > > better? (as a matter of fact, wskbd_activate doesn't really do much at > > all except

Re: Keyboard resume (zzz) diff

2016-04-12 Thread Miod Vallat
> wskbd_enable (calls pckbd_enable) does not appear to be called from > wskbd_activate, perhaps just calling wskbd_enable from there would be > better? (as a matter of fact, wskbd_activate doesn't really do much at > all except set sc_dying=1, and I'm not sure where that gets reset.) Nooo!

Re: Keyboard resume (zzz) diff

2016-04-11 Thread Mike Larkin
On Mon, Apr 11, 2016 at 11:23:57PM +0200, Martin Pieuchot wrote: > On 10/04/16(Sun) 23:33, Mike Larkin wrote: > > Please test this diff on all machines that you can successfully (today) > > resume with 'zzz'. Please make sure that after resume, the keyboard > > still works. > > > > This diff

Re: Keyboard resume (zzz) diff

2016-04-11 Thread Martin Pieuchot
On 10/04/16(Sun) 23:33, Mike Larkin wrote: > Please test this diff on all machines that you can successfully (today) > resume with 'zzz'. Please make sure that after resume, the keyboard > still works. > > This diff re-enables the keyboard on resume. Previously, we were re-enabling > the keyboard

Re: Keyboard resume (zzz) diff

2016-04-11 Thread Simon McFarlane
On 04/10/16 23:33, Mike Larkin wrote: Please test this diff on all machines that you can successfully (today) resume with 'zzz'. Please make sure that after resume, the keyboard still works. This diff re-enables the keyboard on resume. Previously, we were re-enabling the keyboard *controller*

Re: Keyboard resume (zzz) diff

2016-04-11 Thread Mike Larkin
On Mon, Apr 11, 2016 at 04:02:34PM +0200, Mark Kettenis wrote: > > Date: Sun, 10 Apr 2016 23:33:59 -0700 > > From: Mike Larkin > > > > Please test this diff on all machines that you can successfully (today) > > resume with 'zzz'. Please make sure that after resume, the

Re: Keyboard resume (zzz) diff

2016-04-11 Thread Mark Kettenis
> Date: Sun, 10 Apr 2016 23:33:59 -0700 > From: Mike Larkin > > Please test this diff on all machines that you can successfully (today) > resume with 'zzz'. Please make sure that after resume, the keyboard > still works. > > This diff re-enables the keyboard on resume.

Keyboard resume (zzz) diff

2016-04-11 Thread Mike Larkin
Please test this diff on all machines that you can successfully (today) resume with 'zzz'. Please make sure that after resume, the keyboard still works. This diff re-enables the keyboard on resume. Previously, we were re-enabling the keyboard *controller* but apparently on some machines (notably