Re: Mention Smart Battery Data Spec in smbus.h

2022-03-05 Thread patrick keshishian
On Sat, Mar 05, 2022 at 09:37:32PM +1100, Damien Miller wrote: > without commenting on the substance of this change, it should definitely > not be added to the copyright block Good point. I thought adding reference to SMBus spec and mention of ACPI section where SMBus register offsets are

Re: Mention Smart Battery Data Spec in smbus.h

2022-03-05 Thread Damien Miller
without commenting on the substance of this change, it should definitely not be added to the copyright block On Fri, 4 Mar 2022, patrick keshishian wrote: > Hello, > > I took a wrong turn, and got interested in where the SMBATT_CMD_* > defines were sourced. > > Adding a reference to Smart

Mention Smart Battery Data Spec in smbus.h

2022-03-05 Thread patrick keshishian
Hello, I took a wrong turn, and got interested in where the SMBATT_CMD_* defines were sourced. Adding a reference to Smart Battery Data Spec might save someone else the time searching through ACPI spec, then SMBus spec, to finally arriving at the answer. Is the following diff acceptable? I