Re: OpenSMTPD and mask-source flag.

2016-02-13 Thread Joerg Jung
On Fri, Feb 12, 2016 at 05:00:59PM -0500, Peter Bisroev wrote: > > Just in case the previous diff is OK, I am attaching the patch to the > > smtpd.conf man page. > > Hi Gilles, > > I apologize, my previous manpage diff did not include the information > regarding > the fact that connections

Re: OpenSMTPD and mask-source flag.

2016-02-13 Thread Gilles Chehade
On Fri, Feb 12, 2016 at 04:29:23PM -0500, Peter Bisroev wrote: > Hi Gilles, > Hi, > While looking over smtp_enqueue(), I have noticed that setting of > hostname is a noop. It looks like a leftover code from a bugfix in here >

Re: OpenSMTPD and mask-source flag.

2016-02-13 Thread Gilles Chehade
On Sat, Feb 13, 2016 at 08:32:23PM +0100, Joerg Jung wrote: > On Fri, Feb 12, 2016 at 05:00:59PM -0500, Peter Bisroev wrote: > > > Just in case the previous diff is OK, I am attaching the patch to the > > > smtpd.conf man page. > > > > Hi Gilles, > > > > I apologize, my previous manpage diff did

Re: OpenSMTPD and mask-source flag.

2016-02-13 Thread Peter Bisroev
Thank you Joerg for your comments on the manpage diff. But it looks like Gilles has already committed the diff according to his previous response. Thank you Gilles! Just in case, I am including the updated diff as I reworded it as well. Gilles, Joerg, could you please see if rewording makes the

Re: OpenSMTPD and mask-source flag.

2016-02-12 Thread Gilles Chehade
On Thu, Feb 11, 2016 at 05:28:50PM -0500, Peter Bisroev wrote: > Hi Gilles, > > Please find my diff inline to enable "listen on socket" feature that we have > discussed. I have tested the diff with currently two supported listen options > for this listener, mask-sender and filter. Everything

Re: OpenSMTPD and mask-source flag.

2016-02-12 Thread Peter Bisroev
> Just in case the previous diff is OK, I am attaching the patch to the > smtpd.conf man page. Hi Gilles, I apologize, my previous manpage diff did not include the information regarding the fact that connections through local socket will always be tagged 'local'. Please find the corrected

Re: OpenSMTPD and mask-source flag.

2016-02-12 Thread Peter Bisroev
Hi Gilles, While looking over smtp_enqueue(), I have noticed that setting of hostname is a noop. It looks like a leftover code from a bugfix in here (http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin/smtpd/smtp.c.diff?r2=1.141=1.140=u) I am including a diff to smtp.c below that includes the

Re: OpenSMTPD and mask-source flag.

2016-02-12 Thread Peter Bisroev
> I only skimmed through your diff, I need to apply it and read in > context but I like it a lot. > > I'll test today and come back with comments once I've spent more > time reading it ;-) > > Thanks Awesome, thank you Gilles! Just in case the previous diff is OK, I am attaching the patch to

Re: OpenSMTPD and mask-source flag.

2016-02-11 Thread Peter Bisroev
Hi Gilles, Please find my diff inline to enable "listen on socket" feature that we have discussed. I have tested the diff with currently two supported listen options for this listener, mask-sender and filter. Everything seems to be working OK. These are the summary of the changes: * Parser was

Re: OpenSMTPD and mask-source flag.

2016-02-09 Thread Peter Bisroev
Hi Gilles > We have faced a similar issue with filters and my thoughts are that we need a > listen on socket of some kind, similar to your listen on local. > > This has several benefits over "listen on local", both in ambiguity and it > new ways the ruleset can match sessions. > > If you're

Re: OpenSMTPD and mask-source flag.

2016-02-09 Thread Gilles Chehade
On Tue, Feb 09, 2016 at 09:23:17AM -0500, Peter Bisroev wrote: > Hi Gilles > Hi, > > > > We have faced a similar issue with filters and my thoughts are that we need > > a > > listen on socket of some kind, similar to your listen on local. > > > > This has several benefits over "listen on

OpenSMTPD and mask-source flag.

2016-02-08 Thread Peter Bisroev
Dear OpenSMTPD Developers! I think there is a little "bug/feature" with respect to handling "mask-source" parameter with "listen on" directive in smtpd.conf. The behavior makes perfect sense from the perspective of documentation. Unfortunately it is not uniform from the perspective of the client.

Re: OpenSMTPD and mask-source flag.

2016-02-08 Thread Gilles Chehade
On Mon, Feb 08, 2016 at 08:32:31PM -0500, Peter Bisroev wrote: > Dear OpenSMTPD Developers! > Dear Peter, > I think there is a little "bug/feature" with respect to handling "mask-source" > parameter with "listen on" directive in smtpd.conf. The behavior makes perfect > sense from the