Re: PATCH: Fix invalid size to 'memcmp' in 'rn_lexobetter'

2013-12-11 Thread Todd C. Miller
Your diff looks correct to me. In the old code, we had this loop: for (lim = mp + *mp; mp < lim;) if (*mp++ > *np++) return 1; return 0; Which was replaced by: lim = mp + *mp; return (memcmp(mp, np, *lim) > 0); which is not equivalent since lim points to

PATCH: Fix invalid size to 'memcmp' in 'rn_lexobetter'

2013-12-10 Thread Kieran Devlin
maybe someone could verify & commit this patch this bug was introduced in r1.28 of ‘src/sys/net/radix.c’ i found it while going through source codes Index: sys/net/radix.c === RCS file: /cvs/src/sys/net/radix.c,v retrieving revision