Re: PATCH: rtsol support for RA DNS options

2014-09-21 Thread Stuart Henderson
SMALL is needed to reduce storage requirements on ramdisks. RA DNS support has been mentioned before, I think there was some sort of plan to have the kernel record the information and allow userland to retrieve it but I don't recall the details. Certainly rtsol is not required in order for

Re: PATCH: rtsol support for RA DNS options

2014-09-21 Thread Charles Musser
On Sep 21, 2014, at 4:43 AM, Stuart Henderson s...@spacehopper.org wrote: SMALL is needed to reduce storage requirements on ram disks. Makes sense. Here are executable sizes of the installed binaries on amd64, with -current and -current + this patch: -current: -r-xr-xr-x 1 root bin 136400

Re: PATCH: rtsol support for RA DNS options

2014-09-21 Thread Stefan Sperling
On Sun, Sep 21, 2014 at 08:49:54AM -0700, Charles Musser wrote: Understood. At it now stands, processing of RAs is in the kernel, to bring up interfaces and add routes. Rtsol acts as the tickler, to solicit them promptly, but that's basically it. In -current, solicitations are sent by the

Re: PATCH: rtsol support for RA DNS options

2014-09-21 Thread Charles Musser
I didn't realize autoconf was in in the kernel and plumbed up through ifconfig. Centralizing this stuff seems like a cleaner way to do it than having rtsol/rtsold, in which case this patch is barking up the wrong tree. Has any thought been given to pushing (or pulling) the DNS-related RA

Re: PATCH: rtsol support for RA DNS options

2014-09-21 Thread Theo de Raadt
I didn't realize autoconf was in in the kernel and plumbed up through ifconfig. Centralizing this stuff seems like a cleaner way to do it than having rtsol/rtsold, in which case this patch is barking up the wrong tree. Yes, you are working in an old tree. Has any thought been given to

Re: PATCH: rtsol support for RA DNS options

2014-09-21 Thread Charles Musser
On Sep 21, 2014, at 11:02 AM, Theo de Raadt dera...@cvs.openbsd.org wrote: I didn't realize autoconf was in in the kernel and plumbed up through ifconfig. Centralizing this stuff seems like a cleaner way to do it than having rtsol/rtsold, in which case this patch is barking up the wrong

Re: PATCH: rtsol support for RA DNS options

2014-09-21 Thread Theo de Raadt
One way to manage the file is the openresolv script I mentioned earlier. The idea is that entities like dhclient invoke it with resolver information they want to use and the script merges requests from multiple sources. I do not understand how this solution will practically work. Seeing as

Re: PATCH: rtsol support for RA DNS options

2014-09-21 Thread Charles Musser
On Sep 21, 2014, at 11:50 AM, Theo de Raadt dera...@cvs.openbsd.org wrote: One way to manage the file is the openresolv script I mentioned earlier. The idea is that entities like dhclient invoke it with resolver information they want to use and the script merges requests from multiple

Re: PATCH: rtsol support for RA DNS options

2014-09-20 Thread Sebastian Benoit
Charles Musser(cmus...@sonic.net) on 2014.09.20 14:44:45 -0700: + /* + * XXX validate that domain name only contains valid characters + * for two reasons: 1) correctness, 2) we do not want to pass + * possible malicious, unescaped characters like `` to a script + * or

Re: PATCH: rtsol support for RA DNS options

2014-09-20 Thread Charles Musser
On Sep 20, 2014, at 3:36 PM, Sebastian Benoit benoit-li...@fb12.de wrote: Charles Musser(cmus...@sonic.net) on 2014.09.20 14:44:45 -0700: +/* + * XXX validate that domain name only contains valid characters + * for two reasons: 1) correctness, 2) we do not want to pass + *

Re: PATCH: rtsol support for RA DNS options

2014-09-20 Thread Charles Musser
Better patch, with validation in the domain name decoder function. Still unsure how to proceed with regards to the objection to less SMALL. Chuck Index: dump.c === RCS file: /cvs/src/usr.sbin/rtsold/dump.c,v retrieving revision