Re: wskbd_set_mixervolume

2022-02-11 Thread Alexandre Ratchov
On Thu, Feb 10, 2022 at 04:53:59PM +0100, Anton Lindqvist wrote: > On Wed, Feb 09, 2022 at 09:13:58AM +0100, Alexandre Ratchov wrote: > > On Tue, Feb 08, 2022 at 06:59:39PM +0100, Anton Lindqvist wrote: > > > On Tue, Feb 08, 2022 at 07:32:38AM +0100, Alexandre Ratchov wrote: > > > > On Mon, Feb

Re: wskbd_set_mixervolume

2022-02-10 Thread Anton Lindqvist
On Wed, Feb 09, 2022 at 09:13:58AM +0100, Alexandre Ratchov wrote: > On Tue, Feb 08, 2022 at 06:59:39PM +0100, Anton Lindqvist wrote: > > On Tue, Feb 08, 2022 at 07:32:38AM +0100, Alexandre Ratchov wrote: > > > On Mon, Feb 07, 2022 at 06:55:21PM +0100, Anton Lindqvist wrote: > > > > On Mon, Feb

Re: wskbd_set_mixervolume

2022-02-09 Thread Alexandre Ratchov
On Tue, Feb 08, 2022 at 06:59:39PM +0100, Anton Lindqvist wrote: > On Tue, Feb 08, 2022 at 07:32:38AM +0100, Alexandre Ratchov wrote: > > On Mon, Feb 07, 2022 at 06:55:21PM +0100, Anton Lindqvist wrote: > > > On Mon, Feb 07, 2022 at 11:21:43AM +0100, Alexandre Ratchov wrote: > > > > On Sun, Feb

Re: wskbd_set_mixervolume

2022-02-08 Thread Anton Lindqvist
On Tue, Feb 08, 2022 at 07:32:38AM +0100, Alexandre Ratchov wrote: > On Mon, Feb 07, 2022 at 06:55:21PM +0100, Anton Lindqvist wrote: > > On Mon, Feb 07, 2022 at 11:21:43AM +0100, Alexandre Ratchov wrote: > > > On Sun, Feb 06, 2022 at 08:40:35AM +0100, Anton Lindqvist wrote: > > > > > > > >

Re: wskbd_set_mixervolume

2022-02-07 Thread Alexandre Ratchov
On Mon, Feb 07, 2022 at 06:55:21PM +0100, Anton Lindqvist wrote: > On Mon, Feb 07, 2022 at 11:21:43AM +0100, Alexandre Ratchov wrote: > > On Sun, Feb 06, 2022 at 08:40:35AM +0100, Anton Lindqvist wrote: > > > > > > Polished diff. I'm omitting a necessary refactoring commit making > > >

Re: wskbd_set_mixervolume

2022-02-07 Thread Alexandre Ratchov
On Mon, Feb 07, 2022 at 06:58:40PM +0100, Anton Lindqvist wrote: > On Mon, Feb 07, 2022 at 11:43:43AM +0100, Alexandre Ratchov wrote: > > On Sat, Feb 05, 2022 at 06:30:43PM +0100, Claudio Jeker wrote: > > > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > > > Date: Sat, 5 Feb

Re: wskbd_set_mixervolume

2022-02-07 Thread Anton Lindqvist
On Mon, Feb 07, 2022 at 11:43:43AM +0100, Alexandre Ratchov wrote: > On Sat, Feb 05, 2022 at 06:30:43PM +0100, Claudio Jeker wrote: > > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > > > From: Anton Lindqvist > > > > > > > > Hi, >

Re: wskbd_set_mixervolume

2022-02-07 Thread Anton Lindqvist
On Mon, Feb 07, 2022 at 11:21:43AM +0100, Alexandre Ratchov wrote: > On Sun, Feb 06, 2022 at 08:40:35AM +0100, Anton Lindqvist wrote: > > > > Polished diff. I'm omitting a necessary refactoring commit making > > audio_attach_mi() accept a new cookie argument. > > > > I'm not sure to understand

Re: wskbd_set_mixervolume

2022-02-07 Thread Alexandre Ratchov
On Sat, Feb 05, 2022 at 06:30:43PM +0100, Claudio Jeker wrote: > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > > From: Anton Lindqvist > > > > > > Hi, > > > I recently got a USB headset with physical volume buttons, handled by > > >

Re: wskbd_set_mixervolume

2022-02-07 Thread Alexandre Ratchov
On Sun, Feb 06, 2022 at 08:40:35AM +0100, Anton Lindqvist wrote: > > Polished diff. I'm omitting a necessary refactoring commit making > audio_attach_mi() accept a new cookie argument. > I'm not sure to understand the need for the wskbd_audio structure. Couldn't we just store the cookie in

Re: wskbd_set_mixervolume

2022-02-06 Thread Alexandre Ratchov
On Sat, Feb 05, 2022 at 06:30:43PM +0100, Claudio Jeker wrote: > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > > From: Anton Lindqvist > > > > > > Hi, > > > I recently got a USB headset with physical volume buttons, handled by > > >

Re: wskbd_set_mixervolume

2022-02-06 Thread Alexandre Ratchov
On Sat, Feb 05, 2022 at 09:29:42AM +0100, Anton Lindqvist wrote: > Hi, > I recently got a USB headset with physical volume buttons, handled by > ucc(4). However, after enabling the device in sndiod the volume buttons > does not cause the volume to change. Turns out wskbd_set_mixervolume() > is

Re: wskbd_set_mixervolume

2022-02-05 Thread Anton Lindqvist
On Sat, Feb 05, 2022 at 02:46:53PM +0100, Anton Lindqvist wrote: > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > > From: Anton Lindqvist > > > > > > Hi, > > > I recently got a USB headset with physical volume buttons, handled by > >

Re: wskbd_set_mixervolume

2022-02-05 Thread Claudio Jeker
On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > From: Anton Lindqvist > > > > Hi, > > I recently got a USB headset with physical volume buttons, handled by > > ucc(4). However, after enabling the device in sndiod the volume buttons > >

Re: wskbd_set_mixervolume

2022-02-05 Thread Anton Lindqvist
On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > From: Anton Lindqvist > > > > Hi, > > I recently got a USB headset with physical volume buttons, handled by > > ucc(4). However, after enabling the device in sndiod the volume buttons > >

Re: wskbd_set_mixervolume

2022-02-05 Thread Mark Kettenis
> Date: Sat, 5 Feb 2022 09:29:42 +0100 > From: Anton Lindqvist > > Hi, > I recently got a USB headset with physical volume buttons, handled by > ucc(4). However, after enabling the device in sndiod the volume buttons > does not cause the volume to change. Turns out wskbd_set_mixervolume() > is