Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Theo de Raadt
Right. This is called "idiomatic programming". Sometimes it looks a bit idiotic (haha), but as the years go by, we've learned that stylistic reminders that a rarely used function's parameter is a variadic format string, helps us avoid introduction of new mistakes during future development. Stuar

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Martijn van Duren
On Tue, 2022-09-27 at 11:23 +0200, Florian Obser wrote: > On 2022-09-27 09:26 +02, Martijn van Duren wrote: > > The caveats section talks about "user-supplied data". These string are > > constant and don't contain any '%'. Most other daemons in base use the > > setproctitle("title"); format as wel

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Florian Obser
On 2022-09-27 09:26 +02, Martijn van Duren wrote: > The caveats section talks about "user-supplied data". These string are > constant and don't contain any '%'. Most other daemons in base use the > setproctitle("title"); format as well. It's not that clear cut, snmpd(8), a daemon you might be fam

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Martijn van Duren
The caveats section talks about "user-supplied data". These string are constant and don't contain any '%'. Most other daemons in base use the setproctitle("title"); format as well. On Tue, 2022-09-27 at 08:07 +0100, Stuart Henderson wrote: > These programs seem OK as-is, they are following the adv

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Stuart Henderson
These programs seem OK as-is, they are following the advice in https://man.openbsd.org/setproctitle.3#CAVEATS On 2022/09/26 18:06, Josiah Frentsos wrote: > Index: sbin/dhcpleased/engine.c > === > RCS file: /cvs/src/sbin/dhcpleased/eng

Remove some unnecessary setproctitle(3) format strings

2022-09-26 Thread Josiah Frentsos
Index: sbin/dhcpleased/engine.c === RCS file: /cvs/src/sbin/dhcpleased/engine.c,v retrieving revision 1.38 diff -u -p -r1.38 engine.c --- sbin/dhcpleased/engine.c5 May 2022 14:44:59 - 1.38 +++ sbin/dhcpleased/engine.c