Re: bgpctl mrt parser refactor

2019-02-22 Thread Klemens Nanni
Diff reads good, although I'm not a BGP user. One nit inline: > @@ -689,31 +690,32 @@ mrt_parse_dump_mp(struct mrt_hdr *hdr, v > - case AF_VPNv4: > + case AID_VPN_IPv4: > if (len < MRT_PREFIX_LEN(r->prefixlen)) > goto fail; > - errx(1,

bgpctl mrt parser refactor

2019-02-22 Thread Claudio Jeker
Instead of using and abusing sockaddr structs to parse addrs in mrt messages use struct bgpd_addr since bgpctl can handle them much better. I first wrote the mrt parser independet of bgpctl and decided to not use bgpd internals. I no longer see the benefit of this. This makes the code cleaner. I