Re: fdformat: reformat usage()

2018-09-17 Thread Robert Klein
On Sun, 16 Sep 2018 22:48:01 +0100 Jason McIntyre wrote: > On Wed, Sep 12, 2018 at 05:40:49PM +0100, Jason McIntyre wrote: > > On Wed, Sep 12, 2018 at 11:50:18AM +0200, Sascha Paunovic wrote: > > > Since C99, string literal concatenation is provided, allowing the > > > number of printf() calls

Re: fdformat: reformat usage()

2018-09-17 Thread Jason McIntyre
On Mon, Sep 17, 2018 at 02:40:49PM +0200, Robert Klein wrote: > > > > ok, so here's the diff i propose. yay? nay? > > jmc > > > > Index: fdformat.c > > === > > RCS file: /cvs/src/usr.sbin/fdformat/fdformat.c,v > > retrieving revision

Re: fdformat: reformat usage()

2018-09-17 Thread Robert Klein
(sorry, if this turns up twice, first attempt didn't show up for a couple of hours; updated doc patch below) On Sun, 16 Sep 2018 22:48:01 +0100 Jason McIntyre wrote: > On Wed, Sep 12, 2018 at 05:40:49PM +0100, Jason McIntyre wrote: > > On Wed, Sep 12, 2018 at 11:50:18AM +0200, Sascha Paunovic w

Re: fdformat: reformat usage()

2018-09-16 Thread Jason McIntyre
On Wed, Sep 12, 2018 at 05:40:49PM +0100, Jason McIntyre wrote: > On Wed, Sep 12, 2018 at 11:50:18AM +0200, Sascha Paunovic wrote: > > Since C99, string literal concatenation is provided, allowing the number > > of printf() calls to be greatly reduced (20 -> 1). > > > > This is my first diff I'm s

Re: fdformat: reformat usage()

2018-09-12 Thread d . rauschenb
Hi, > unrelated question: anyone know why the argument to -g is "gap3len"? The gap between the sectors. More info at https://en.wikipedia.org/wiki/Floppy_disk_format#Sectoring -dra

Re: fdformat: reformat usage()

2018-09-12 Thread Sascha Paunovic
On Wed, Sep 12, 2018 at 05:40:49PM +0100, Jason McIntyre wrote: > hi. > > i'm all for the diff but... generally usage() does not spit out a > description of the options (with some exceptions). if you look at the > man page, the irony is that the usage seems more verbose. > > anyone object to remo

Re: fdformat: reformat usage()

2018-09-12 Thread Jason McIntyre
On Wed, Sep 12, 2018 at 11:50:18AM +0200, Sascha Paunovic wrote: > Since C99, string literal concatenation is provided, allowing the number > of printf() calls to be greatly reduced (20 -> 1). > > This is my first diff I'm sending, feedback would be very appreciated. > hi. i'm all for the diff

fdformat: reformat usage()

2018-09-12 Thread Sascha Paunovic
Since C99, string literal concatenation is provided, allowing the number of printf() calls to be greatly reduced (20 -> 1). This is my first diff I'm sending, feedback would be very appreciated. diff --git usr.sbin/fdformat/fdformat.c usr.sbin/fdformat/fdformat.c index c2566992e..2d6afbd3f 100644