Re: help needed from someone with an sk(4)

2014-04-19 Thread Christian Weisgerber
On 2014-04-19, Henning Brauer lists-openbsdt...@bsws.de wrote: we're in the same boat here - it's ust that I don't care too much either way (both of us) doesn't really help in taking a decision :/ Well, in that case I suggest that we remove this hack from all drivers that have it. A network

Re: help needed from someone with an sk(4)

2014-04-18 Thread Henning Brauer
so, what are we doing with this now? I still want to hide in_cksum_phdr() and kill in_cksum_addword() so that nobody ever uses that sh*t again. yes, sk loses is half-baked cksum offload support with this, as discussed before. as naddy pointed out there are (at least) two private copies of

Re: help needed from someone with an sk(4)

2014-02-05 Thread Henning Brauer
* David Higgs hig...@gmail.com [2014-01-25 18:25]: On Jan 25, 2014, at 12:48 AM, David Higgs hig...@gmail.com wrote: On Fri, Jan 24, 2014 at 4:24 AM, Henning Brauer lists-openbsdt...@bsws.de wrote: * Henning Brauer lists-openbsdt...@bsws.de [2014-01-24 05:50]: i need this tested on an

Re: help needed from someone with an sk(4)

2014-01-26 Thread Geoff Steckel
On 01/24/2014 02:09 PM, Henning Brauer wrote: * Ted Unangst t...@tedunangst.com [2014-01-24 17:48]: Are people still using sk, gem, or hme (!) in pps performance critical situations? doesn't make sense to do so, and hasn't in a long time... Performance critical? Well, given the pathetic

Re: help needed from someone with an sk(4)

2014-01-24 Thread Henning Brauer
* Henning Brauer lists-openbsdt...@bsws.de [2014-01-24 05:50]: i need this tested on an sk(4). I don't have that hardware at all. this gets rif od a slight little bit more. Index: netinet/in.h === RCS file:

Re: help needed from someone with an sk(4)

2014-01-24 Thread Christian Weisgerber
Henning Brauer lists-openbsdt...@bsws.de wrote: i need this tested on an sk(4). I don't have that hardware at all. [Summary: Henning wants to confine in_cksum_phdr() to ip_output.c and remove its only other user sk_rxcsum().] This is an instance of a very rudimentary RX checksumming engine

Re: help needed from someone with an sk(4)

2014-01-24 Thread Ted Unangst
On Fri, Jan 24, 2014 at 16:27, Christian Weisgerber wrote: Henning Brauer lists-openbsdt...@bsws.de wrote: i need this tested on an sk(4). I don't have that hardware at all. [Summary: Henning wants to confine in_cksum_phdr() to ip_output.c and remove its only other user sk_rxcsum().]

Re: help needed from someone with an sk(4)

2014-01-24 Thread Henning Brauer
* Ted Unangst t...@tedunangst.com [2014-01-24 17:48]: On Fri, Jan 24, 2014 at 16:27, Christian Weisgerber wrote: Henning Brauer lists-openbsdt...@bsws.de wrote: i need this tested on an sk(4). I don't have that hardware at all. [Summary: Henning wants to confine in_cksum_phdr() to

Re: help needed from someone with an sk(4)

2014-01-24 Thread David Higgs
On Fri, Jan 24, 2014 at 4:24 AM, Henning Brauer lists-openbsdt...@bsws.de wrote: * Henning Brauer lists-openbsdt...@bsws.de [2014-01-24 05:50]: i need this tested on an sk(4). I don't have that hardware at all. this gets rif od a slight little bit more. Resurrected an old box, kernel

help needed from someone with an sk(4)

2014-01-23 Thread Henning Brauer
i need this tested on an sk(4). I don't have that hardware at all. Index: dev/pci/if_sk.c === RCS file: /cvs/src/sys/dev/pci/if_sk.c,v retrieving revision 1.167 diff -u -p -r1.167 if_sk.c --- dev/pci/if_sk.c 28 Dec 2013 03:36:25