Henning Brauer <[email protected]> wrote: > i need this tested on an sk(4). > I don't have that hardware at all. [Summary: Henning wants to confine in_cksum_phdr() to ip_output.c and remove its only other user sk_rxcsum().]
This is an instance of a very rudimentary RX checksumming engine that only runs over the payload and we have to supply the pseudo-header checksum. Apart from sk(4), there are other drivers in the tree that have more or less the same code: gem(4) and the two instances of hme(4). Instead of calling in_cksum_phdr() they have their own inline implementation, though. If we want to confine in_cksum_phdr() to ip_output(), we could copy the other drivers' code over to sk(4). That sounds more like we should do the reverse, though: use in_cksum_phdr() in those other places as well. Whatever we do, it should be consistent. -- Christian "naddy" Weisgerber [email protected]
