On 12/10/15(Mon) 22:29, Alexandr Nedvedicky wrote:
> Hello,
>
> Richard Procter came back to me in private email with one more nit to fix:
>
> we can get rid of
>
> if (sn->rule.ptr != NULL)
> test condition in pfioctl() function as well.
>
> The relevant snippet looks as
On Mon, Oct 12, 2015 at 22:29 +0200, Alexandr Nedvedicky wrote:
> Hello,
>
> Richard Procter came back to me in private email with one more nit to fix:
>
> we can get rid of
>
> if (sn->rule.ptr != NULL)
> test condition in pfioctl() function as well.
>
> The relevant
On 10/10/15(Sat) 20:02, Alexandr Nedvedicky wrote:
> Hello,
>
> Patch fixes two small nits related to source node table in PF (a.k.a.
> pf_src_tree_tracking).
>
> The first issue comes to `global` argument of pf_insert_src_node(). It is
> always 0 everywhere in source code. The `global` is
Hello,
The updated patch addresses additional nit found by mpi:
> > Here can't you also change:
> >
> > if ((*sn)->rule.ptr != NULL)
> > (*sn)->rule.ptr->src_nodes++;
> >
> > into:
> >
> > (*sn)->rule.ptr->src_nodes++;
> >
> > I don't know enough to
On 10 October 2015 at 20:02, Alexandr Nedvedicky
wrote:
> Hello,
>
> Patch fixes two small nits related to source node table in PF (a.k.a.
> pf_src_tree_tracking).
>
> The first issue comes to `global` argument of pf_insert_src_node(). It is
> always 0 everywhere
On Mon, Oct 12, 2015 at 11:13 +0200, Martin Pieuchot wrote:
> On 10/10/15(Sat) 20:02, Alexandr Nedvedicky wrote:
> > Hello,
> >
> > Patch fixes two small nits related to source node table in PF (a.k.a.
> > pf_src_tree_tracking).
> >
> > The first issue comes to `global` argument of
Hello,
Richard Procter came back to me in private email with one more nit to fix:
we can get rid of
if (sn->rule.ptr != NULL)
test condition in pfioctl() function as well.
The relevant snippet looks as follows:
2188 p = psn->psn_src_nodes;
2189
Hello,
Patch fixes two small nits related to source node table in PF (a.k.a.
pf_src_tree_tracking).
The first issue comes to `global` argument of pf_insert_src_node(). It is
always 0 everywhere in source code. The `global` is supposed to indicate
whether particular state is bound to global/main