Re: pcb inet6ctlerrmap

2018-09-12 Thread Claudio Jeker
On Wed, Sep 12, 2018 at 01:08:35PM +0200, Alexander Bluhm wrote: > On Wed, Sep 12, 2018 at 09:01:41AM +0200, Claudio Jeker wrote: > > Why u_char instead of int? The errors in that list are used in errno which > > is an int. So my usual feeling is to use the type which is naturally used > > and

Re: pcb inet6ctlerrmap

2018-09-12 Thread Alexander Bluhm
On Wed, Sep 12, 2018 at 09:01:41AM +0200, Claudio Jeker wrote: > Why u_char instead of int? The errors in that list are used in errno which > is an int. So my usual feeling is to use the type which is naturally used > and don't try to optimize for space. Basically I want to have it the same for

Re: pcb inet6ctlerrmap

2018-09-12 Thread Claudio Jeker
On Tue, Sep 11, 2018 at 06:12:03PM +0200, Alexander Bluhm wrote: > On Sun, Sep 09, 2018 at 09:53:59PM +0200, Alexander Bluhm wrote: > > My goal is to get in6_pcb and in_pcb in sync. > > > > Let's make both inetctlerrmap and inet6ctlerrmap u_char. That is > > what FreeBSD does. There it is also

Re: pcb inet6ctlerrmap

2018-09-11 Thread Alexander Bluhm
On Sun, Sep 09, 2018 at 09:53:59PM +0200, Alexander Bluhm wrote: > My goal is to get in6_pcb and in_pcb in sync. > > Let's make both inetctlerrmap and inet6ctlerrmap u_char. That is > what FreeBSD does. There it is also in in6?_input.c. > > FreeBSD and NetBSD have the declaration in

pcb inet6ctlerrmap

2018-09-09 Thread Alexander Bluhm
Hi, My goal is to get in6_pcb and in_pcb in sync. Let's make both inetctlerrmap and inet6ctlerrmap u_char. That is what FreeBSD does. There it is also in in6?_input.c. FreeBSD and NetBSD have the declaration in in6?_var.h, we have it in in6?.h, but I don't bother enough to move it. ok?