Re: pwd_check tweak

2018-12-10 Thread Theo de Raadt
Stuart Henderson wrote: > On 2018/12/10 06:49, Sebastien Marie wrote: > > On Sun, Dec 09, 2018 at 09:14:38PM -0500, Ted Unangst wrote: > > > These patterns try to detect a1a1a1 style passwords. By making the regex > > > a bit > > > more flexible we can just use one. Also now catches mMmMmM

Re: pwd_check tweak

2018-12-10 Thread Stuart Henderson
On 2018/12/10 06:49, Sebastien Marie wrote: > On Sun, Dec 09, 2018 at 09:14:38PM -0500, Ted Unangst wrote: > > These patterns try to detect a1a1a1 style passwords. By making the regex a > > bit > > more flexible we can just use one. Also now catches mMmMmM fwiw. > > it will also catches any

Re: pwd_check tweak

2018-12-10 Thread Theo de Raadt
This seems to substantially reduce the search space, so who is it actually helping? > These patterns try to detect a1a1a1 style passwords. By making the regex a bit > more flexible we can just use one. Also now catches mMmMmM fwiw. > > > Index: pwd_check.c >

Re: pwd_check tweak

2018-12-09 Thread Sebastien Marie
On Sun, Dec 09, 2018 at 09:14:38PM -0500, Ted Unangst wrote: > These patterns try to detect a1a1a1 style passwords. By making the regex a bit > more flexible we can just use one. Also now catches mMmMmM fwiw. it will also catches any password composed of only letters and digits from 2 to 8 chars

pwd_check tweak

2018-12-09 Thread Ted Unangst
These patterns try to detect a1a1a1 style passwords. By making the regex a bit more flexible we can just use one. Also now catches mMmMmM fwiw. Index: pwd_check.c === RCS file: /cvs/src/usr.bin/passwd/pwd_check.c,v retrieving