Re: rt_ifp and pf(4)

2015-11-22 Thread Alexandr Nedvedicky
On Sat, Nov 21, 2015 at 12:37:58PM +0100, Martin Pieuchot wrote: > On 20/11/15(Fri) 18:05, Alexandr Nedvedicky wrote: > > Hello, > > > > I have just nit comments, feel free to ignore them. > > > > 1) would it be possible to use closing #endif guards as follows: > > #endif /* NCARP */ > >

Re: rt_ifp and pf(4)

2015-11-21 Thread Martin Pieuchot
On 20/11/15(Fri) 18:05, Alexandr Nedvedicky wrote: > Hello, > > I have just nit comments, feel free to ignore them. > > 1) would it be possible to use closing #endif guards as follows: > #endif /* NCARP */ Done. > 2) another nit here: > > @@ -5607,6 +5616,8 @@ pf_route(struct mbuf **m,

Re: rt_ifp and pf(4)

2015-11-20 Thread Alexandr Nedvedicky
Hello, I have just nit comments, feel free to ignore them. 1) would it be possible to use closing #endif guards as follows: #endif /* NCARP */ 2) another nit here: > @@ -5607,6 +5616,8 @@ pf_route(struct mbuf **m, struct pf_rule > done: > if (r->rt != PF_DUPTO) >

rt_ifp and pf(4)

2015-11-19 Thread Martin Pieuchot
Stop using rt_ifp. While here put some NCARP... ok? Index: net/pf.c === RCS file: /cvs/src/sys/net/pf.c,v retrieving revision 1.950 diff -u -p -r1.950 pf.c --- net/pf.c12 Nov 2015 10:07:14 - 1.950 +++ net/pf.c19 Nov