Re: unwind(8): forget learned forwarders when interface disappears

2020-09-12 Thread Florian Obser
On Sat, Sep 12, 2020 at 08:13:43PM +0300, Peter Pentchev wrote: > On Sat, Sep 12, 2020 at 06:58:30PM +0200, Florian Obser wrote: > > On Sat, Sep 12, 2020 at 05:15:08PM +0200, Klemens Nanni wrote: > > > On Sat, Sep 12, 2020 at 05:11:00PM +0200, Klemens Nanni wrote: > > > > Bit hard to read, what

Re: unwind(8): forget learned forwarders when interface disappears

2020-09-12 Thread Peter Pentchev
On Sat, Sep 12, 2020 at 06:58:30PM +0200, Florian Obser wrote: > On Sat, Sep 12, 2020 at 05:15:08PM +0200, Klemens Nanni wrote: > > On Sat, Sep 12, 2020 at 05:11:00PM +0200, Klemens Nanni wrote: > > > Bit hard to read, what about aligning like this? > > > > > > + if ((rdns_proposal->src

Re: unwind(8): forget learned forwarders when interface disappears

2020-09-12 Thread Florian Obser
On Sat, Sep 12, 2020 at 05:15:08PM +0200, Klemens Nanni wrote: > On Sat, Sep 12, 2020 at 05:11:00PM +0200, Klemens Nanni wrote: > > Bit hard to read, what about aligning like this? > > > > + if ((rdns_proposal->src == 0 || > > +rdns_proposal->src == tmp->src) && > > +

Re: unwind(8): forget learned forwarders when interface disappears

2020-09-12 Thread Klemens Nanni
On Sat, Sep 12, 2020 at 05:11:00PM +0200, Klemens Nanni wrote: > Bit hard to read, what about aligning like this? > > + if ((rdns_proposal->src == 0 || > + rdns_proposal->src == tmp->src) && > + (rdns_proposal->if_index == 0 || > +

Re: unwind(8): forget learned forwarders when interface disappears

2020-09-12 Thread Klemens Nanni
On Sat, Sep 12, 2020 at 04:36:28PM +0200, Florian Obser wrote: > ... say if you pull a usb stick. ...or if you play with^W^Wrecreate your trunk0 { em0 athn0 } uplink without checking unwind. Without this diff, unwind cannot recover; with it, stuff just works for me across destroy/create. OK kn

unwind(8): forget learned forwarders when interface disappears

2020-09-12 Thread Florian Obser
... say if you pull a usb stick. OK? diff --git frontend.c frontend.c index 87141f81e8c..b92cde8226c 100644 --- frontend.c +++ frontend.c @@ -913,8 +913,21 @@ handle_route_message(struct rt_msghdr *rtm, struct sockaddr **rti_info) { struct imsg_rdns_proposalrdns_proposal;