Re: improving OpenBSD's gmac.c...

2014-10-13 Thread Christian Weisgerber
David Gwynne: dont you need endian.h to get bemtoh64 and htobem64? I went by the man page, which says sys/types.h. PS: I accidentally omitted a chunk: Index: sys/conf/files === RCS file: /cvs/src/sys/conf/files,v retrieving

Re: ps: remove redundant prototype

2014-10-13 Thread Ingo Schwarze
Hi, Martin Natano wrote on Sun, Oct 12, 2014 at 07:52:47PM +0200: The findvar() function in keyword.c contains a prototype of the vcmp() function, which is already declared further up in the same file. I'm not even sure that prototype is correct, as it fails to include the 'static'

Re: improving OpenBSD's gmac.c...

2014-10-13 Thread David Gwynne
On 13 Oct 2014, at 9:00 pm, Christian Weisgerber na...@mips.inka.de wrote: David Gwynne: dont you need endian.h to get bemtoh64 and htobem64? I went by the man page, which says sys/types.h. and cvs blame says that's my fault... fair enough. ill talk to philip about whether that should

share/mk/bsd.README: bsd.prog.mk only has seven targets

2014-10-13 Thread Theo Buehler
This confused me quite a bit when I first read it. After lint was unhooked from the tree, there remain only seven targets in bsd.prog.mk: all, clean, cleandir, depend, includes, install, and tags. Same goes for bsd.subdir.mk and bsd.lib.mk. Index: bsd.README

Re: increase netcat's buffer...

2014-10-13 Thread Arne Becker
Hi again. +/* make all fds non-blocking */ +for (n = 0; n 4; n++) { +if (pfd[n].fd == -1) +continue; +flags = fcntl(pfd[n].fd, F_GETFL, 0); +/* + * For sockets and pipes, we want non-block, but setting it +

mention lkm removal on current.html

2014-10-13 Thread Theo Buehler
/V4_to_v5_migration_guide;upgrade guide/a to migrate their existing setups. +a name=20141013/a +h32014/10/13 - lkm removed/h3 +The lkm interface has been removed, thus several binaries and manual pages +and the lkm directory should be deleted: +pre + rm -rf /usr/lkm + + rm -f /usr/bin/modstat + rm

Remove lkm tendrils from bsd.own.mk

2014-10-13 Thread Theo Buehler
After lkm is gone, these should probably also be removed. Index: bsd.own.mk === RCS file: /cvs/src/share/mk/bsd.own.mk,v retrieving revision 1.150 diff -u -p -r1.150 bsd.own.mk --- bsd.own.mk 22 Apr 2014 14:42:53 - 1.150

Re: mention lkm removal on current.html

2014-10-13 Thread Stuart Henderson
On 2014/10/13 14:56, Theo Buehler wrote: Here's a shot at removing the binaries and manuals that are obsolete after the lkm removal. I hope I caught them all. Thanks, committed. There remains the user _lkm in /etc/groups. I am unsure how to remove that one properly. It should just be like

Re: mention lkm removal on current.html

2014-10-13 Thread David Coppa
On Mon, Oct 13, 2014 at 3:22 PM, Stuart Henderson st...@openbsd.org wrote: On 2014/10/13 14:56, Theo Buehler wrote: Here's a shot at removing the binaries and manuals that are obsolete after the lkm removal. I hope I caught them all. Thanks, committed. There remains the user _lkm in

Re: share/mk/bsd.README: bsd.prog.mk only has seven targets

2014-10-13 Thread Ingo Schwarze
Hi Theo, Theo Buehler wrote on Mon, Oct 13, 2014 at 02:45:53PM +0200: This confused me quite a bit when I first read it. After lint was unhooked from the tree, there remain only seven targets in bsd.prog.mk: all, clean, cleandir, depend, includes, install, and tags. Same goes for

Re: ps: remove redundant prototype

2014-10-13 Thread Ingo Schwarze
Hi Martin, Martin Natano wrote on Sun, Oct 12, 2014 at 07:52:47PM +0200: The findvar() function in keyword.c contains a prototype of the vcmp() function, which is already declared further up in the same file. I'm not even sure that prototype is correct, as it fails to include the 'static'

Re: em(4) fix for Intel I218 chip

2014-10-13 Thread Brad Smith
On 12/10/14 3:53 PM, Claudio Jeker wrote: This seems to be enough to help em(4) in modern laptops like the X240 to no longer generate watchdog timeouts on high throughput. This should only affect I218 but tests on different em(4) devices would not hurt. Chunk #3 is within the ICH8/IGP3

vi: remove bitstring.h copy

2014-10-13 Thread Martin Natano
The vi editor includes its own (outdated) copy of bitstring.h. It can safely be removed; the binary doesn't change. cheers, natano --- usr.bin/vi/LAYOUT 29 Jan 2001 01:58:24 - 1.4 +++ usr.bin/vi/LAYOUT 13 Oct 2014 19:12:53 - @@ -103,7 +103,6 @@ include/ Replacement

vi: remove obsolete headers, documentation cleanup

2014-10-13 Thread Martin Natano
There are some left-over (unused) header files from removed components in vi. The following patch deletes them and cleans up the documentation to remove references to these components. No binary change. cheers, natano --- Index: LAYOUT

rcctl: find(1) service files in /etc/rc.d

2014-10-13 Thread Craig R. Skinner
Move 2 duplicate searches into a function. The diff also ignores (RCS) subdirectories. $ find /etc/rc.d ! -type f /etc/rc.d /etc/rc.d/RCS Index: rcctl.sh === RCS file: /cvs/src/usr.sbin/rcctl/rcctl.sh,v retrieving revision 1.43

Re: improving OpenBSD's gmac.c...

2014-10-13 Thread Philip Guenther
On Mon, Oct 13, 2014 at 5:26 AM, David Gwynne da...@gwynne.id.au wrote: On 13 Oct 2014, at 9:00 pm, Christian Weisgerber na...@mips.inka.de wrote: David Gwynne: dont you need endian.h to get bemtoh64 and htobem64? (This is kernel code, so that would be sys/endian.h) I went by the man

[patch]rcs: memcmp against 0

2014-10-13 Thread Fritjof Bornebusch
Hi, it's better to compare memcmp against 0, for clarity. fritjof Index: diff3.c === RCS file: /cvs/src/usr.bin/rcs/diff3.c,v retrieving revision 1.33 diff -u -p -r1.33 diff3.c --- diff3.c 4 Mar 2012 04:05:15 - 1.33

Re: em(4) fix for Intel I218 chip

2014-10-13 Thread Claudio Jeker
On Mon, Oct 13, 2014 at 01:50:45PM -0400, Brad wrote: On 12/10/14 3:53 PM, Claudio Jeker wrote: This seems to be enough to help em(4) in modern laptops like the X240 to no longer generate watchdog timeouts on high throughput. This should only affect I218 but tests on different em(4) devices

Re: rcctl: find(1) service files in /etc/rc.d

2014-10-13 Thread Antoine Jacoutot
On Mon, Oct 13, 2014 at 09:31:05PM +0100, Craig R. Skinner wrote: Move 2 duplicate searches into a function. The diff also ignores (RCS) subdirectories. $ find /etc/rc.d ! -type f /etc/rc.d /etc/rc.d/RCS Makes sense yes. Not sure I'd want a function just for that one liner though. I'll

Re: em(4) fix for Intel I218 chip

2014-10-13 Thread Brad Smith
On 13/10/14 5:09 PM, Claudio Jeker wrote: On Mon, Oct 13, 2014 at 01:50:45PM -0400, Brad wrote: On 12/10/14 3:53 PM, Claudio Jeker wrote: This seems to be enough to help em(4) in modern laptops like the X240 to no longer generate watchdog timeouts on high throughput. This should only affect

Re: Brainy: OpenSSH Memory Leak

2014-10-13 Thread Daniel Dickman
On Sat, Sep 20, 2014 at 3:07 PM, Maxime Villard m...@m00nbsd.net wrote: Hi, I put here a bug among others: Index: ssh-ed25519.c === RCS file: /cvs/src/usr.bin/ssh/ssh-ed25519.c,v retrieving revision 1.4 diff -u -r1.4

Re: LibreSSL 2.1.0 released.

2014-10-13 Thread Bob Beck
normally tech@openbsd.org would be the place to start contributing. If you have fixes, post diffs there. On Sun, Oct 12, 2014 at 9:26 PM, Jiri Navratil j...@navratil.cz wrote: Sun, Oct 12, 2014 at 07:36:02PM CEST, b...@openbsd.org napsal(a): We have released LibreSSL 2.1.0 - which should be