Re: Fix begin of word bug in ed

2016-07-19 Thread Theo de Raadt
> If you feel bold, you can still put it in for 6.0, it's a bugfix > after all, and i don't consider it very dangerous. Then again, > if you want to be extra cautious, nothing would be wrong with > waiting until after unlock, either. that's the right attitude. Around at least every 4-5 hours

relayd TLS session caching

2016-07-19 Thread Claudio Jeker
At the moment relayd's TLS session caching is a bit busted because the multiple relay processes do not share state. The following diff adds SSL session caching and sharing of the TLS ticket secrets. Which this openssl s_client -connect W.X.Y.Z:443 -reconnect reuses the connection after the first

Re: clarity recommendation for faq15.html

2016-07-19 Thread ludovic coues
faq4.html [1] already deal with the problem. [1] http://www.openbsd.org/faq/faq4.html#AddThoughts 2016-07-19 3:29 GMT+02:00 Josh Grosse : > I had a conversation with a new OpenBSD user who thought that he > may have either misunderstood or been misled by the guidance to

Re: relayd TLS session caching

2016-07-19 Thread Philip Guenther
On Tue, 19 Jul 2016, Sebastian Benoit wrote: > maybe session cache disable should disable tickets too. Well, what problem are you trying to solve by offering that option? If it's to save memory, because original-flavor session caching requires state and overhead on the server, then you should

Re: relayd TLS session caching

2016-07-19 Thread Sebastian Benoit
maybe session cache disable should disable tickets too. some little things below, otherwise ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2016.07.19 15:32:13 +0200: > At the moment relayd's TLS session caching is a bit busted because > the multiple relay processes do not share state. > The

syn cache hash size sysctl

2016-07-19 Thread Alexander Bluhm
Hi, claudio@ suggested to have a tunable size for the syn cache hash array. As we are swapping between two syn caches for random reseeding anyway, this feature can be added easily. When the cache is empty, we can change the hash size. This allows an admin under SYN flood attack to tune his

Re: syn cache hash size sysctl

2016-07-19 Thread Joerg Jung
On Tue, Jul 19, 2016 at 06:13:42PM +0200, Alexander Bluhm wrote: > Hi, > > claudio@ suggested to have a tunable size for the syn cache hash > array. As we are swapping between two syn caches for random reseeding > anyway, this feature can be added easily. When the cache is empty, > we can

arm/pmap7 _enter and PV_BEEN_xD()

2016-07-19 Thread Artturi Alm
Hi, #define PV_BEEN_EXECD(f) (((f) & (PVF_REF | PVF_EXEC)) == (PVF_REF | PVF_EXEC)) #define PV_BEEN_REFD(f) (((f) & PVF_REF) != 0) and from pmap.h: * The PVF_MOD and PVF_REF flags are stored in the mdpage for each * page. PVF_WIRED, PVF_WRITE, and PVF_NC are kept in individual *

Re: syn cache hash size sysctl

2016-07-19 Thread Joerg Jung
> Am 19.07.2016 um 23:16 schrieb Alexander Bluhm : > >> On Tue, Jul 19, 2016 at 09:48:19PM +0100, Jason McIntyre wrote: >> oh oh. i should have been clearer: they are sorted in sysctl(3), but in >> sysctl(8) they are merely listed in the order that running "sysctl" >>

Re: syn cache hash size sysctl

2016-07-19 Thread Alexander Bluhm
On Tue, Jul 19, 2016 at 09:19:25PM +0100, Jason McIntyre wrote: > On Tue, Jul 19, 2016 at 10:09:47PM +0200, Alexander Bluhm wrote: > > On Tue, Jul 19, 2016 at 08:55:58PM +0200, Joerg Jung wrote: > > > Please, also document it, at least in sysctl(8). Next try, with input from jmc@ bluhm Index:

Re: syn cache hash size sysctl

2016-07-19 Thread Claudio Jeker
On Tue, Jul 19, 2016 at 10:40:14PM +0200, Alexander Bluhm wrote: > On Tue, Jul 19, 2016 at 09:19:25PM +0100, Jason McIntyre wrote: > > On Tue, Jul 19, 2016 at 10:09:47PM +0200, Alexander Bluhm wrote: > > > On Tue, Jul 19, 2016 at 08:55:58PM +0200, Joerg Jung wrote: > > > > Please, also document

Re: syn cache hash size sysctl

2016-07-19 Thread Alexander Bluhm
On Tue, Jul 19, 2016 at 08:55:58PM +0200, Joerg Jung wrote: > Please, also document it, at least in sysctl(8). like this? bluhm Index: lib/libc/gen/sysctl.3 === RCS file: /data/mirror/openbsd/cvs/src/lib/libc/gen/sysctl.3,v

Re: tcp output mbuf leak

2016-07-19 Thread Claudio Jeker
On Tue, Jul 19, 2016 at 11:00:04PM +0200, Alexander Bluhm wrote: > Hi, > > When looking at the error paths in tcp_output() I have found these > returns that look like mbuf leaks. > > ok? Indeed. OK claudio@ Looking at tcp_signature() I actually think it can not fail but better safe than sorry.

Re: syn cache hash size sysctl

2016-07-19 Thread Alexander Bluhm
On Tue, Jul 19, 2016 at 09:48:19PM +0100, Jason McIntyre wrote: > oh oh. i should have been clearer: they are sorted in sysctl(3), but in > sysctl(8) they are merely listed in the order that running "sysctl" > dumps them. so no sort neccessary for sysctl(8). So now sysctl(8) has all net.inet.tcp

tcp output mbuf leak

2016-07-19 Thread Alexander Bluhm
Hi, When looking at the error paths in tcp_output() I have found these returns that look like mbuf leaks. ok? bluhm Index: netinet/tcp_output.c === RCS file: /data/mirror/openbsd/cvs/src/sys/netinet/tcp_output.c,v retrieving

Re: tcp output mbuf leak

2016-07-19 Thread Mike Belopuhov
On 19 July 2016 at 23:00, Alexander Bluhm wrote: > Hi, > > When looking at the error paths in tcp_output() I have found these > returns that look like mbuf leaks. > > ok? > > bluhm > looks correct indeed. ok mikeb