Re: pfctl: make functions return void, merge two ifs

2017-06-16 Thread Adam Wolk
On Tue, Jun 13, 2017 at 12:43:51AM +0200, Adam Wolk wrote: > On Mon, Jun 12, 2017 at 11:43:44PM +0200, Alexandr Nedvedicky wrote: > > Hello Adam, > > > > > > > > > It was a rainy evening here, so here's the updated pfctl diff. > > > > I'm sorry to hear about the rainy weather [1]. > >

Re: m4(1): Don't need to link with -ly

2017-06-16 Thread Todd C. Miller
On Fri, 16 Jun 2017 16:22:15 -0400, Brian Callahan wrote: > m4 links with -ly, presumably for the yyerror() function. > But there already is a yyerror() in usr.bin/m4/expr.c, which is > written specifically for m4. So we don't need -ly. OK, but if you want to remove -ll as well you could do

Re: wsfont: remove iso7/pcvt encoding macros and entries

2017-06-16 Thread Frederic Cambus
On Thu, Jun 15, 2017 at 01:52:07PM +0200, Frederic Cambus wrote: > On Tue, Jun 13, 2017 at 11:29:59AM +, Miod Vallat wrote: > > > > > Hi tech@, > > > > > > We do not support iso7 nor pcvt encoding, so remove macro definitions > > > and commented entries. > > > > If you do that, then you can

m4(1): Don't need to link with -ly

2017-06-16 Thread Brian Callahan
Hi tech -- m4 links with -ly, presumably for the yyerror() function. But there already is a yyerror() in usr.bin/m4/expr.c, which is written specifically for m4. So we don't need -ly. OK? ~Brian Index: Makefile === RCS file:

Re: viocon.4: mention all ttyVI devices

2017-06-16 Thread Jason McIntyre
On Sun, Jun 11, 2017 at 09:43:17PM +0200, Michal Mazurek wrote: > There are 5 devices in /dev/. Is there any reason why just two are > listed in the viocon.4 manpage? > > OK to mention them all? > evening. i haven;t seen anyone pick up on this. if no one has (reasonably) objected, please go

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Larkin
On Fri, Jun 16, 2017 at 11:09:01PM +1000, Jonathan Gray wrote: > On Fri, Jun 16, 2017 at 02:23:36PM +0200, Mike Belopuhov wrote: > > On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > > > Index: arch/i386/include/cpufunc.h > > >

Re: smtpd session hang

2017-06-16 Thread adam . wolk
On Fri, Jun 16, 2017 at 07:12:43PM +0300, Henri Kemppainen wrote: > > > Nice catch, the diff reads fine to me, I'll commit later today when I > > > have another ok from eric@ > > > Yes, this looks correct. But, I would rather move the resume test before > > the EOM test, to avoid touching the

Re: smtpd session hang

2017-06-16 Thread Henri Kemppainen
> > Nice catch, the diff reads fine to me, I'll commit later today when I > > have another ok from eric@ > Yes, this looks correct. But, I would rather move the resume test before > the EOM test, to avoid touching the session after the transfer has been > finalized by smtp_data_io_done(). It

Re: Add pledge(2) for rebound(8)'s parent proc

2017-06-16 Thread Ricardo Mestre
Ugh! :\ You're right, and that sysctl is not allowed by pledge(2). Please disregard this diff. On 18:00 Fri 16 Jun , Sebastien Marie wrote: > On Fri, Jun 16, 2017 at 03:53:09PM +0100, Ricardo Mestre wrote: > > Hi tech@ > > > > rebound(8)'s parent proc doesn't seem to need much permissions

Re: Add pledge(2) for rebound(8)'s parent proc

2017-06-16 Thread Sebastien Marie
On Fri, Jun 16, 2017 at 03:53:09PM +0100, Ricardo Mestre wrote: > Hi tech@ > > rebound(8)'s parent proc doesn't seem to need much permissions to do what it > needs, here is the pledge for the parent for the following promises: > > rpath: reload the configuration at reexec time (see below) >

Add pledge(2) for rebound(8)'s parent proc

2017-06-16 Thread Ricardo Mestre
Hi tech@ rebound(8)'s parent proc doesn't seem to need much permissions to do what it needs, here is the pledge for the parent for the following promises: rpath: reload the configuration at reexec time (see below) proc/exec: needed to reexec itself and kill child if needed Comments? OK? Index:

net80211: initialize link state during attach

2017-06-16 Thread Stefan Sperling
Set the link state of wifi interfaces to DOWN at attach time instead of leaving it as UNKNOWN which userland cannot really make use of (e.g. dhclient interprets UNKNOWN as UP). Link state is also reset by the ieee80211_newstate() function. However, that function is usually called by the

Re: smtpd session hang

2017-06-16 Thread Eric Faurot
On Fri, Jun 16, 2017 at 09:11:29AM +0200, Gilles Chehade wrote: > On Fri, Jun 16, 2017 at 01:05:25AM +0300, Henri Kemppainen wrote: > > I had a little debugging session with awolk@ over at #openbsd-daily. His > > smtpd would over time end up with hung sessions that never timeout. > > > > The

remove redundant flag from iwm(4)

2017-06-16 Thread Stefan Sperling
The HW_INITED flag has a grammatically dubious name and is unnecessary because it duplicates the purpose of the IFF_RUNNING flag. ok? Index: sys/dev/pci/if_iwm.c === RCS file: /cvs/src/sys/dev/pci/if_iwm.c,v retrieving revision

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 10:25 +0200, Mike Belopuhov wrote: > Last time I've tried uebayashi's pvclock on Xen, it didn't > work for me. I didn't have time to investigate why but > probably because we need per-cpu readings. Which you do > for KVM. I'll test this on Xen as soon as I get to the >

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 23:09 +1000, Jonathan Gray wrote: > On Fri, Jun 16, 2017 at 02:23:36PM +0200, Mike Belopuhov wrote: > > On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > > > Index: arch/i386/include/cpufunc.h > > >

Re: faster timecounters for kvm/xen

2017-06-16 Thread Jonathan Gray
On Fri, Jun 16, 2017 at 02:23:36PM +0200, Mike Belopuhov wrote: > On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > > Index: arch/i386/include/cpufunc.h > > === > > RCS file: /cvs/src/sys/arch/i386/include/cpufunc.h,v > >

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > Index: arch/i386/include/cpufunc.h > === > RCS file: /cvs/src/sys/arch/i386/include/cpufunc.h,v > retrieving revision 1.25 > diff -u -p -u -p -r1.25 cpufunc.h > ---

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 10:25 +0200, Mike Belopuhov wrote: > I don't know if it's a good idea to depend on Xen's > definition of vcpu_time_info. I think I have factored > it out into the pvclock_time_info and put it into the > pvclockvar.h or something like that. And then made Xen > use those

Re: faster timecounters for kvm/xen

2017-06-16 Thread Mike Belopuhov
On Fri, Jun 16, 2017 at 16:31 +1000, Jonathan Matthew wrote: > Recently I updated the kernel lock profiling stuff I've been working on, since > it had been rotting a bit since witness was introduced. Running my diff on a > KVM VM, I found there was a pretty huge performance impact (10 minutes to

Re: smtpd session hang

2017-06-16 Thread Gilles Chehade
On Fri, Jun 16, 2017 at 01:05:25AM +0300, Henri Kemppainen wrote: > I had a little debugging session with awolk@ over at #openbsd-daily. His > smtpd would over time end up with hung sessions that never timeout. > > The problem is related to the data_io path's congestion control which > may pause

faster timecounters for kvm/xen

2017-06-16 Thread Jonathan Matthew
Recently I updated the kernel lock profiling stuff I've been working on, since it had been rotting a bit since witness was introduced. Running my diff on a KVM VM, I found there was a pretty huge performance impact (10 minutes to build a kernel instead of 4), which turned out to be because