Re: ksh: skip long history lines

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.19 00:22:51 +0200: > > Hi Ori, > > thanks for your feedback. Reply and updated diff below, > > On Wed, Oct 18 2017, Ori Bernstein wrote: > > On Wed, 18 Oct 2017 22:33:51 +0200 > > Jeremie Courreges-Anglas

Re: if_ioctl is not NULL

On Wed, Oct 18, 2017 at 01:42:57PM +0200, Martin Pieuchot wrote: > All are drivers provides it and if_attach() now asserts that it is not > NULL. > > Let's get rid of those checks, ok? OK bluhm@ > Index: netinet/in.c > === > RCS

Re: Httpd support for internal redirects.

as a, well, co-author of some earlier attempt on this, the developers just do not interested in this. so we are left on our own to maintain this. as a side note my diff is more functional then your's as it provides a way to test  the existence of the filesystem object before rewrite happen.

Re: uninitialised variable crashes in bgpd config parser

OK claudio@ On Thu, Oct 19, 2017 at 04:34:35PM +1100, Jonathan Gray wrote: > Index: parse.y > === > RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v > retrieving revision 1.315 > diff -u -p -r1.315 parse.y > --- parse.y 21 Aug 2017

Re: ksh: remove the deprecated emacs-usemeta option

On Thu, Oct 19 2017, Sebastian Benoit wrote: > Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.18 22:16:48 +0200: >> >> This would make ''set -o emacs-usemeta'' a fatal error, which means that >> subsequent lines in your kshrc will not be run. I think people were >>

Re: ksh: extra rewind call

On Thu, Oct 19 2017, Sebastian Benoit wrote: > Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.19 00:36:00 +0200: >> >> This call was added along with the magic check, but it not actually >> needed: history_load already calls rewind(3). I feel like the magic >> check

Re: ksh: skip long history lines

On Wed, Oct 18 2017, Ori Bernstein wrote: > On Thu, 19 Oct 2017 00:22:51 +0200 > Jeremie Courreges-Anglas wrote: > >> Those variables are static so that error messages are only printed once >> in the shell lifetime. history reload happens each time the

Re: KAME ioctl leftovers

On Wed, Oct 18, 2017 at 01:34:27PM +0200, Martin Pieuchot wrote: > Kill ioctl(2) added with original KAME import that have never been used. > FreeBSD also stopped supporting them in 2013. > > ok? OK bluhm@ > Index: sys/sockio.h >

Re: ksh: extra rewind call

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.19 00:36:00 +0200: > > This call was added along with the magic check, but it not actually > needed: history_load already calls rewind(3). I feel like the magic > check should also be in history_load(), so that a ksh process can > recover at

Re: tftpd(8): diff for ip path rewrite

On Wed, Oct 18 2017, Jan Klemkow wrote: > On Wed, Oct 18, 2017 at 08:37:48PM +, Jason McIntyre wrote: >> On Wed, Oct 18, 2017 at 10:25:13PM +0200, Jan Klemkow wrote: >> > This diff adds an option for client IP address path prefixes to the >> > tftpd(8). First, I used

Re: ksh: remove the deprecated emacs-usemeta option

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.18 22:16:48 +0200: > > This would make ''set -o emacs-usemeta'' a fatal error, which means that > subsequent lines in your kshrc will not be run. I think people were > given enough time to cope with this (6.2 users get a warning). > > ok? no

Re: cannot take the address of stdout

On Thu, Oct 19 2017, Jeremie Courreges-Anglas wrote: > When building an updated version of ports/security/polarssl, I hit the > following failure: > > [219/427] /usr/ports/pobj/mbedtls-2.6.0/bin/cc > -I/usr/ports/pobj/mbedtls-2.6.0/mbedtls-2.6.0/include >

Re: fix memory handling in acme-client config parser

OK florian@ On Thu, Oct 19, 2017 at 05:33:35AM +, Jonathan Gray wrote: > Use after free and a memory leak. > > Index: parse.y > === > RCS file: /cvs/src/usr.sbin/acme-client/parse.y,v > retrieving revision 1.17 > diff -u -p -U4

cannot take the address of stdout

When building an updated version of ports/security/polarssl, I hit the following failure: [219/427] /usr/ports/pobj/mbedtls-2.6.0/bin/cc -I/usr/ports/pobj/mbedtls-2.6.0/mbedtls-2.6.0/include -I/usr/ports/pobj/mbedtls-2.6.0/mbedtls-2.6.0/tests -O2 -pipe -Wall -Wextra -W

Re: uninitialised variable crashes in bgpd config parser

ok benno@ Jonathan Gray(j...@jsg.id.au) on 2017.10.19 16:34:35 +1100: > Index: parse.y > === > RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v > retrieving revision 1.315 > diff -u -p -r1.315 parse.y > --- parse.y 21 Aug 2017 14:41:22

Re: fix memory handling in acme-client config parser

sure ok benno@ Jonathan Gray(j...@jsg.id.au) on 2017.10.19 16:33:35 +1100: > Use after free and a memory leak. > > Index: parse.y > === > RCS file: /cvs/src/usr.sbin/acme-client/parse.y,v > retrieving revision 1.17 > diff -u -p -U4

Re: cannot take the address of stdout

> From: Jeremie Courreges-Anglas > Date: Thu, 19 Oct 2017 11:26:38 +0200 > > On Thu, Oct 19 2017, Jeremie Courreges-Anglas wrote: > > When building an updated version of ports/security/polarssl, I hit the > > following failure: > > > > [219/427]

Re: tftpd(8): diff for ip path rewrite

On Thu, Oct 19, 2017 at 09:36:50AM +, Jeremie Courreges-Anglas wrote: > On Wed, Oct 18 2017, Jan Klemkow wrote: > > On Wed, Oct 18, 2017 at 08:37:48PM +, Jason McIntyre wrote: > >> On Wed, Oct 18, 2017 at 10:25:13PM +0200, Jan Klemkow wrote: > >> > This diff adds an

iked: support multiple subjectAltNames

Hi, so far, even if we look for our own cert, we only match the id against the first subjectAltName. This means we cannot use certificates where we actually need a different one. This diff changes the behaviour so that we check all subjectAltNames of a given certificate. ok? Patrick diff

Re: tftpd(8): diff for ip path rewrite

On Thu, Oct 19, 2017 at 08:58:12PM +0200, Jan Klemkow wrote: > > Index: tftpd.c > === > RCS file: /mount/openbsd/cvs/src/usr.sbin/tftpd/tftpd.c,v > retrieving revision 1.39 > diff -u -p -r1.39 tftpd.c > --- tftpd.c 26 May 2017

Enable TCP selective acknowledgements (SACK) on all kernels

SACK has been enabled in GENERIC kernels for over a decade and it's time to make it an official part of the TCP stack. This grows bsd.rd on amd64 by 8k but Theo said it's within reasonable. OK? diff --git sys/conf/GENERIC sys/conf/GENERIC index 87dd069f514..cd68ae9e651 100644 ---

Re: tftpd(8): diff for ip path rewrite

On 2017/10/19 16:22, Theo de Raadt wrote: > I am always worried by non-intuitive magic behaviour. > > It may serve some obvious purposes, but for someone else it is going > to break things. > > I worry. The IP/filename -> filename fallback method seems good enough, but I agree with Theo. I

Re: tftpd(8): diff for ip path rewrite

I am always worried by non-intuitive magic behaviour. It may serve some obvious purposes, but for someone else it is going to break things. I worry. > bluhm@ suggested, that this should be the default behavior. Thus, the > ftpd(8) checks if a subdirectory with the client's ip address exists