Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Laurence Tratt
On Sun, Feb 02, 2020 at 04:45:53PM -0700, Theo de Raadt wrote: Hello Theo, >> When I passed that to openlog, and later called syslog, well, I was >> confused. I then distilled the example down to C. The Debian & GNU man >> pages suggest that I'm not the first person to try doing this. > That

Re: IPv6 Support for umb(4)

2020-02-03 Thread Gerhard Roth
So far I've got only one ok from job@ and he'd like me to commit this. So I asking if there are any objections against this going into the base. Gerhard On Tue, 28 Jan 2020 15:03:47 +0100 Gerhard Roth wrote: > Hi, > > this patch adds IPv6 support to umb(4). > > It will try to obtain a IPv6

Re: sys/ufs/ffs/ffs_softdep.c: use TAILQ_CONCAT(3)

2020-02-03 Thread Björn Ketelaars
On Mon 27/01/2020 20:01, Björn Ketelaars wrote: > cheloha@ recently replaced custom TAILQ concatenation loops in pool(9) > with TAILQ_CONCAT(3) [0]. I was curious as how often these custom > concatenations loops are used and grepped src. I found a couple of them. > One being in

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Ingo Schwarze
Hi, since our manual page doesn't explain the details of how openlog(3) uses *ident, it seems reasonable for users to conclude that it is safest to neither free nor modify it. Then again, given that in our implementation, freeing it may even pose a security hazard, i might seem friendly to give

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Todd C . Miller
On Mon, 03 Feb 2020 21:28:15 +0100, Ingo Schwarze wrote: > Given that our implementation chooses to use-after-free (as it is > permitted to) if the memory becomes invalid, i prefer the Theo's > strong wording "must persist" to the possibly less discouraging > "unspecified" - foremost, we are

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Stuart Henderson
On 2020/02/03 21:40, Jason McIntyre wrote: > On Mon, Feb 03, 2020 at 09:28:15PM +0100, Ingo Schwarze wrote: > > Hi, > > > > since our manual page doesn't explain the details of how openlog(3) > > uses *ident, it seems reasonable for users to conclude that it is > > safest to neither free nor

Re: IPv6 Support for umb(4)

2020-02-03 Thread Alexander Bluhm
On Tue, Jan 28, 2020 at 03:03:47PM +0100, Gerhard Roth wrote: > this patch adds IPv6 support to umb(4). It breaks my IPv4 setup. umb0 at uhub0 port 4 configuration 1 interface 6 "Lenovo H5321 gw" rev 2.00/0.00 addr 2 provider Vodafone.de firmware CXP 901 8700/1 - R3C18 When I apply the diff,

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Jason McIntyre
On Mon, Feb 03, 2020 at 09:53:39PM +, Stuart Henderson wrote: > On 2020/02/03 21:40, Jason McIntyre wrote: > > On Mon, Feb 03, 2020 at 09:28:15PM +0100, Ingo Schwarze wrote: > > > Hi, > > > > > > since our manual page doesn't explain the details of how openlog(3) > > > uses *ident, it seems

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Theo de Raadt
> +If the content of the string is changed, behaviour is unspecified. I like that. Since it is unspecified whether openlog stores the pointer or the string, it should discourage people from trying to be clever.

Re: sys/ufs/ffs/ffs_softdep.c: use TAILQ_CONCAT(3)

2020-02-03 Thread Alexander Bluhm
On Mon, Feb 03, 2020 at 05:37:01PM +0100, Bj??rn Ketelaars wrote: > On Mon 27/01/2020 20:01, Bj??rn Ketelaars wrote: > > cheloha@ recently replaced custom TAILQ concatenation loops in pool(9) > > with TAILQ_CONCAT(3) [0]. I was curious as how often these custom > > concatenations loops are used

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Andreas Kusalananda Kähäri
On Mon, Feb 03, 2020 at 09:28:15PM +0100, Ingo Schwarze wrote: > Hi, > > since our manual page doesn't explain the details of how openlog(3) > uses *ident, it seems reasonable for users to conclude that it is > safest to neither free nor modify it. > > Then again, given that in our

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Ingo Schwarze
Hi Andreas, Andreas Kusalananda wrote on Mon, Feb 03, 2020 at 09:56:22PM +0100: > Related: https://www.austingroupbugs.net/view.php?id=1244 > > A proposal seems to have been accepted (if I'm reading it correctly) in > November of last year to change the wording in POSIX from > > The

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Jason McIntyre
On Mon, Feb 03, 2020 at 09:28:15PM +0100, Ingo Schwarze wrote: > Hi, > > since our manual page doesn't explain the details of how openlog(3) > uses *ident, it seems reasonable for users to conclude that it is > safest to neither free nor modify it. > > Then again, given that in our