Re: wskbd_set_mixervolume

2022-02-07 Thread Anton Lindqvist
On Mon, Feb 07, 2022 at 11:43:43AM +0100, Alexandre Ratchov wrote: > On Sat, Feb 05, 2022 at 06:30:43PM +0100, Claudio Jeker wrote: > > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > > > From: Anton Lindqvist > > > > > > > > Hi, >

Re: perl clang -Wcompound-token-split-by-macro

2022-02-07 Thread Alexander Bluhm
On Tue, Jan 25, 2022 at 12:26:05PM -0800, Andrew Hewus Fresh wrote: > On Tue, Jan 25, 2022 at 09:20:55PM +0100, Alexander Bluhm wrote: > > On Tue, Jan 25, 2022 at 12:05:48PM -0800, Andrew Hewus Fresh wrote: > > > On Tue, Jan 25, 2022 at 06:45:12PM +0100, Alexander Bluhm wrote: > > > > On Tue, Jan

Re: wskbd_set_mixervolume

2022-02-07 Thread Anton Lindqvist
On Mon, Feb 07, 2022 at 11:21:43AM +0100, Alexandre Ratchov wrote: > On Sun, Feb 06, 2022 at 08:40:35AM +0100, Anton Lindqvist wrote: > > > > Polished diff. I'm omitting a necessary refactoring commit making > > audio_attach_mi() accept a new cookie argument. > > > > I'm not sure to understand

Re: hardware checksum ix and ixl

2022-02-07 Thread Alexander Bluhm
On Mon, Feb 07, 2022 at 06:46:28PM +1000, David Gwynne wrote: > new diff. this one has actual csum+vlans working without leaky routes > fixing things for me without me noticing. it's also been tested on > sparc64. I get 10% increase of throughput in my IPv6 TCP and UDP tests.

Re: perl clang -Wcompound-token-split-by-macro

2022-02-07 Thread Andrew Hewus Fresh
On Mon, Feb 07, 2022 at 08:11:55PM +0100, Alexander Bluhm wrote: > On Tue, Jan 25, 2022 at 12:26:05PM -0800, Andrew Hewus Fresh wrote: > > On Tue, Jan 25, 2022 at 09:20:55PM +0100, Alexander Bluhm wrote: > > > On Tue, Jan 25, 2022 at 12:05:48PM -0800, Andrew Hewus Fresh wrote: > > > > On Tue, Jan

rpki-client 7.6 released

2022-02-07 Thread Sebastian Benoit
rpki-client 7.6 has just been released and will be available in the rpki-client directory of any OpenBSD mirror soon. rpki-client is a FREE, easy-to-use implementation of the Resource Public Key Infrastructure (RPKI) for Relying Parties (RP) to facilitate validation of a BGP announcement. The

Re: wskbd_set_mixervolume

2022-02-07 Thread Alexandre Ratchov
On Mon, Feb 07, 2022 at 06:55:21PM +0100, Anton Lindqvist wrote: > On Mon, Feb 07, 2022 at 11:21:43AM +0100, Alexandre Ratchov wrote: > > On Sun, Feb 06, 2022 at 08:40:35AM +0100, Anton Lindqvist wrote: > > > > > > Polished diff. I'm omitting a necessary refactoring commit making > > >

Re: wskbd_set_mixervolume

2022-02-07 Thread Alexandre Ratchov
On Mon, Feb 07, 2022 at 06:58:40PM +0100, Anton Lindqvist wrote: > On Mon, Feb 07, 2022 at 11:43:43AM +0100, Alexandre Ratchov wrote: > > On Sat, Feb 05, 2022 at 06:30:43PM +0100, Claudio Jeker wrote: > > > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > > > Date: Sat, 5 Feb

Re: Increase armv7 ramdisk size

2022-02-07 Thread Theo de Raadt
Please don't do such a small increase, because it is likely we'll need to do it again the near future. I suggest taking ns#600 to ns#650 or ns#700, and adjusting all the numbers. Visa Hankala wrote: > armv7 ramdisk is very low on space. Building the ramdisk succeeds, > but the installer prints

Re: hardware checksum ix and ixl

2022-02-07 Thread Alexander Bluhm
On Fri, Feb 04, 2022 at 09:29:56PM +1000, David Gwynne wrote: > in the diff ixl_tx_setup_offload() is called after the dma mapping > occurs. Did you forget to enable checksum offloading in ixl(4) attach? Without it your diff does not have much effect. I have added it in my test.

Re: head(1): check for stdio errors

2022-02-07 Thread Todd C . Miller
On Sun, 06 Feb 2022 23:41:26 -0600, Scott Cheloha wrote: > > On Feb 6, 2022, at 20:07, Todd C. Miller wrote: > > > > Since the input is opened read-only I don't see the point in checking > > the fclose() return value. However, if you are going to do so, you > > might as well combine it with

Adjust KNOTE() macro

2022-02-07 Thread Visa Hankala
There is a discrepancy between the KNOTE() macro and its manual page entry. KNOTE() calls knote() if the list argument non-NULL. The manual page says that knote() is called if the list is non-empty. The manual page's notion originates from NetBSD. It differs from FreeBSD. I think the call on

Re: hardware checksum ix and ixl

2022-02-07 Thread David Gwynne
On Mon, Feb 07, 2022 at 02:39:38PM +1000, David Gwynne wrote: > On Fri, Feb 04, 2022 at 09:29:56PM +1000, David Gwynne wrote: > > On Fri, Jan 28, 2022 at 05:26:01PM +0100, Alexander Bluhm wrote: > > > On Wed, Jan 26, 2022 at 11:05:51AM +0100, Claudio Jeker wrote: > > > > On Wed, Jan 26, 2022 at

Re: unlock mmap(2) for anonymous mappings

2022-02-07 Thread Mark Kettenis
> Date: Mon, 7 Feb 2022 11:12:50 + > From: Klemens Nanni > > On Thu, Jan 27, 2022 at 11:11:48AM +, Klemens Nanni wrote: > > On Tue, Jan 25, 2022 at 07:54:52AM +, Klemens Nanni wrote: > > > > Could we use a vm_map_assert_locked() or something similar that reflect > > > > the

Re: unlock mmap(2) for anonymous mappings

2022-02-07 Thread Klemens Nanni
On Mon, Feb 07, 2022 at 12:41:27PM +0100, Mark Kettenis wrote: > > Date: Mon, 7 Feb 2022 11:12:50 + > > From: Klemens Nanni > > > > On Thu, Jan 27, 2022 at 11:11:48AM +, Klemens Nanni wrote: > > > On Tue, Jan 25, 2022 at 07:54:52AM +, Klemens Nanni wrote: > > > > > Could we use a

Re: wskbd_set_mixervolume

2022-02-07 Thread Alexandre Ratchov
On Sun, Feb 06, 2022 at 08:40:35AM +0100, Anton Lindqvist wrote: > > Polished diff. I'm omitting a necessary refactoring commit making > audio_attach_mi() accept a new cookie argument. > I'm not sure to understand the need for the wskbd_audio structure. Couldn't we just store the cookie in

Re: uvm_unmap_kill_entry(): unwire with map lock held

2022-02-07 Thread Klemens Nanni
On Fri, Feb 04, 2022 at 01:37:41PM -0300, Martin Pieuchot wrote: > On 04/02/22(Fri) 03:39, Klemens Nanni wrote: > > [...] > > ... with the lock grabbed in uvm_map_teardown() that is, otherwise > > the first call path can lock against itself (regress/misc/posixtestsuite > > is a reproduce for

Re: wskbd_set_mixervolume

2022-02-07 Thread Alexandre Ratchov
On Sat, Feb 05, 2022 at 06:30:43PM +0100, Claudio Jeker wrote: > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > > From: Anton Lindqvist > > > > > > Hi, > > > I recently got a USB headset with physical volume buttons, handled by > > >

Re: unlock mmap(2) for anonymous mappings

2022-02-07 Thread Klemens Nanni
On Thu, Jan 27, 2022 at 11:11:48AM +, Klemens Nanni wrote: > On Tue, Jan 25, 2022 at 07:54:52AM +, Klemens Nanni wrote: > > > Could we use a vm_map_assert_locked() or something similar that reflect > > > the exclusive or shared (read) lock comments? I don't trust comments. > > > It's too

Increase armv7 ramdisk size

2022-02-07 Thread Visa Hankala
armv7 ramdisk is very low on space. Building the ramdisk succeeds, but the installer prints errors: uid 0 on /: file system full /: write failed, file system is full sed: stdout: No space left on device OK to increase? Index: etc/etc.armv7/disktab

Re: unlock mmap(2) for anonymous mappings

2022-02-07 Thread Mark Kettenis
> Date: Mon, 7 Feb 2022 12:11:42 + > From: Klemens Nanni > > On Mon, Feb 07, 2022 at 12:41:27PM +0100, Mark Kettenis wrote: > > > Date: Mon, 7 Feb 2022 11:12:50 + > > > From: Klemens Nanni > > > > > > On Thu, Jan 27, 2022 at 11:11:48AM +, Klemens Nanni wrote: > > > > On Tue, Jan

Re: Increase armv7 ramdisk size

2022-02-07 Thread Mark Kettenis
> Date: Mon, 7 Feb 2022 12:49:40 + > From: Visa Hankala > > armv7 ramdisk is very low on space. Building the ramdisk succeeds, > but the installer prints errors: > > uid 0 on /: file system full > > /: write failed, file system is full > sed: stdout: No space left on device > > OK to