Re: static const, not const static

2022-08-28 Thread Theo Buehler
On Mon, Aug 29, 2022 at 01:26:49PM +1000, Jonathan Gray wrote: > c99 6.11.5: > "The placement of a storage-class specifier other than at the beginning > of the declaration specifiers in a declaration is an obsolescent > feature." ok tb

static const, not const static

2022-08-28 Thread Jonathan Gray
c99 6.11.5: "The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature." diff --git lib/libcrypto/ec/ecp_nistz256.c lib/libcrypto/ec/ecp_nistz256.c index 05a16b8c074..4b2ab497327 100644 ---

Re: dhcpleased.8: add lease files to FILES

2022-08-28 Thread Florian Obser
On 2022-08-18 20:34 UTC, Klemens Nanni wrote: > On Thu, Aug 18, 2022 at 08:53:51PM +0100, Jason McIntyre wrote: >> On Thu, Aug 18, 2022 at 07:29:42PM +, Klemens Nanni wrote: >> > There is dhcpleasectl(8) -l but that only works for currently >> > configured leases/interfaces and does not print

Re: tetris(6) "Random Generator" and advanced controls

2022-08-28 Thread Stuart Henderson
On 2022/08/27 19:58, Tom MTT. wrote: > Apparently, as some people pointed it out, DMARC doesn't influence spam score. Depends on the mail server doing filtering. > I thought that since my e-mail failed both SPF and DKIM and my DMARC > policy was set to quarantine my mail would've been trashed

Re: libfido2 update

2022-08-28 Thread Stuart Henderson
On 2022/08/24 17:09, Damien Miller wrote: > Hi, > > https://www.mindrot.org/misc/libfido2-1.11.0.diff contains an update > for src/libfido2 from 1.8 to 1.11 (about 10 months of upstream > development). > > I've tested it with OpenSSH, which is the only thing in src/ that > uses it as well as

Re: When did PCs stop using ISA Timer 1?

2022-08-28 Thread Daniel Dickman
On Sat, Aug 27, 2022 at 7:15 AM Jonathan Gray wrote: > > On Fri, Aug 26, 2022 at 10:21:32PM -0500, Scott Cheloha wrote: > > I noticed that on non-LAPIC systems we program channel 0 in periodic > > mode with an initial count of 11932 to effect a 100hz clock interrupt. > > And then we also use that

installboot: softraid: make verbose message -n/nowrite aware

2022-08-28 Thread Klemens Nanni
Using installboot in dry-run mode aka. -vn (verbose + nowrite) and first reading "would install" followed by an "installing" made me uneasy. Luckily, nothing was written in dry-run mode, it's just that the softraid specific code fails to honour -n/nowrite. So make sure it does and pull the

installboot: efi: fix passing explicit stage files

2022-08-28 Thread Klemens Nanni
Every platform ought to set `stages', `stage1' and optionally `stage2' in md_init(), otherwise passing explicit files results won't work as `stages' is zero-initialised and no default path is set: # installboot -v sd0 /root/BOOTAA64.EFI usage: installboot [-npv] [-r root] disk

Re: move PRU_ABORT request to (*pru_abort)()

2022-08-28 Thread Alexander Bluhm
On Sun, Aug 28, 2022 at 01:05:41AM +0300, Vitaliy Makkoveev wrote: > PRU_ABORT is another candidate to change return type to void. Also > actually we abort only the sockets which are linked to `so_q' or `so_q0' > queues of listening socket. Such sockets have no corresponding file > descriptor and

remove pr_output

2022-08-28 Thread Alexander Bluhm
Hi, Since we have no raw_usrreq anymore, we can retire pr_output. pfkeyv2 and route can call ther output functions directly. ok? bluhm Index: net/pfkeyv2.c === RCS file: /data/mirror/openbsd/cvs/src/sys/net/pfkeyv2.c,v retrieving

static inline, not inline static

2022-08-28 Thread Jonathan Gray
diff --git lib/libc/locale/wctoint.h lib/libc/locale/wctoint.h index ea50c5ae1b6..14c7f0c466d 100644 --- lib/libc/locale/wctoint.h +++ lib/libc/locale/wctoint.h @@ -30,7 +30,7 @@ */ -inline static int +static inline int wctoint(wchar_t wc) { int n; diff --git

Re: Don't scheck `so_pcb' with PR_WANTRCVD flag

2022-08-28 Thread Alexander Bluhm
On Sat, Aug 27, 2022 at 11:37:14PM +0300, Vitaliy Makkoveev wrote: > tcp(4) sockets are the only sockets which could have NULL `so_pcb' and > we handle this case within tcp_rcvd() handler. OK bluhm@ > Index: sys/kern/uipc_socket.c >

Re: static inline, not inline static

2022-08-28 Thread Anders Andersson
On Sun, Aug 28, 2022 at 3:15 PM Jonathan Gray wrote: > > diff --git lib/libc/locale/wctoint.h lib/libc/locale/wctoint.h > index ea50c5ae1b6..14c7f0c466d 100644 > --- lib/libc/locale/wctoint.h > +++ lib/libc/locale/wctoint.h > @@ -30,7 +30,7 @@ > */ > > > -inline static int > +static inline int

Re: static inline, not inline static

2022-08-28 Thread Philip Guenther
On Sun, Aug 28, 2022 at 2:11 PM Anders Andersson wrote: > On Sun, Aug 28, 2022 at 3:15 PM Jonathan Gray wrote: > > > > diff --git lib/libc/locale/wctoint.h lib/libc/locale/wctoint.h > > index ea50c5ae1b6..14c7f0c466d 100644 > > --- lib/libc/locale/wctoint.h > > +++ lib/libc/locale/wctoint.h > >

Re: use volatile not __volatile__

2022-08-28 Thread Philip Guenther
On Sat, Aug 27, 2022 at 6:41 PM Jonathan Gray wrote: > directly use ansi volatile keyword not __volatile__ builtin > Yes, please. ok guenther@

Re: use volatile not __volatile

2022-08-28 Thread Philip Guenther
On Sat, Aug 27, 2022 at 6:31 PM Jonathan Gray wrote: > directly use ansi volatile keyword not __volatile from cdefs.h > Yay! ok guenther@

Re: remove pr_output

2022-08-28 Thread Vitaliy Makkoveev
> On 28 Aug 2022, at 20:48, Alexander Bluhm wrote: > > Hi, > > Since we have no raw_usrreq anymore, we can retire pr_output. > pfkeyv2 and route can call ther output functions directly. > > ok? > ok mvs@ > bluhm > > Index: net/pfkeyv2.c >

move PRU_SENSE request to (*pru_sense)()

2022-08-28 Thread Vitaliy Makkoveev
Another candidate for future refactoring. Except the tcp(4) and unix(4) cases we do nothing with passed `ub', but in all cases we return no error. Index: sys/kern/uipc_usrreq.c === RCS file: /cvs/src/sys/kern/uipc_usrreq.c,v

move PRU_RCVOOB request to (*pru_rcvoob)()

2022-08-28 Thread Vitaliy Makkoveev
Index: sys/kern/uipc_usrreq.c === RCS file: /cvs/src/sys/kern/uipc_usrreq.c,v retrieving revision 1.178 diff -u -p -r1.178 uipc_usrreq.c --- sys/kern/uipc_usrreq.c 28 Aug 2022 21:35:11 - 1.178 +++ sys/kern/uipc_usrreq.c

i386/lapic.c: sync with amd64/lapic.c

2022-08-28 Thread Scott Cheloha
As promised off-list: in anticipation of merging the clock interrupt code, let's sync up the lapic timer parts of i386/lapic.c with the corresponding parts in amd64/lapic.c. They will need identical changes to use the new code, so the more alike they are the better. Notable differences remaining

Re: move PRU_SENSE request to (*pru_sense)()

2022-08-28 Thread Alexander Bluhm
On Sun, Aug 28, 2022 at 10:51:31PM +0300, Vitaliy Makkoveev wrote: > Another candidate for future refactoring. Except the tcp(4) and unix(4) > cases we do nothing with passed `ub', but in all cases we return no > error. Instead of adding all these return(0) functions, we should return(0) in

Re: move PRU_SENSE request to (*pru_sense)()

2022-08-28 Thread Vitaliy Makkoveev
On Sun, Aug 28, 2022 at 10:42:11PM +0200, Alexander Bluhm wrote: > On Sun, Aug 28, 2022 at 10:51:31PM +0300, Vitaliy Makkoveev wrote: > > Another candidate for future refactoring. Except the tcp(4) and unix(4) > > cases we do nothing with passed `ub', but in all cases we return no > > error. > >

Re: move PRU_SENSE request to (*pru_sense)()

2022-08-28 Thread Alexander Bluhm
On Mon, Aug 29, 2022 at 12:18:49AM +0300, Vitaliy Makkoveev wrote: > On Sun, Aug 28, 2022 at 10:42:11PM +0200, Alexander Bluhm wrote: > > On Sun, Aug 28, 2022 at 10:51:31PM +0300, Vitaliy Makkoveev wrote: > > > Another candidate for future refactoring. Except the tcp(4) and unix(4) > > > cases we

Re: libfido2 update

2022-08-28 Thread Damien Miller
On Sun, 28 Aug 2022, Stuart Henderson wrote: > On 2022/08/24 17:09, Damien Miller wrote: > > Hi, > > > > https://www.mindrot.org/misc/libfido2-1.11.0.diff contains an update > > for src/libfido2 from 1.8 to 1.11 (about 10 months of upstream > > development). > > > > I've tested it with OpenSSH,