Re: LLVM warning in sys/uvm/uvm_map.c

2013-12-06 Thread Jonathan Gray
On Fri, Dec 06, 2013 at 11:41:47PM -0500, Brad Smith wrote: > On 06/12/13 11:39 PM, Ted Unangst wrote: > >On Fri, Dec 06, 2013 at 20:47, Brad Smith wrote: > >>On Tue, Dec 03, 2013 at 06:48:11PM -0500, Brad Smith wrote: > >>>An unused function in the UVM code. #if 0 it out for now. > >>> > >>>uvm_ma

Re: LLVM warning in sys/uvm/uvm_map.c

2013-12-06 Thread Ted Unangst
On Fri, Dec 06, 2013 at 23:41, Brad Smith wrote: > The function isn't being called anywhere in the tree. You're missing the > point. The kernel builds with -Werror. I wouldn't care about these > warnings if it didn't. -Wno-unused or whatever?

Re: LLVM warning in sys/uvm/uvm_map.c

2013-12-06 Thread Brad Smith
On 06/12/13 11:39 PM, Ted Unangst wrote: On Fri, Dec 06, 2013 at 20:47, Brad Smith wrote: On Tue, Dec 03, 2013 at 06:48:11PM -0500, Brad Smith wrote: An unused function in the UVM code. #if 0 it out for now. uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp' [-Werror,-Wunused-fun

Re: LLVM warning in sys/uvm/uvm_map.c

2013-12-06 Thread Ted Unangst
On Fri, Dec 06, 2013 at 20:47, Brad Smith wrote: > On Tue, Dec 03, 2013 at 06:48:11PM -0500, Brad Smith wrote: >> An unused function in the UVM code. #if 0 it out for now. >> >> uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp' > [-Werror,-Wunused-function] >> uvm_map.c:353:1: error:

Re: cdce / cdce / urndis ioctl handling clean up

2013-12-06 Thread Brad Smith
On 02/12/13 6:28 PM, Brad Smith wrote: Some clean up to the cdce / cdcef and urndis ioctl handlers to bring things in line with the other Ethernet drivers. no functional change. OK? ping. Index: if_cdce.c === RCS file: /home/cvs

Re: LLVM warning in sys/compat/linux/linux_misc.c

2013-12-06 Thread Brad Smith
On 28/11/13 10:05 PM, Brad Smith wrote: Remove unsigned comparison < 0. ../../../../compat/linux/linux_misc.c:1531:24: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] Comments? OK? ping. Index: linux_misc.c =

Re: LLVM warning in sys/uvm/uvm_map.c

2013-12-06 Thread Brad Smith
On Tue, Dec 03, 2013 at 06:48:11PM -0500, Brad Smith wrote: > An unused function in the UVM code. #if 0 it out for now. > > uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp' > [-Werror,-Wunused-function] > uvm_map.c:353:1: error: unused function 'uvm_mapentry_freecmp' > [-Werror,-W

Proper cache flushing on amd64 and i386

2013-12-06 Thread Mark Kettenis
The implementation of the clflush() inline function has been wrong ever since it was introduced by oga@ 4 years ago. Probably the cause of small artifacts like the wigly cursor on machines like the x60. But really disastrous for the modern kms graphics stack^H^H^H^H^Hpile of poo that we have these

rsu.4 update

2013-12-06 Thread Kirill Bychkov
Hi. This adapter is working. OK to commit? Index: rsu.4 === RCS file: /cvs/src/share/man/man4/rsu.4,v retrieving revision 1.15 diff -u -p -u -r1.15 rsu.4 --- rsu.4 20 Aug 2013 13:46:53 - 1.15 +++ rsu.4 6 Dec 2013