Re: reviewing OpenSSL's lib/libssl/src/crypto/asn1

2014-04-20 Thread Dirk Engling
On 21.04.14 04:56, Ted Unangst wrote: > Also, can you include diffs inline please? One diff per email. Maybe > just one or two emails to start, then try sending the rest after we > see how that goes? fix double free in d2i_ASN1_bytes by setting ret->data = NULL after free, before potential goto e

Re: reviewing OpenSSL's lib/libssl/src/crypto/asn1

2014-04-20 Thread Dirk Engling
On 21.04.14 04:56, Ted Unangst wrote: > Also, can you include diffs inline please? One diff per email. Maybe > just one or two emails to start, then try sending the rest after we > see how that goes? fix memory leak in a2i_ASN1_ENUMERATED, a2i_ASN1_STRING and a2i_ASN1_INTEGER, in case of of goto

Re: reviewing OpenSSL's lib/libssl/src/crypto/asn1

2014-04-20 Thread Ted Unangst
On Mon, Apr 21, 2014 at 04:43, Dirk Engling wrote: > On 21.04.14 01:13, Bob Beck wrote: > >> this list is for diffs. post them. keep them reviewable - of >> meaningful size and doing a certain thing. >> (as opposed to this diff changes 15 things.. ) > > Find attached my patches for some memory

Re: reviewing OpenSSL's lib/libssl/src/crypto/asn1

2014-04-20 Thread Dirk Engling
On 21.04.14 01:13, Bob Beck wrote: > this list is for diffs. post them. keep them reviewable - of > meaningful size and doing a certain thing. > (as opposed to this diff changes 15 things.. ) Find attached my patches for some memory leaks, use after frees and some minor house keeping as follows

Correctly document return value of getenv(3)

2014-04-20 Thread Ben Cornett
Clarify the return value of getenv. Index: lib/libc/stdlib/getenv.3 === RCS file: /cvsroot/OpenBSD/src/lib/libc/stdlib/getenv.3,v retrieving revision 1.19 diff -u -p -r1.19 getenv.3 --- lib/libc/stdlib/getenv.35 Jun 2013 03:39:23

Re: reviewing OpenSSL's lib/libssl/src/crypto/asn1

2014-04-20 Thread Bob Beck
On Sun, Apr 20, 2014 at 5:06 PM, Dirk Engling wrote: > Dear openbsd devs, > > I've just put on my rubber gloves to help with your heroic efforts on > OpenSSL. I started to dive into OpenSSL's ASN.1 implementation and now > wonder how to share my findings, patches and requests without spamming this

reviewing OpenSSL's lib/libssl/src/crypto/asn1

2014-04-20 Thread Dirk Engling
Dear openbsd devs, I've just put on my rubber gloves to help with your heroic efforts on OpenSSL. I started to dive into OpenSSL's ASN.1 implementation and now wonder how to share my findings, patches and requests without spamming this list. Also while scanning through the rest of libssl, I'

Re: [patch] courier-imap-4.13 imapd patch replacing malloc, strcat and strcpy with asprintf

2014-04-20 Thread Peter Malone
That's it in a nutshell, essentially. I'll take a stab at it, until I get frustrated. Perhaps my time would be better suited to something else which could help OpenBSD. For the time being, however, I'll give this a shot. On 04/20/14 02:18, Maxime Villard wrote: Le 20/04/2014 02:38, Peter Ma

CommIt the Patch

2014-04-20 Thread Vadim Zhukov
cat >/dev/null < 1)); do [[ $1 == -?* ]] || break vcs_opts[${vcs_opts[#]}]=$1 shift done debug=false [[ -n $DEBUG ]] && debug=true function usage { echo "usage: ${0##*/} [file] ..." >&2 exit 0 } p_full= p_actual= p_hunk= cleanup() { if $debug; the

vlan tagging surgery

2014-04-20 Thread Henning Brauer
so, on vlan, to insert the vlan tag, we right now: -copy (most of) the existing ethernet header into a ether_vlan_header on the stack -fill the extra fields (tag, inside ether type) in ether_vlan_header -set the ether type -m_adj() to make room for the extra space ether_vlan_header needs -m_copyba

Re: [patch] courier-imap-4.13 imapd patch replacing malloc, strcat and strcpy with asprintf

2014-04-20 Thread Maxime Villard
Le 20/04/2014 02:38, Peter Malone a écrit : > Hi, > > I'm using OpenBSD 5.5. courier-imap-4.13 is in the ports tree and it's > quite a mess. I started looking at it today with the hope of just > replacing some of the malloc,strcat & strcpy calls with asprintf, but it > became clear before long tha

Re: sftp upload resume diff

2014-04-20 Thread Loganaden Velvindron
Simplify the diff: use -a for both upload and download resume support. This makes it more consistent. Index: sftp-client.h === RCS file: /cvs/src/usr.bin/ssh/sftp-client.h,v retrieving revision 1.24 diff -u -p -u -p -r1.24 sftp-clie

Re: [patch] courier-imap-4.13 imapd patch replacing malloc, strcat and strcpy with asprintf

2014-04-20 Thread Stuart Henderson
On 2014/04/19 20:38, Peter Malone wrote: > Hi, > > I'm using OpenBSD 5.5. courier-imap-4.13 is in the ports tree and it's > quite a mess. I started looking at it today with the hope of just > replacing some of the malloc,strcat & strcpy calls with asprintf, but it > became clear before long that t