> I found the issue. In param_copy_gost01() change
> int ret = 0;
> to
> int ret = 1;
>
> If there is no private key set in eto, param_copy_gost01() will
> skip all ret assignments and happily return 0 (= error).
Doh, of course! Sorry for introducing this bug.
Miod
On Tue, Nov 18, 2014 at 11:46:56AM +1000, David Gwynne wrote:
>
> > On 18 Nov 2014, at 11:39, Ted Unangst wrote:
> >
> > On Tue, Nov 18, 2014 at 11:06, David Gwynne wrote:
> >
> >> +#include
> >
> > Sorry to interrupt :), but I think it's become clear that rndvar.h is
> > the wrong header for
> On 18 Nov 2014, at 11:39, Ted Unangst wrote:
>
> On Tue, Nov 18, 2014 at 11:06, David Gwynne wrote:
>
>> +#include
>
> Sorry to interrupt :), but I think it's become clear that rndvar.h is
> the wrong header for arc4random() to live in.
agreed.
> The diff below moves it to systm.h and fix
On Tue, Nov 18, 2014 at 11:06, David Gwynne wrote:
> +#include
Sorry to interrupt :), but I think it's become clear that rndvar.h is
the wrong header for arc4random() to live in.
The diff below moves it to systm.h and fixes the two files that didn't
compile.
Index: dev/rndvar.h
===
this cuts all the hashes in the filesystems over to using siphash
to get keys into their hashes.
i have compiled all of them, and will start on testing them as much
as i can. so far i have done softdep and started on the nfs srv
cache. id like help and review though.
Index: isofs/cd9660/cd9660_no
On Mon, Nov 17, 2014 at 11:24, Tobias Stoeckmann wrote:
> On Sun, Nov 16, 2014 at 06:38:24PM -0500, Ted Unangst wrote:
>> Not sure how I ended up reading this file, but all the redundant
>> strlen calls make me twitchy.
>
> I agree, but have you considered the other parser.c files with
> match_tok
On Mon, Nov 17, 2014 at 20:01, Mark Kettenis wrote:
>> Date: Sun, 16 Nov 2014 19:10:41 -0500
>> From: Ted Unangst
>>
>> The historic copystr API is like copyinstr/copyoutstr but only for
>> kernel strings. A much more familiar API is strlcpy.
>>
>> This converts three examples in kern.
>>
>> One w
2014-11-17 23:35 GMT+03:00 Miod Vallat :
>> Is the offending patch in CVS? If so I'll take a look as it hits the
>> LibreSSL mirror at GitHub.
>
> Yes, it's in HEAD.
I found the issue. In param_copy_gost01() change
int ret = 0;
to
int ret = 1;
If there is no private key set in eto, param_copy_gos
> Is the offending patch in CVS? If so I'll take a look as it hits the
> LibreSSL mirror at GitHub.
Yes, it's in HEAD.
Hi all,
I bought Silicon Labs CP2110-EK USB HID-to-UART evaluation kit
and connected to OpenBSD box.
uslcom(4) tries to use CP2110, but the device is different from
CP210x series.
How about to fix usbdevs and uslcom.c like this?
Index: usbdevs
==
2014-11-17 22:28 GMT+03:00 Miod Vallat :
> So I've finally sit down and tested interoperability of LibreSSL with
> the various gost-enabled sites you've listed, starting with simple
> things such as:
>
> openssl s_client -debug -connect zakupki.gov.ru:443
>
> Unfortunately, this fails because of
Due to a bug in the libc asr resolver, querying an invalid hostname can
cause a crash. Patches are available for 5.5 and 5.6.
untrusted comment: signature from openbsd 5.6 base private key
RWR0EANmo9nqhl31oIXbJYtUWXNHHNzHGhJ+v2XZAAlwH5TwYDkTp2NHqjhnrJayp37glapQejDsm/LDGm1M5bnpkmHh7FGNGQ4=
OpenBSD
Patches are now available for 5.5 and 5.6 to fix an issue with pfctl
and certain rules combining IPv4 and IPv6 addresses (in that order) with
a dynamic interface address using the "(interface)" format. The patch
for 5.6 follows.
This problem can be worked around by reversing the order of addresses
So I've finally sit down and tested interoperability of LibreSSL with
the various gost-enabled sites you've listed, starting with simple
things such as:
openssl s_client -debug -connect zakupki.gov.ru:443
Unfortunately, this fails because of the failure checks I've added to
the GOST code trigge
> Date: Sun, 16 Nov 2014 19:10:41 -0500
> From: Ted Unangst
>
> The historic copystr API is like copyinstr/copyoutstr but only for
> kernel strings. A much more familiar API is strlcpy.
>
> This converts three examples in kern.
>
> One where the return value is unchecked. One where the return i
This patch fixes a relayd crash for the 5.6 release.
untrusted comment: signature from openbsd 5.6 base private key
RWR0EANmo9nqhgFKMGabOlUXoxAuey9xQyKcm0OULFMOSkyd3ReQHQjwA1psSBbqu1ex9j28D/nyEh6U8uj8f2oFZtXoHA7njAg=
OpenBSD 5.6 errata 6, Nov 17, 2014: Fix for relayd crash
Apply patch using:
Hi,
savestr is a function very similar to strdup. If it runs into an out
of memory condition, its behavior depends on the current status of the
program. If patch is in "plan a" mode, it will set an out_of_memory
flag, returns NULL and patch will try later on with "plan b" again.
If it is in "pla
Hi,
the hunk size is basically limitated to MAXHUNKSIZE, although the
implementation consideres it as a soft limit: it's possible to get one
step above this limit. It's set to 100,000 but hunkmax can be legally
set to 128,000...
This diff unifies the grow check and avoids calling realloc() agai
Hi,
after using the temporary buffer "ps" for parse_addr, it is not
released after successful operation.
Tobias
Index: parser.c
===
RCS file: /cvs/src/usr.sbin/ospf6ctl/parser.c,v
retrieving revision 1.12
diff -u -p -r1.12 parser.c
On Sun, Nov 16, 2014 at 06:38:24PM -0500, Ted Unangst wrote:
> Not sure how I ended up reading this file, but all the redundant
> strlen calls make me twitchy.
I agree, but have you considered the other parser.c files with
match_token and same use of strlen(word), too?
src/usr.sbin/dvmrpctl/parse
On Sun, Nov 16, 2014 at 06:19:17PM -0500, Ted Unangst wrote:
> I think using the correct data type is the right thing to do. If it's
> the size of a file, it goes in an off_t. The only thing to watch for
> is passing an off_t to malloc(), where it can wrap and be truncated.
Yes, off_t for memory o
In copy mode, when searching up from the top left corner or searching
down from the bottom right corner (the latter code path actually can't
be reached because of a check which is off by one), the functions
window_copy_search_{up,down}() return without freeing the members of `ss'.
This can be fixed
22 matches
Mail list logo