Re: Brainy: a few bugs

2015-09-13 Thread Claudio Jeker
On Fri, Sep 11, 2015 at 09:18:18PM +0200, Maxime Villard wrote: > Got some time tonight; nothing new, just emptying my list: > > http://m00nbsd.net/e5ab5f6e59d6a0feb7d1a518acc8233d.html#Unsorted-2 > > Summary: > > _17/ UNINITIALIZED VARIABLE: sys/netinet/if_ether.c rev1.165 > _18/ UNINITIA

Brainy: a few bugs

2015-09-13 Thread Maxime Villard
Got some time tonight; nothing new, just emptying my list: http://m00nbsd.net/e5ab5f6e59d6a0feb7d1a518acc8233d.html#Unsorted-2 Summary: _17/ UNINITIALIZED VARIABLE: sys/netinet/if_ether.c rev1.165 _18/ UNINITIALIZED VARIABLE: sys/net80211/ieee80211_pae_output.c rev1.20 _19/ UNINITIALIZED

Re: lpd: move hosts.lpd parsing into lpd proper

2015-09-13 Thread Todd C. Miller
On Sun, 13 Sep 2015 09:25:19 -0600, "Todd C. Miller" wrote: > This should allow us to stop exporting __ivaliduser and __ivaliduser_sa > from libc and to eventually remove ruserok from libc entirely. > > Needs testing by someone who actually runs lpd... Newer version that is easy to test separate

Remove unused vars from if_urtwn.c

2015-09-13 Thread Michael McConville
Index: if_urtwn.c === RCS file: /cvs/src/sys/dev/usb/if_urtwn.c,v retrieving revision 1.51 diff -u -p -r1.51 if_urtwn.c --- if_urtwn.c 10 Sep 2015 11:53:05 - 1.51 +++ if_urtwn.c 13 Sep 2015 21:30:32 - @@ -2713,7 +2713,7

[WIP PATCH] SR RAID1 checksumming support V3

2015-09-13 Thread Karel Gardas
Hello, attached is my work in progress on checksumming support for softraid RAID1. Currently it does: - computation of checksums (crc32) - verification of checksums - hang-over to another chunk (restart wu) in case of checksum error - properly handle errors happening on all chunks - "self-healing"

Re: IPv6 transport for pflow(4)

2015-09-13 Thread Florian Obser
On Sun, Sep 13, 2015 at 03:25:16PM +, Florian Obser wrote: > I don't really like to store struct sockaddr_storage since it's so > big. I played around with a union like pf does, but looked > complicated. > Thoughts? > > Also with this you can specify a source port. > Since I was touching all t

Condense fluffy comments in pax

2015-09-13 Thread Michael McConville
Index: options.c === RCS file: /cvs/src/bin/pax/options.c,v retrieving revision 1.91 diff -u -p -r1.91 options.c --- options.c 18 May 2015 20:26:16 - 1.91 +++ options.c 11 Sep 2015 00:12:19 - @@ -668,9 +668,7 @@ tar_op

Fix error reporting in ksh's csh-history

2015-09-13 Thread Michael McConville
ksh offers csh-style history aliases when you set csh-history. This feature currently works. However, when an alias doesn't exist ksh reports only the last digit (thanks to Theo for tipping me off on this): > mike:/tmp/tech:1$ set -o csh-history > mike:/tmp/tech:2$ ls > a b c > mike:/tmp/tech:3$

Re: [PATCH] Initial implementation of posix_fallocate(2)

2015-09-13 Thread Dimitris Papastamos
Hi, A slightly updated patch. Removed some checks that were redundant. Index: kern/init_sysent.c === RCS file: /cvs/src/sys/kern/init_sysent.c,v retrieving revision 1.171 diff -u -p -r1.171 init_sysent.c --- kern/init_sysent.c 9 Se

IPv6 transport for pflow(4)

2015-09-13 Thread Florian Obser
I don't really like to store struct sockaddr_storage since it's so big. I played around with a union like pf does, but looked complicated. Thoughts? Also with this you can specify a source port. Since I was touching all those lines anyway I renamed sender to flowsrc and receiver to flowdst like th

lpd: move hosts.lpd parsing into lpd proper

2015-09-13 Thread Todd C. Miller
This should allow us to stop exporting __ivaliduser and __ivaliduser_sa from libc and to eventually remove ruserok from libc entirely. Needs testing by someone who actually runs lpd... - todd Index: usr.sbin/lpr/lpd/Makefile === RC

Re: Purge route entries when an address is removed

2015-09-13 Thread Martin Pieuchot
On 13/09/15(Sun) 15:51, Alexander Bluhm wrote: > On Sun, Sep 13, 2015 at 11:15:50AM +0200, Martin Pieuchot wrote: > > This makes the kernel simpler as it no longer try to find a new ifa > > when a route with a stale address is being used. > > This makes the code simpler, which is good. > > I am s

Re: Purge route entries when an address is removed

2015-09-13 Thread Alexander Bluhm
On Sun, Sep 13, 2015 at 11:15:50AM +0200, Martin Pieuchot wrote: > This makes the kernel simpler as it no longer try to find a new ifa > when a route with a stale address is being used. This makes the code simpler, which is good. I am still not convinced that we want to loose the feature that the

[PATCH] mount_tmpfs -P option for populating after mounting (simplified)

2015-09-13 Thread bytevolcano
Hello, Although a patch like this was submitted before, this one is more "focused". It may be useful for those moving from MFS who use this option to pre-populate an MFS mount with a collection of files. This will refuse to work if the path specified for -P is not a directory. If the copy is uns

Re: netstart: only call ifautoconf is rtsolif is populated

2015-09-13 Thread Robert Peichaer
On Sun, Sep 13, 2015 at 01:35:02PM +0100, Stuart Henderson wrote: > On 2015/09/13 13:19, Stuart Henderson wrote: > > Avoid printing "IPv6 autoconf:" if you have no v6 rtsol interfaces. > > OK? > > As suggested by rpe, just do the check once in ifautoconf. > (I was trying to avoid the indent, but i

Re: netstart: only call ifautoconf is rtsolif is populated

2015-09-13 Thread Stuart Henderson
On 2015/09/13 13:19, Stuart Henderson wrote: > Avoid printing "IPv6 autoconf:" if you have no v6 rtsol interfaces. > OK? As suggested by rpe, just do the check once in ifautoconf. (I was trying to avoid the indent, but it's not too horrible) Index: netstart ===

netstart: only call ifautoconf is rtsolif is populated

2015-09-13 Thread Stuart Henderson
Avoid printing "IPv6 autoconf:" if you have no v6 rtsol interfaces. OK? Index: netstart === RCS file: /cvs/src/etc/netstart,v retrieving revision 1.154 diff -u -p -r1.154 netstart --- netstart11 Sep 2015 12:21:52 - 1.154

Re: ksh: allow leading space stripping with <<- redirection

2015-09-13 Thread Alessandro DE LAURENZIS
Hello Philip, On Sun 13/09/2015 09:32, Philip Guenther wrote: [...] > Nope. The just-strip-tabs behavior is straight from the standard. To > quote SUSv4 XCU section 2.7.4 paragraph 5: [...] Got it, thanks for your feedback. Cheers -- Alessandro DE LAURENZIS [mailto:just22@gmail.com] Linke

mpsafe revarps

2015-09-13 Thread David Gwynne
this moves revarp processing to softnet because it is not mpsafe. it works fine for general use, but i would like someone to test it with diskless booting. ie, i want to know if nfs root works with this. ok? Index: net/if_ethersubr.c ==

Re: kill struct inpcbtable's inpt_lastport

2015-09-13 Thread Vincent Gross
On 09/13/15 10:37, Claudio Jeker wrote: > On Sun, Sep 13, 2015 at 12:18:10AM +0200, Vincent Gross wrote: >> On 09/12/15 22:10, Claudio Jeker wrote: >>> On Sat, Sep 12, 2015 at 02:40:59PM +0200, Vincent Gross wrote: inpt_lastport is never read without being written before, and only in_pcbb

Re: Floating point #define in ksh

2015-09-13 Thread Nicholas Marriott
On Sat, Sep 12, 2015 at 08:45:43PM -0400, Michael McConville wrote: > Nicholas Marriott wrote: > > Works for me. ok anyone? > > > > I think ksh_limval.h can go entirely after this, per the note in > > PROJECTS. > > I also just found this gem. It only has one use, so it can probably be > replaced.

Purge route entries when an address is removed

2015-09-13 Thread Martin Pieuchot
Currently we leave RTF_STATIC route entries in the table when the address they are attached to is removed from a system. That's why ifas need to be refcounted and that's why we have *a lot* of checks in the stack to not use cached routes attached to such ifa. I'd like to simplify all of this by s

Re: kill struct inpcbtable's inpt_lastport

2015-09-13 Thread Claudio Jeker
On Sun, Sep 13, 2015 at 12:18:10AM +0200, Vincent Gross wrote: > On 09/12/15 22:10, Claudio Jeker wrote: > > On Sat, Sep 12, 2015 at 02:40:59PM +0200, Vincent Gross wrote: > >> inpt_lastport is never read without being written before, and only > >> in_pcbbind() > >> and in6_pcbsetport() are using i

mpsafe ip_carp

2015-09-13 Thread David Gwynne
i did this yesterday, but havent had a chance to beat on it properly yet. if anyone would like to give it a go it would be much appreciated. im particularly interested in stability while carp configuration is made or changed. if it happens to keep handling packets, thats great, but not blowing up

Re: ksh: allow leading space stripping with <<- redirection

2015-09-13 Thread Philip Guenther
On Sun, Sep 13, 2015 at 8:46 AM, Alessandro DE LAURENZIS wrote: > The following patch would strip leading blank characters (instead of > tabs only) from the lines in the document when <<- redirection is > used (and should be useful when indentation is done with spaces): Nope. The just-strip-tabs