Re: systat/vmm

2017-02-27 Thread Reyk Floeter
On Sun, Feb 26, 2017 at 08:16:18PM +0100, Christian Barthel wrote: > Hi, > > I've added the 'vmctl status' view to systat(1). I am not sure if this > is of general interest. > > Any opinions about it? > At the first look, it seems to be a good thing. But from a technical standpoint I agr

Re: systat/vmm

2017-02-27 Thread Christian Barthel
Mike Larkin writes: > On Sun, Feb 26, 2017 at 08:16:18PM +0100, Christian Barthel wrote: >> Hi, >> >> I've added the 'vmctl status' view to systat(1). I am not sure if this >> is of general interest. >> >> Any opinions about it? > > I don't know what to think about systat using imsg to ta

Re: take PRU_ATTACH out of usrreq

2017-02-27 Thread Claudio Jeker
On Mon, Feb 27, 2017 at 10:22:03PM +0100, Alexander Bluhm wrote: > On Sun, Feb 26, 2017 at 10:56:16AM +0100, Claudio Jeker wrote: > > This diff works for me but I did not test each and every protocol (TCP, > > UDP, ICMP, AF_UNIX work). > > I am currently running it with all regression tests. > >

Re: systat/vmm

2017-02-27 Thread Mike Larkin
On Sun, Feb 26, 2017 at 08:16:18PM +0100, Christian Barthel wrote: > Hi, > > I've added the 'vmctl status' view to systat(1). I am not sure if this > is of general interest. > > Any opinions about it? I don't know what to think about systat using imsg to talk to other daemons. Is there a

Re: [PATCH] Use strcasestr(3) instead of nsearch()

2017-02-27 Thread Scott Cheloha
1 week bump. See prior mail for patch. Sorry if bumping your own patch is not kosher, this is my first patch. -- Scott Cheloha

ahci ncq error recovery

2017-02-27 Thread Jonathan Matthew
Various people have reported seeing kernel diagnostic assertion "ccb->ccb_xa.state == ATA_S_ONCHIP" panics with ahci. In short, this happens when a queued command fails, we ask the device which command fails, and it gives us the wrong answer. The ccb_xa.state assertion fails if the command was no

Re: vmd + httpd + meta-data

2017-02-27 Thread Kristaps Dzonsons
> I wrote this little tool for vmd that is not intended for the tree, > but will eventually go into ports (it uses kcgi which is not in base). Have you thought of writing this in a secure language like Rust or Swift? Writing cgi stuff in C seems just asking for trouble.

Re: take PRU_ATTACH out of usrreq

2017-02-27 Thread Alexander Bluhm
On Sun, Feb 26, 2017 at 10:56:16AM +0100, Claudio Jeker wrote: > This diff works for me but I did not test each and every protocol (TCP, > UDP, ICMP, AF_UNIX work). I am currently running it with all regression tests. > Also not sure if I should renumber the PRU_* defines... in a way this can > b

Re: Implement fork1_to_pid(). It's fork1(), but with pid as argument

2017-02-27 Thread Theo de Raadt
> I've now gone back and forth on this diff a few times. I like the > simplfication of allocpid(), but then it seems like deck-chair shuffling > as the test is just moved to another function. To me, it also feels like deckchair rearrangement. A special startup case condition (pid 1, and pid 0

Re: vmd 5/5: allow users to start VMs based on "ownership"

2017-02-27 Thread Mike Larkin
On Mon, Feb 27, 2017 at 11:05:55AM +0100, Reyk Floeter wrote: > Hi, > > this is the last diff of the series. It allows users to start or stop > VMs and to access the console accordingly. In order to make it work, > VMs have to be pre-configured with the new "owner" option in vm.conf > or an incl

Re: INSTALL.arm64: use larger blocks in dd example

2017-02-27 Thread Stuart Henderson
On 2017/02/28 00:30, Jonathan Gray wrote: > On Mon, Feb 27, 2017 at 10:50:35AM +, Stuart Henderson wrote: > > On 2017/02/27 21:37, Jonathan Gray wrote: > > > On Mon, Feb 27, 2017 at 09:54:33AM +, Stuart Henderson wrote: > > > > Using the current example (512-byte blocks): > > > > 18874368 b

Re: vmd 2/5: sort vmd.conf(5) alphabetically

2017-02-27 Thread Mike Larkin
On Mon, Feb 27, 2017 at 10:50:23AM +0100, Reyk Floeter wrote: > This is a no-brainer. But for the sake completeness: OK? > > Sort vm.conf(5) config options alphabetically > ok mlarkin > diff --git usr.sbin/vmd/vm.conf.5 usr.sbin/vmd/vm.conf.5 > index ccb59e7..9a48a51 100644 > --- usr.sbin/

Re: vmd 1/5: use fmt_scaled(3) in vmctl status output

2017-02-27 Thread Mike Larkin
On Mon, Feb 27, 2017 at 10:48:48AM +0100, Reyk Floeter wrote: > Hi, > > I have a serious of vmd diffs, see the 5th one for the interesting part. > The first one is rather cosmetic, but will be needed for the status output. > > Use fmt_scaled(3) in vmctl status output to print curmem/maxmem >

Re: vmd 4/5: replace openpty(4) with a local function

2017-02-27 Thread Nicholas Marriott
On Mon, Feb 27, 2017 at 12:00:30PM -0700, Theo de Raadt wrote: > > I think putting these in libutil is a good idea. tmux could use > > them. I'd like to have openptmfd() as you suggest as well - it'd be nice > > to hide PATH_PTMDEV as well as the PTMGET. > > > > Life would be a lot easier for port

relayd man page example doesn't parse

2017-02-27 Thread Michael W. Lucas
Running 5 February amd64 snapshot on VMWare. OpenBSD r1.mwlucas.org 6.0 GENERIC#162 amd64 Trying to use relayd's filtering on query strings. According to the man page, I can block or pass specific query terms, and values of those terms. Blocking the whole term works, but matching the query valu

Re: vmd 4/5: replace openpty(4) with a local function

2017-02-27 Thread Theo de Raadt
> To fully abstract /dev/ptm in libutil, the API below would have to be > extended to have another function to open /dev/ptm in libutil as well, > eg. (better names would be desired): > > fd = openptmfd() > pledge() > fdopenpty(fd, ...) > fdopenpty(fd, ...) > fdopenpt

Re: relayd man page example doesn't parse

2017-02-27 Thread Michael W. Lucas
And moments later, it hits me: pass request query "foo" value "bar" parses and works. The relayd.conf man page is in wrong. ==ml -- Michael W. LucasTwitter @mwlauthor nonfiction: https://www.michaelwlucas.com/ fiction: https://www.michaelwarrenlucas.com/ blog: http://blather.mic

Re: vmd 4/5: replace openpty(4) with a local function

2017-02-27 Thread Theo de Raadt
> I think putting these in libutil is a good idea. tmux could use > them. I'd like to have openptmfd() as you suggest as well - it'd be nice > to hide PATH_PTMDEV as well as the PTMGET. > > Life would be a lot easier for portable if there was fdforkpty() as > well. I agree. Are the -portable ver

Re: vmd 4/5: replace openpty(4) with a local function

2017-02-27 Thread Nicholas Marriott
Hi I think putting these in libutil is a good idea. tmux could use them. I'd like to have openptmfd() as you suggest as well - it'd be nice to hide PATH_PTMDEV as well as the PTMGET. Life would be a lot easier for portable if there was fdforkpty() as well. On Mon, Feb 27, 2017 at 07:00:03PM +0

vmd + httpd + meta-data

2017-02-27 Thread Reyk Floeter
Hi, I wrote this little tool for vmd that is not intended for the tree, but will eventually go into ports (it uses kcgi which is not in base). Summary: It allows to configure VMs on vmd in a cloud-init compatible way. I basically use it to test images that go out into the "real public cloud" lat

Re: vmd 4/5: replace openpty(4) with a local function

2017-02-27 Thread Reyk Floeter
On Mon, Feb 27, 2017 at 10:19:28AM -0700, Theo de Raadt wrote: > > On Mon, Feb 27, 2017 at 10:55:31AM +0100, Reyk Floeter wrote: > > > The following diff is not really needed without just yet, but: > > > - openening /dev/ptm in advance might allow better pledge in the future > > > - customizing "op

Re: vmd 4/5: replace openpty(4) with a local function

2017-02-27 Thread Theo de Raadt
> On Mon, Feb 27, 2017 at 10:55:31AM +0100, Reyk Floeter wrote: > > The following diff is not really needed without just yet, but: > > - openening /dev/ptm in advance might allow better pledge in the future > > - customizing "openpty" will allow to do what we need next > > Since openpty(4) is libut

Re: ssh_config.5: Remove ambigious dot

2017-02-27 Thread Jason McIntyre
On Mon, Feb 27, 2017 at 01:51:58PM +0100, Klemens Nanni wrote: > no is the default, not (yes or no). > fixed, thanks. jmc > diff --git a/usr.bin/ssh/ssh_config.5 b/usr.bin/ssh/ssh_config.5 > index 016adbc7343..799af3a4190 100644 > --- a/usr.bin/ssh/ssh_config.5 > +++ b/usr.bin/ssh/ssh_config.5 >

Re: INSTALL.arm64: use larger blocks in dd example

2017-02-27 Thread Jonathan Gray
On Mon, Feb 27, 2017 at 10:50:35AM +, Stuart Henderson wrote: > On 2017/02/27 21:37, Jonathan Gray wrote: > > On Mon, Feb 27, 2017 at 09:54:33AM +, Stuart Henderson wrote: > > > Using the current example (512-byte blocks): > > > 18874368 bytes transferred in 113.823 secs (165821 bytes/sec)

ssh_config.5: Remove ambigious dot

2017-02-27 Thread Klemens Nanni
no is the default, not (yes or no). diff --git a/usr.bin/ssh/ssh_config.5 b/usr.bin/ssh/ssh_config.5 index 016adbc7343..799af3a4190 100644 --- a/usr.bin/ssh/ssh_config.5 +++ b/usr.bin/ssh/ssh_config.5 @@ -1147,7 +1147,7 @@ However, this option disables host authentication for localhost. The argu

Re: INSTALL.arm64: use larger blocks in dd example

2017-02-27 Thread Stuart Henderson
On 2017/02/27 21:37, Jonathan Gray wrote: > On Mon, Feb 27, 2017 at 09:54:33AM +, Stuart Henderson wrote: > > Using the current example (512-byte blocks): > > 18874368 bytes transferred in 113.823 secs (165821 bytes/sec) > > > > Using bs=1m like we suggest in "Creating a bootable USB key using

Re: asr: support for RES_USE_DNSSEC

2017-02-27 Thread Peter J. Philipp
On Mon, Feb 27, 2017 at 11:14:13AM +0100, Jeremie Courreges-Anglas wrote: > "Peter J. Philipp" writes: > > > On Mon, Feb 27, 2017 at 10:26:48AM +0100, Peter J. Philipp wrote: > >> I had a patch somewhere for TSIG as well somewhere, give me some time to > >> find it. TSIG can secure the channel a

Re: INSTALL.arm64: use larger blocks in dd example

2017-02-27 Thread Jonathan Gray
On Mon, Feb 27, 2017 at 09:54:33AM +, Stuart Henderson wrote: > Using the current example (512-byte blocks): > 18874368 bytes transferred in 113.823 secs (165821 bytes/sec) > > Using bs=1m like we suggest in "Creating a bootable USB key using a > Un*x-like system": > 18874368 bytes transferred

Re: vmd 4/5: replace openpty(4) with a local function

2017-02-27 Thread Gilles Chehade
On Mon, Feb 27, 2017 at 10:55:31AM +0100, Reyk Floeter wrote: > The following diff is not really needed without just yet, but: > - openening /dev/ptm in advance might allow better pledge in the future > - customizing "openpty" will allow to do what we need next > Since openpty(4) is libutil and not

Re: asr: support for RES_USE_DNSSEC

2017-02-27 Thread Jeremie Courreges-Anglas
"Peter J. Philipp" writes: > On Mon, Feb 27, 2017 at 10:26:48AM +0100, Peter J. Philipp wrote: >> I had a patch somewhere for TSIG as well somewhere, give me some time to >> find it. TSIG can secure the channel as well, but my implementation wasn't >> all that pretty. > > Here is the patch, it w

Re: vmd 3/5: add size checks for control imsg

2017-02-27 Thread Gilles Chehade
On Mon, Feb 27, 2017 at 10:52:14AM +0100, Reyk Floeter wrote: > Reminder: using IMSG_SIZE_CHECK() in user-facing imsg handlers is a > bad thing as an invalid imsg would kill the daemon (via fatal). > > OK? > > Add size checks for imsg received over the control socket. > > Additionall

efiboot: boot device lookup typo

2017-02-27 Thread Patrick Wildt
Hi, in comparison to my usual diffs this is actually amd64 and not arm64. I'm surprised this didn't come up earlier, but I think the for-loop is a bit wrong. What the code is supposed to be doing is going over each device path node for the loaded image, which is supposed to be the path to the de

Re: asr: support for RES_USE_DNSSEC

2017-02-27 Thread Eric Faurot
ok eric@ On Sun, Feb 26, 2017 at 10:58:07PM +0100, Jeremie Courreges-Anglas wrote: > > Fine with me, here's a diff to introduce as_flags only, still on top of > the RES_USE_DNSSEC diff. > > > diff -x CVS -pruN asr.1/asr.c asr/asr.c > --- asr.1/asr.c Sat Feb 25 17:57:40 2017 > +++ asr/asr.

vmd 5/5: allow users to start VMs based on "ownership"

2017-02-27 Thread Reyk Floeter
Hi, this is the last diff of the series. It allows users to start or stop VMs and to access the console accordingly. In order to make it work, VMs have to be pre-configured with the new "owner" option in vm.conf or an included file. 1. Add a "owner user[:group]" in your vm block of vm.conf, eg.

vmd 4/5: replace openpty(4) with a local function

2017-02-27 Thread Reyk Floeter
The following diff is not really needed without just yet, but: - openening /dev/ptm in advance might allow better pledge in the future - customizing "openpty" will allow to do what we need next Since openpty(4) is libutil and not libc, it should be fine not using it. OK? Replace openpty(3) wi

INSTALL.arm64: use larger blocks in dd example

2017-02-27 Thread Stuart Henderson
Using the current example (512-byte blocks): 18874368 bytes transferred in 113.823 secs (165821 bytes/sec) Using bs=1m like we suggest in "Creating a bootable USB key using a Un*x-like system": 18874368 bytes transferred in 2.894 secs (6521502 bytes/sec) OK to change it? Index: arm64/prep ==

vmd 3/5: add size checks for control imsg

2017-02-27 Thread Reyk Floeter
Reminder: using IMSG_SIZE_CHECK() in user-facing imsg handlers is a bad thing as an invalid imsg would kill the daemon (via fatal). OK? Add size checks for imsg received over the control socket. Additionally, make sure that vmd never fatal()s when receiving an invalid imsg from a

vmd 2/5: sort vmd.conf(5) alphabetically

2017-02-27 Thread Reyk Floeter
This is a no-brainer. But for the sake completeness: OK? Sort vm.conf(5) config options alphabetically diff --git usr.sbin/vmd/vm.conf.5 usr.sbin/vmd/vm.conf.5 index ccb59e7..9a48a51 100644 --- usr.sbin/vmd/vm.conf.5 +++ usr.sbin/vmd/vm.conf.5 @@ -108,11 +108,6 @@ is specified. Do not start

vmd 1/5: use fmt_scaled(3) in vmctl status output

2017-02-27 Thread Reyk Floeter
Hi, I have a serious of vmd diffs, see the 5th one for the interesting part. The first one is rather cosmetic, but will be needed for the status output. Use fmt_scaled(3) in vmctl status output to print curmem/maxmem This matches the accepted input in vmctl start and vm.conf that

Re: asr: support for RES_USE_DNSSEC

2017-02-27 Thread Peter J. Philipp
On Mon, Feb 27, 2017 at 10:26:48AM +0100, Peter J. Philipp wrote: > I had a patch somewhere for TSIG as well somewhere, give me some time to > find it. TSIG can secure the channel as well, but my implementation wasn't > all that pretty. Here is the patch, it would need fixing up, and it only woul

Re: asr: support for RES_USE_DNSSEC

2017-02-27 Thread Peter J. Philipp
On Mon, Feb 27, 2017 at 10:19:52AM +0100, Jeremie Courreges-Anglas wrote: > > Thanks for considering my patch. OpenBSD tremendously improves with this > > work of yours, I'm all for it! However to make use of this DNSSEC mode, > > the channel to the recursive DNS server has to be absolutely sec

Re: asr: support for RES_USE_DNSSEC

2017-02-27 Thread Jeremie Courreges-Anglas
"Peter J. Philipp" writes: > On Mon, Feb 27, 2017 at 12:35:33AM +0100, Jeremie Courreges-Anglas wrote: >> Setting the AD flag for a query is possible, however those semantics are >> newer than the EDNS0 extension. As far as I know, rfc6840 introduced >> AD=1 for queries in 2013, whereas rfc3225

Re: armv7/omap: attach edma at fdt, re-enable

2017-02-27 Thread Ian Sutton
On Mon, Feb 27, 2017 at 08:08:16PM +1100, Jonathan Gray wrote: > There is only one with "ti,edma3-tpcc". Geez. It may be time to increase my font size. Index: conf/GENERIC === RCS file: /cvs/src/sys/arch/armv7/conf/GENERIC,v retrievi

Re: armv7/omap: attach edma at fdt, re-enable

2017-02-27 Thread Jonathan Gray
On Mon, Feb 27, 2017 at 04:05:45AM -0500, Ian Sutton wrote: > On Mon, Feb 27, 2017 at 07:59:07PM +1100, Jonathan Gray wrote: > > On Mon, Feb 27, 2017 at 03:34:35AM -0500, Ian Sutton wrote: > > > This patch changes edma(4) to attach via device tree and re-enables it. > > > > Looks like the line wra

Re: armv7/omap: attach edma at fdt, re-enable

2017-02-27 Thread Ian Sutton
On Mon, Feb 27, 2017 at 07:59:07PM +1100, Jonathan Gray wrote: > On Mon, Feb 27, 2017 at 03:34:35AM -0500, Ian Sutton wrote: > > This patch changes edma(4) to attach via device tree and re-enables it. > > Looks like the line wrapping got mangled. Yes, I had just sent a fixed version :) oops > I

Re: armv7/omap: attach edma at fdt, re-enable

2017-02-27 Thread Jonathan Gray
On Mon, Feb 27, 2017 at 03:55:12AM -0500, Ian Sutton wrote: > Previous patch was malformed, d'oh. > > Index: conf/GENERIC > === > RCS file: /cvs/src/sys/arch/armv7/conf/GENERIC,v > retrieving revision 1.71 > diff -u -p -r1.71 GENERIC

Re: armv7/omap: attach edma at fdt, re-enable

2017-02-27 Thread Jonathan Gray
On Mon, Feb 27, 2017 at 03:34:35AM -0500, Ian Sutton wrote: > This patch changes edma(4) to attach via device tree and re-enables it. Looks like the line wrapping got mangled. I don't see the point in testing ti,hwmods in match. > > > Index: conf/GENERIC > =

Re: armv7/omap: attach edma at fdt, re-enable

2017-02-27 Thread Ian Sutton
Previous patch was malformed, d'oh. Index: conf/GENERIC === RCS file: /cvs/src/sys/arch/armv7/conf/GENERIC,v retrieving revision 1.71 diff -u -p -r1.71 GENERIC --- conf/GENERIC23 Jan 2017 22:43:17 - 1.71 +++ conf/GENE

Re: asr: support for RES_USE_DNSSEC

2017-02-27 Thread Peter J. Philipp
On Mon, Feb 27, 2017 at 12:35:33AM +0100, Jeremie Courreges-Anglas wrote: > Setting the AD flag for a query is possible, however those semantics are > newer than the EDNS0 extension. As far as I know, rfc6840 introduced > AD=1 for queries in 2013, whereas rfc3225 specifies the DO flag since > 2001

Re: asr: support for RES_USE_DNSSEC

2017-02-27 Thread Gilles Chehade
On Mon, Feb 27, 2017 at 08:46:40AM +0100, Jeremie Courreges-Anglas wrote: > Jeremie Courreges-Anglas writes: > > > This flag is useful for software that wants to rely on the resolver to > > perform DNSSEC validation. Among the use cases there are DANE and SSHFP > > records, and the obvious inter

Re: Switch agtimer from physical timer to virtual timer.

2017-02-27 Thread Patrick Wildt
On Sun, Feb 26, 2017 at 10:35:17PM -0500, Dale Rahn wrote: > Switch agtimer from physical timer to virtual timer. > > This diff makes the arm generic timer for arm64 use the virtual > timer instead of the physical timer. > > Linux uses the virtual timer in the kernel unless it is operating in > h

armv7/omap: attach edma at fdt, re-enable

2017-02-27 Thread Ian Sutton
This patch changes edma(4) to attach via device tree and re-enables it. Index: conf/GENERIC === RCS file: /cvs/src/sys/arch/armv7/conf/GENERIC,v retrieving revision 1.71 diff -u -p -r1.71 GENERIC --- conf/GENERIC23 Jan 2017 2

Re: Implement fork1_to_pid(). It's fork1(), but with pid as argument

2017-02-27 Thread Tom Cosgrove
>>> Philip Guenther 27-Feb-17 06:09 >>> : > I've now gone back and forth on this diff a few times. I like the > simplfication of allocpid(), but then it seems like deck-chair shuffling > as the test is just moved to another function. > > But eliminating the magic-at-a-distance randompid frobbing