Re: assertion "_kernel_lock_held()" failed, uipc_socket2.c: ipsec

2017-11-12 Thread Martin Pieuchot
On 12/11/17(Sun) 22:10, Stuart Henderson wrote: > On 2017/11/12 22:48, Martin Pieuchot wrote: > > On 12/11/17(Sun) 21:30, Stuart Henderson wrote: > > > iked box, GENERIC.MP + WITNESS, -current as of Friday 10th: > > > > Weird, did you tweak "kern.splassert" on this box? Otherwise is looks > >

Re: try to bundle multiple packets on an ifq before sending

2017-11-12 Thread Martin Pieuchot
On 13/11/17(Mon) 10:56, David Gwynne wrote: > On Sun, Nov 12, 2017 at 02:45:05PM +0100, Martin Pieuchot wrote: > > [...] > > We're currently using net_tq() to distribute load for incoming packets. > > So I believe you should schedule the task on the current taskq or the > > first one if coming

Re: mbuf statistics, tracking of drops

2017-11-12 Thread Martin Pieuchot
On 13/11/17(Mon) 13:47, David Gwynne wrote: > On Sun, Nov 12, 2017 at 11:23:31PM +0100, Gregor Best wrote: > > Hi Martin, > > > > On Sun, Nov 12, 2017 at 03:40:59PM +0100, Martin Pieuchot wrote: > > > [...] > > > It does, some comments below. > > > [...] > > > > Wonderful. > > > > > [...] > > >

Re: mbuf statistics, tracking of drops

2017-11-12 Thread David Gwynne
On Sun, Nov 12, 2017 at 11:23:31PM +0100, Gregor Best wrote: > Hi Martin, > > On Sun, Nov 12, 2017 at 03:40:59PM +0100, Martin Pieuchot wrote: > > [...] > > It does, some comments below. > > [...] > > Wonderful. > > > [...] > > This would be an approximation because it might happen that after >

Re: try to bundle multiple packets on an ifq before sending

2017-11-12 Thread David Gwynne
On Sun, Nov 12, 2017 at 02:45:05PM +0100, Martin Pieuchot wrote: > On 10/11/17(Fri) 10:58, David Gwynne wrote: > > this makes ifq_start try to wait for 4 packets before calling > > if->if_qstart. > > So you're adding back the IFXF_TXREADY mechanism that you removed in > 2015 in r1.418. At that

Re: mbuf statistics, tracking of drops

2017-11-12 Thread Gregor Best
Hi Martin, On Sun, Nov 12, 2017 at 03:40:59PM +0100, Martin Pieuchot wrote: > [...] > It does, some comments below. > [...] Wonderful. > [...] > This would be an approximation because it might happen that after > returning NULL the second pool_get(9) won't sleep. However I think > it's the way

Re: assertion "_kernel_lock_held()" failed, uipc_socket2.c: ipsec

2017-11-12 Thread Stuart Henderson
On 2017/11/12 22:48, Martin Pieuchot wrote: > On 12/11/17(Sun) 21:30, Stuart Henderson wrote: > > iked box, GENERIC.MP + WITNESS, -current as of Friday 10th: > > Weird, did you tweak "kern.splassert" on this box? Otherwise is looks > like a major corruption. It would have kern.splassert=2. (I

Re: ofw_clock: reset_deassert and clock_enable order of use Qs

2017-11-12 Thread Artturi Alm
On Sat, Oct 07, 2017 at 10:16:05AM +0300, Artturi Alm wrote: > Hi, > > > what was the cause of these delays? i just spotted this, so untested on > likely more affected HW(sunxi A64/H3 and rockchips), but just for discussion > about the delays/ordering? are they really needed like that? > > i

Re: assertion "_kernel_lock_held()" failed, uipc_socket2.c: ipsec

2017-11-12 Thread Martin Pieuchot
On 12/11/17(Sun) 21:30, Stuart Henderson wrote: > iked box, GENERIC.MP + WITNESS, -current as of Friday 10th: Weird, did you tweak "kern.splassert" on this box? Otherwise is looks like a major corruption. > login: panic: kernel diagnostic assertion "_kernel_lock_held()" failed: file >

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2017-11-12 Thread Klemens Nanni
On Sun, Nov 12, 2017 at 09:04:22PM +, Robert Peichaer wrote: > Hmm. I see. > > The {add,del,no,pre}_path functions are in ksh.kshrc since when it was > imported 21 years ago. If they would be used in ksh.kshrc or anywhere > else, I'd say it might be worth "fixing" these functions. But they

armv7/sxie: unused global

2017-11-12 Thread Artturi Alm
Hi, one less useless leftover. -Artturi diff --git a/sys/arch/armv7/sunxi/sxie.c b/sys/arch/armv7/sunxi/sxie.c index 0e062bac1fb..2ac4dda7c6b 100644 --- a/sys/arch/armv7/sunxi/sxie.c +++ b/sys/arch/armv7/sunxi/sxie.c @@ -168,8 +168,6 @@ struct sxie_softc { uint32_t

Re: armv7/sxie: less ierror

2017-11-12 Thread Artturi Alm
On Sun, Nov 12, 2017 at 07:07:13PM +0100, Mark Kettenis wrote: > > Date: Sun, 12 Nov 2017 04:58:23 +0200 > > From: Artturi Alm > > > > Hi, > > > > i'm likely responsible, for having sent the diff that introduced this. > > minimal fix taken w/diff -U10, to show the obvious

Re: Add sizes for free() in the VIA PadLock driver

2017-11-12 Thread Mike Belopuhov
On Sun, Nov 12, 2017 at 21:53 +0100, Frederic Cambus wrote: > Hi tech@, > > Add sizes for free() in the VIA PadLock driver. > > Comments? OK? > OK mikeb.

assertion "_kernel_lock_held()" failed, uipc_socket2.c: ipsec

2017-11-12 Thread Stuart Henderson
iked box, GENERIC.MP + WITNESS, -current as of Friday 10th: login: panic: kernel diagnostic assertion "_kernel_lock_held()" failed: file "/src/cvs-openbsd/sys/kern/uipc_socket2.c", line 310 splassert: soassertlocked: want 1 have 256 panic: spl assertion failure in soassertlocked Starting stack

Re: ksh.kshrc: Fix quoting in {add,pre,del}_path() to work with spaces

2017-11-12 Thread Robert Peichaer
On Sun, Nov 12, 2017 at 12:22:27AM +0100, Klemens Nanni wrote: > On Sat, Nov 11, 2017 at 08:03:36PM +, Robert Peichaer wrote: > > On Sat, Nov 11, 2017 at 08:11:25PM +0100, Klemens Nanni wrote: > > > pre_path()ing directories with spaces is broken due to bad quoting. > > > > > > This diff

Add sizes for free() in the VIA PadLock driver

2017-11-12 Thread Frederic Cambus
Hi tech@, Add sizes for free() in the VIA PadLock driver. Comments? OK? Index: sys/arch/amd64/amd64/via.c === RCS file: /cvs/src/sys/arch/amd64/amd64/via.c,v retrieving revision 1.24 diff -u -p -r1.24 via.c ---

Re: armv7/sxie: less ierror

2017-11-12 Thread Mark Kettenis
> Date: Sun, 12 Nov 2017 04:58:23 +0200 > From: Artturi Alm > > Hi, > > i'm likely responsible, for having sent the diff that introduced this. > minimal fix taken w/diff -U10, to show the obvious dup++. > > -Artturi I think it makes more sense to fix it this way: ok?

__warn_references: drop redundant "warning: " prefix

2017-11-12 Thread Scott Cheloha
Hi, GNU ld has prefixed the contents of .gnu.warning.SYMBOL sections with "warning: " since 2003, so the messages themselves need not contain the prefix anymore. If LLVM ld ever acknowledges .gnu.warning sections I imagine it would emulate this behavior. Thoughts? -- Scott Cheloha Index:

Re: mbuf statistics, tracking of drops

2017-11-12 Thread Martin Pieuchot
On 11/11/17(Sat) 13:05, Gregor Best wrote: > Hi people, > > while reading around in /sys/kern/uipc_mbuf.c to try to track down a > problem with my iwm(4) that seems to correlate with mbuf allocation > failures, I noticed that the MBSTAT_DROPS counter and its friends > MBSTAT_{WAIT,DRAIN} don't

18 year old #if 0

2017-11-12 Thread Martin Pieuchot
Now that they can drink in many countries, let them go away... ok? Index: netinet6/frag6.c === RCS file: /cvs/src/sys/netinet6/frag6.c,v retrieving revision 1.79 diff -u -p -r1.79 frag6.c --- netinet6/frag6.c7 Nov 2017 16:47:07

Re: try to bundle multiple packets on an ifq before sending

2017-11-12 Thread Martin Pieuchot
On 10/11/17(Fri) 10:58, David Gwynne wrote: > this makes ifq_start try to wait for 4 packets before calling > if->if_qstart. So you're adding back the IFXF_TXREADY mechanism that you removed in 2015 in r1.418. At that time we couldn't clearly see how to make it MP-safe. > this is based on work

Re: libfuse: signal handler doesn't cater for "Device busy" and other errors

2017-11-12 Thread Martin Pieuchot
On 12/11/17(Sun) 04:36, Helg Bredow wrote: > On Fri, 10 Nov 2017 11:55:53 + > Helg Bredow wrote: > > > On Fri, 10 Nov 2017 10:13:35 +0100 > > Anton Lindqvist wrote: > > > > > On Fri, Nov 10, 2017 at 09:36:25AM +0100, Martin Pieuchot wrote: > > > > On

Re: Remove commented out pledge in tsort

2017-11-12 Thread Marc Espie
On Sun, Nov 12, 2017 at 11:08:54AM +, George Brown wrote: > Removes commented out pledge with whitelist, this is the only instance I > found of this grep'ing through base. > > diff --git usr.bin/tsort/tsort.c usr.bin/tsort/tsort.c > index 5caa733f4..cc1cba164 100644 > ---

Remove commented out pledge in tsort

2017-11-12 Thread George Brown
Removes commented out pledge with whitelist, this is the only instance I found of this grep'ing through base. diff --git usr.bin/tsort/tsort.c usr.bin/tsort/tsort.c index 5caa733f4..cc1cba164 100644 --- usr.bin/tsort/tsort.c +++ usr.bin/tsort/tsort.c @@ -879,7 +879,6 @@ parse_args(int argc, char

/usr/share/calendar/calendar.christian - two entries for "First Sunday of Advent (4th Sunday before Christmas)"

2017-11-12 Thread Raf Czlonka
Hi all, I've just noticed something strange in the /usr/share/calendar/calendar.christian file, namely: 11/SunLast First Sunday of Advent (4th Sunday before Christmas) 12/SunFirst First Sunday of Advent (4th Sunday before Christmas) Obviously, in any given year either