Re: npppd(8): errror -> error

2019-02-21 Thread Jason McIntyre
On Thu, Feb 21, 2019 at 08:59:23PM +0100, Alessandro Gallo wrote: > Hello, > > I've found a small typo in npppd(8): > fixed, thanks. jmc > Index: l2tp/l2tpd.c > === > RCS file: /cvs/src/usr.sbin/npppd/l2tp/l2tpd.c,v > retrieving re

lockf: initialization order

2019-02-21 Thread Anton Lindqvist
Hi, Initialize the fields of `struct lockf' in the same order as the struct definition, with the ambition of making easier to inspect that all fields are properly initialized. Similar work has already been done in lf_split(). Comments? OK? Index: kern/vfs_lockf.c =

a manpage for pci_mapreg_map

2019-02-21 Thread David Gwynne
plus some related functions. i didnt know which of the int arguments is used as the flags argument to the bus_space_map call it wraps. students tell me that having to read the source code instead of some doco is literally (figuratively) the worst, so here's some doco so i don't have to read the co

Re: bypass interface input queues for vlan(4)

2019-02-21 Thread David Gwynne
On Thu, Feb 21, 2019 at 04:29:27PM -0300, Martin Pieuchot wrote: > On 21/02/19(Thu) 14:19, David Gwynne wrote: > > right now we add vlan_input as a possible input handler on the parent > > interface, and if the packet is for a vlan we take it and pretend we > > received it on the vlan interface by

Re: rip_usrreq() style tweak

2019-02-21 Thread Michael Mikonos
On Thu, Feb 21, 2019 at 04:58:08PM +0100, Jeremie Courreges-Anglas wrote: > On Thu, Feb 21 2019, Michael Mikonos wrote: > > Hello, > > > > Is it OK to merge the PRU_CONNECT2 case into the generic > > "not supported" case in {rip,rip6}_usrreq()? > > If anything this allows the reader to see all the

Re: update ctype data to unicode 10

2019-02-21 Thread Andrew Hewus Fresh
On Fri, Feb 22, 2019 at 01:57:01AM +0200, Lauri Tirkkonen wrote: > Hi, the recent perl-5.28.1 and related unicore update brought the > unicode data from version 8.0.0 to version 10.0.0. That fixes some > character classifications (eg. emoji characters gained East_Asian_Width > value 'Wide', which c

pfctl should allow administrator to flush _anchors

2019-02-21 Thread Alexandr Nedvedicky
Hello, This issue has been reported by one of our customers. consider pf.conf comes with rules as follows: anchor { pass all anchor { block all } } We load pf.conf to kernel and (pfctl -f pf.conf) and display what got loaded:

update ctype data to unicode 10

2019-02-21 Thread Lauri Tirkkonen
Hi, the recent perl-5.28.1 and related unicore update brought the unicode data from version 8.0.0 to version 10.0.0. That fixes some character classifications (eg. emoji characters gained East_Asian_Width value 'Wide', which causes them to correctly get a wcwidth() of 2). But the ctype source data

Re: more mem for dirhash

2019-02-21 Thread Mark Kettenis
> From: "Ted Unangst" > Date: Thu, 21 Feb 2019 17:25:09 -0500 > > Jeremie Courreges-Anglas wrote: > > I may be naive, but shouldn't dirhash memory be accounted with/like > > buffer cache memory (freed when other sybsystems need it)? > > Probably. The limit exists in part because there is no back

Re: more mem for dirhash

2019-02-21 Thread Ted Unangst
Jeremie Courreges-Anglas wrote: > I may be naive, but shouldn't dirhash memory be accounted with/like > buffer cache memory (freed when other sybsystems need it)? Probably. The limit exists in part because there is no backpressure.

npppd(8): errror -> error

2019-02-21 Thread Alessandro Gallo
Hello, I've found a small typo in npppd(8): Index: l2tp/l2tpd.c === RCS file: /cvs/src/usr.sbin/npppd/l2tp/l2tpd.c,v retrieving revision 1.20 diff -u -p -u -p -r1.20 l2tpd.c --- l2tp/l2tpd.c6 Oct 2017 07:46:44 - 1.2

Re: bypass interface input queues for vlan(4)

2019-02-21 Thread Martin Pieuchot
On 21/02/19(Thu) 14:19, David Gwynne wrote: > right now we add vlan_input as a possible input handler on the parent > interface, and if the packet is for a vlan we take it and pretend we > received it on the vlan interface by calling if_input against that mbuf. > > as mpi notes, the if input queue

Re: ioctls for MPLS pseudowire interface config

2019-02-21 Thread Martin Pieuchot
On 21/02/19(Thu) 07:35, David Gwynne wrote: > > On 20 Feb 2019, at 11:21 pm, Martin Pieuchot wrote: > > > > On 20/02/19(Wed) 14:44, David Gwynne wrote: > >> Index: sys/net/if.c > >> === > >> RCS file: /cvs/src/sys/net/if.c,v > >> ret

Re: more mem for dirhash

2019-02-21 Thread Jeremie Courreges-Anglas
On Thu, Feb 21 2019, "Todd C. Miller" wrote: > On Wed, 20 Feb 2019 17:00:23 -0500, "Ted Unangst" wrote: > >> I picked a new limit of 5MB. This allows for my one very large directory, a >> few additional directories, and some spare room. It's also still reasonably >> conservative imo. > > Yes pleas

iked(8): fix the sending of certain IPv6 addresses in the configuration payload

2019-02-21 Thread Aram Hăvărneanu
This change fixes the sending of INTERNAL_IP6_DNS, INTERNAL_IP6_DHCP (RFC5996); INTERNAL_IP6_NBNS (RFC4306); and INTERNAL_IP6_SERVER (MS-IKEE). Prior to this fix the data sent to clients was garbled. Index: ikev2.c === RCS file: /cvs

Re: more mem for dirhash

2019-02-21 Thread Todd C . Miller
On Wed, 20 Feb 2019 17:00:23 -0500, "Ted Unangst" wrote: > I picked a new limit of 5MB. This allows for my one very large directory, a > few additional directories, and some spare room. It's also still reasonably > conservative imo. Yes please, this makes a huge difference with my email dirs ;-)

Re: rip_usrreq() style tweak

2019-02-21 Thread Jeremie Courreges-Anglas
On Thu, Feb 21 2019, Michael Mikonos wrote: > Hello, > > Is it OK to merge the PRU_CONNECT2 case into the generic > "not supported" case in {rip,rip6}_usrreq()? > If anything this allows the reader to see all the > unsupported requests in one place. ok with me, one tweak, > - Michael > > > Index

Re: xhci: set chain bit in link TRBs

2019-02-21 Thread Peter Hessler
On 2019 Feb 21 (Thu) at 16:19:22 +0100 (+0100), Patrick Wildt wrote: :On Thu, Feb 21, 2019 at 03:56:57PM +0100, Stefan Sperling wrote: :> On Thu, Feb 21, 2019 at 10:50:40AM +0100, Patrick Wildt wrote: :> > Hi, :> > :> > on my i.MX8M machine which features a DWC3 xHCI 1.10 controller I have :> > se

Re: sysctl sensor error handling

2019-02-21 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.02.21 15:55:42 +0100: > Hi, > > I had an hanging sysctl(8) that was compiled with an obsolete header > file. Struct sensordev was too small, so sysctl(2) failed with > ENOMEM. But the sysctl(8) program continued with unitialized memory. > > # sys

Re: xhci: set chain bit in link TRBs

2019-02-21 Thread Patrick Wildt
On Thu, Feb 21, 2019 at 03:56:57PM +0100, Stefan Sperling wrote: > On Thu, Feb 21, 2019 at 10:50:40AM +0100, Patrick Wildt wrote: > > Hi, > > > > on my i.MX8M machine which features a DWC3 xHCI 1.10 controller I have > > seen this error while installing base64.tgz or running fsck: > > > > umass0:

Re: xhci: set chain bit in link TRBs

2019-02-21 Thread Stefan Sperling
On Thu, Feb 21, 2019 at 10:50:40AM +0100, Patrick Wildt wrote: > Hi, > > on my i.MX8M machine which features a DWC3 xHCI 1.10 controller I have > seen this error while installing base64.tgz or running fsck: > > umass0: Invalid CSW: sig 0x43425355 should be 0x53425355 > > As it turns out using a

sysctl sensor error handling

2019-02-21 Thread Alexander Bluhm
Hi, I had an hanging sysctl(8) that was compiled with an obsolete header file. Struct sensordev was too small, so sysctl(2) failed with ENOMEM. But the sysctl(8) program continued with unitialized memory. # sysctl hw ... hw.diskcount=2 hw.sensors..temp0=33.00 degC --> here it hangs in an endles

Re: bsd.{prog,lib}.mk: drop -S for install

2019-02-21 Thread Lauri Tirkkonen
On Thu, Feb 21 2019 13:47:55 +0100, Klemens Nanni wrote: > There's more: > > $ find /usr/src -type f -name Makefile -exec grep -F -- -S {} + | grep -Fi > install > /usr/src/gnu/usr.bin/cc/c++/Makefile: ${INSTALL} ${INSTALL_COPY} -S > ${INSTALL_STRIP} \ > /usr/src/gnu/usr.bin/cc/cc/Makefile:

bsd.{prog,lib}.mk: drop -S for install

2019-02-21 Thread Lauri Tirkkonen
now that install -S is always enabled, no need to specify it in mk files. diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk index a7689506a58..baca99ae45b 100644 --- a/share/mk/bsd.lib.mk +++ b/share/mk/bsd.lib.mk @@ -274,7 +274,7 @@ beforeinstall: realinstall: # ranlib lib${LIB}.a -

bgpd, if_media and link state

2019-02-21 Thread Claudio Jeker
So util.c has a few functions to pretty print interface information like media and link state. These functions are highly system specific and only used by kroute.c and in bgpctl to show kroute internals. This diffs creates a ctl_show_interface struct used in the imsgs between bgpd and bgpctl. The m

xhci: set chain bit in link TRBs

2019-02-21 Thread Patrick Wildt
Hi, on my i.MX8M machine which features a DWC3 xHCI 1.10 controller I have seen this error while installing base64.tgz or running fsck: umass0: Invalid CSW: sig 0x43425355 should be 0x53425355 As it turns out using a USB protocol analyzer, the transfers actually seem fine, the USB mass storage i

rip_usrreq() style tweak

2019-02-21 Thread Michael Mikonos
Hello, Is it OK to merge the PRU_CONNECT2 case into the generic "not supported" case in {rip,rip6}_usrreq()? If anything this allows the reader to see all the unsupported requests in one place. - Michael Index: netinet/raw_ip.c ===