Re: kdump futex fix

2020-04-04 Thread Philip Guenther
On Sat, 4 Apr 2020, Martin Pieuchot wrote: > On 03/04/20(Fri) 19:26, Philip Guenther wrote: > > On Fri, 3 Apr 2020, Martin Pieuchot wrote: > > > Depending on the operation requested futex(2) might return the number of > > > woken threads or an error. That means the following... > > > > > > mpv

Re: split futex into three

2020-04-04 Thread Philip Guenther
On Sat, 4 Apr 2020, Paul Irofti wrote: > Here is a proper diff (both sys and libc into one). Okay, bunch o' comments and thoughts of varying strength of opinion. > diff --git lib/libc/Symbols.list lib/libc/Symbols.list > index f9aa62ab6e8..4fa37a835aa 100644 > --- lib/libc/Symbols.list > +++

Re: iked(8): simplify data in sc_sock4 and sc_sock6

2020-04-04 Thread Wataru Ashihara
> +/** > + * The first call of this function sets the UDP socket for IKE_INIT. This was "/*", not "/**". sorry. > -#define IKED_OPT_NONATT 0x0004 > -#define IKED_OPT_NATT0x0008 > -#define IKED_OPT_PASSIVE 0x0010 > +#define IKED_OPT_PASSIVE

ntpd: prevent duplicate definitions of `conf` and `ibus_dns`

2020-04-04 Thread Michael Forney
This prevents a linking error with gcc 10, which enables -fno-common by default. ISO C requires exactly one definition of objects with external linkage throughout the entire program. `conf` is already defined in ntpd.c and declared extern in ntpd.h, so the definition in parse.y is redundant.

sparc64 clang fixes

2020-04-04 Thread Mark Kettenis
So regress/lib/libm/msun/run-conj_test fails because clang emits fmovqne instructions. Those instructions aren't actually implemented and since we don't emulate them in our kernel the test gets killed with SIGILL. The compiler isn't suppose to emit the instructions unless they are explicitly

Re: Fix pipex(4) pipex_ioctl() access to not owned sessions (kernel crash too)

2020-04-04 Thread Vitaliy Makkoveev
On Sat, Apr 04, 2020 at 06:52:49PM +0200, Martin Pieuchot wrote: > On 02/04/20(Thu) 13:44, Vitaliy Makkoveev wrote: > > This diff add ownership checks to the rest pipex_ioctl() commands. A few > > words about pppx_get_closed(): since in-kernel timeout feature was > > disabled for pppx(4) related

Re: [patch]: Change kern_unveil to [] array derefs

2020-04-04 Thread Ingo Schwarze
Hi Martin, Martin Vahlensieck wrote on Sat, Apr 04, 2020 at 07:16:46PM +0200: > This makes these array derefs consistent with the others in the file. > Also I believe this is the preferred way to do this. That depends. In mandoc, i certainly prefer "pointer + offset" over "[offest]", arguing

[patch]: Change kern_unveil to [] array derefs

2020-04-04 Thread Martin Vahlensieck
Hi! This makes these array derefs consistent with the others in the file. Also I believe this is the preferred way to do this. Best, Martin Index: kern_unveil.c === RCS file: /cvs/src/sys/kern/kern_unveil.c,v retrieving revision

iked(8): simplify data in sc_sock4 and sc_sock6

2020-04-04 Thread Wataru Ashihara
The data wich sc_sock4 has is a little bit complicated: sc_sock4[0], sc_sock6[0] sc_sock4[1], sc_sock6[1]

Re: Fix pipex(4) pipex_ioctl() access to not owned sessions (kernel crash too)

2020-04-04 Thread Martin Pieuchot
On 02/04/20(Thu) 13:44, Vitaliy Makkoveev wrote: > This diff add ownership checks to the rest pipex_ioctl() commands. A few > words about pppx_get_closed(): since in-kernel timeout feature was > disabled for pppx(4) related pipex_sessions, closed pipex_sessions can't > exist in system, so this

Re: split futex into three

2020-04-04 Thread Paul Irofti
Here is a proper diff (both sys and libc into one). diff --git lib/libc/Symbols.list lib/libc/Symbols.list index f9aa62ab6e8..4fa37a835aa 100644 --- lib/libc/Symbols.list +++ lib/libc/Symbols.list @@ -86,7 +86,10 @@ _thread_sys_fstatat _thread_sys_fstatfs _thread_sys_fsync

split futex into three

2020-04-04 Thread Paul Irofti
On Sat, Apr 04, 2020 at 03:53:50PM +0300, Paul Irofti wrote: > > The real problem is that futex(2) is actually 3 different syscalls wrapped > > into one. It was split into three then kdump could properly report > > futex_wake(2) and futex_requeue(2) as returning a count, while > >

Re: [PATCH 1/2] gost: add missing error reporting

2020-04-04 Thread Dmitry Baryshkov
Hello, сб, 28 мар. 2020 г. в 17:20, Kinichiro Inoguchi : > > I had checked this by portable build and all regresses passed. > I'm ok with this diff. Thank you! Any further actions required from my side? > On Thu, Mar 26, 2020 at 09:28:01PM +0300, dbarysh...@gmail.com wrote: > > From: Dmitry

Re: EV_SET(2) shadows variable

2020-04-04 Thread Theo de Raadt
Philip Guenther wrote: > On Fri, 3 Apr 2020, Martin Pieuchot wrote: > > Thanks, here it is, ok? > > ok guenther@ Should we do the same to all other macros, just in case?

Change knote list head type

2020-04-04 Thread Visa Hankala
Below is a mostly mechanical patch that wraps the SLIST head of knotes inside another struct. The patch also introduces functions for adding and removing knotes from these lists. My intent is to extend the list struct so that the system can assert when the knote list should be locked. The idea is

Re: kdump futex fix

2020-04-04 Thread Paul Irofti
> The real problem is that futex(2) is actually 3 different syscalls wrapped > into one. It was split into three then kdump could properly report > futex_wake(2) and futex_requeue(2) as returning a count, while > futex_wait(2) returns an errno. The existing 'switch' in sys_futex() > would

Re: kdump futex fix

2020-04-04 Thread Martin Pieuchot
On 03/04/20(Fri) 19:26, Philip Guenther wrote: > On Fri, 3 Apr 2020, Martin Pieuchot wrote: > > Depending on the operation requested futex(2) might return the number of > > woken threads or an error. That means the following... > > > > mpv CALL > > futex(0xa58935899b0,0x82,1,0,0) > > mpv