Undefined Behavior at jsmn.c

2020-07-11 Thread Ali Farzanrad
Hi @tech, I was comparing jsmn.c in acme-client with jsmn.c in FreeBSD [1]. I found a switch without a default case which is an undefined behavior: @@ -69,6 +69,8 @@ case '\t' : case '\r' : case '\n' : case ' ' : case ',' : case ']' : case '}' :

Re: readlink "/etc/localtime" vs unveil

2020-07-11 Thread Theo de Raadt
Todd C. Miller wrote: > On Sat, 11 Jul 2020 13:35:57 -0700, Greg Steuck wrote: > > > The problem seems to be due to Chromium doing a readlink (likely at > > [1]) on /etc/localtime, which fails. There's a workaround that > > happens to work for chromium (and firefox). Just set TZ in your > > env

Re: readlink "/etc/localtime" vs unveil

2020-07-11 Thread Theo de Raadt
Greg Steuck wrote: > The problem seems to be due to Chromium doing a readlink (likely at > [1]) on /etc/localtime, which fails. If that is what it is doing, then it should stop doing so.

Re: readlink "/etc/localtime" vs unveil

2020-07-11 Thread Todd C . Miller
On Sat, 11 Jul 2020 13:35:57 -0700, Greg Steuck wrote: > The problem seems to be due to Chromium doing a readlink (likely at > [1]) on /etc/localtime, which fails. There's a workaround that > happens to work for chromium (and firefox). Just set TZ in your > environment. You could just add a call

Re: arm64 usertc

2020-07-11 Thread Christian Weisgerber
Mark Kettenis: > Nevertheless, here is a different take on the problem. Since the > timecounter only uses the low 32 bits we don't need the double read. > This version also changes the timecounter mask from 0x7fff to > 0x. That must be ok, since the counter has 64 bits and we are > al

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-11 Thread Marcus Glocker
On Sat, 11 Jul 2020 20:14:03 +0200 Marcus Glocker wrote: > On Sat, 11 Jul 2020 11:56:38 +0200 > Marcus Glocker wrote: > > > On Fri, 10 Jul 2020 14:32:47 +0200 > > Marcus Glocker wrote: > > > > > On Fri, 10 Jul 2020 14:19:00 +0200 > > > Patrick Wildt wrote: > > > > > > > On Fri, Jul 10

Re: pppac(4): fix races in pppacopen()

2020-07-11 Thread Vitaliy Makkoveev
On Sat, Jul 11, 2020 at 10:11:03AM +0200, Martin Pieuchot wrote: > On 10/07/20(Fri) 14:38, Vitaliy Makkoveev wrote: > > On Fri, Jul 10, 2020 at 01:22:40PM +0200, Martin Pieuchot wrote: > > > On 10/07/20(Fri) 14:07, Vitaliy Makkoveev wrote: > > > > We have some races in pppac(4) > > > > 1. malloc(9)

readlink "/etc/localtime" vs unveil

2020-07-11 Thread Greg Steuck
Hi Bob, I noticed file times in chromium file open dialog (Ctrl-O) are displayed in UTC instead of the local timezone (same in firefox). Given that pledge goes out of its way to make localtime work we might want to fix this. The problem seems to be due to Chromium doing a readlink (likely at [1])

Re: arm64 usertc

2020-07-11 Thread Mark Kettenis
> Date: Thu, 9 Jul 2020 11:29:05 -0500 > From: Scott Cheloha > Cc: tech@openbsd.org > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > On Thu, Jul 09, 2020 at 10:35:46AM +0200, Mark Kettenis wrote: > > > > Here is the arm64 version. Again I've taken the approach of c

typo in www/faq/current.html - libxkbui...

2020-07-11 Thread Larry Hynes
Hi # rm /usr/X11R6/include/extenstions/XKBui.h does not look right to me. 1. The spelling of extensions is incorrect 2. I think /usr/X11R6/include/X11/extensions/XKBui.h is the correct path Index: faq/current.html === RC

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-11 Thread Marcus Glocker
On Sat, 11 Jul 2020 11:56:38 +0200 Marcus Glocker wrote: > On Fri, 10 Jul 2020 14:32:47 +0200 > Marcus Glocker wrote: > > > On Fri, 10 Jul 2020 14:19:00 +0200 > > Patrick Wildt wrote: > > > > > On Fri, Jul 10, 2020 at 01:00:31PM +0200, Marcus Glocker wrote: > > > > > > > Hi All, > > > >

Re: fix wpa rsngroupcipher displayed by ifconfig

2020-07-11 Thread Mark Kettenis
> Date: Sat, 11 Jul 2020 19:29:17 +0200 > From: Stefan Sperling > > When a wifi interface acts as a client, ifconfig will currently display > the default value 'ccmp' for the wpagroupcipher parameter, even while > associated to a WPA2 access point which uses TKIP as the group cipher > for WPA1 co

fix wpa rsngroupcipher displayed by ifconfig

2020-07-11 Thread Stefan Sperling
When a wifi interface acts as a client, ifconfig will currently display the default value 'ccmp' for the wpagroupcipher parameter, even while associated to a WPA2 access point which uses TKIP as the group cipher for WPA1 compatibility. This patch updates the variable which gets copied out when ifc

Re: typo in www/faq/current.html - libxkbui...

2020-07-11 Thread Matthieu Herrb
On Sat, Jul 11, 2020 at 03:19:46PM +0100, Larry Hynes wrote: > Hi > > # rm /usr/X11R6/include/extenstions/XKBui.h > > does not look right to me. > > 1. The spelling of extensions is incorrect > 2. I think /usr/X11R6/include/X11/extensions/XKBui.h >is the correct path Fixed. Thanks for

Re: [PATCH] fast conditional console scrolling

2020-07-11 Thread Frederic Cambus
On Fri, Jul 10, 2020 at 03:26:16PM +0200, Frederic Cambus wrote: > On Fri, Jun 26, 2020 at 07:49:55AM -0700, jo...@armadilloaerospace.com wrote: > > I should have been more rigorous -- I had two different changes running > > on my system, as well as forcing it to use the 12x24 font for a 160x45 > >

Re: pipex(4): kill pipexintr()

2020-07-11 Thread Vitaliy Makkoveev
On Fri, Jul 10, 2020 at 10:54:44AM +0200, Martin Pieuchot wrote: > On 07/07/20(Tue) 01:01, Vitaliy Makkoveev wrote: > > On Mon, Jul 06, 2020 at 08:47:23PM +0200, Martin Pieuchot wrote: > > > On 06/07/20(Mon) 19:23, Vitaliy Makkoveev wrote: > > > > > On 6 Jul 2020, at 17:36, Martin Pieuchot wrote:

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-07-11 Thread Mark Kettenis
> From: Paul Irofti > Date: Sat, 11 Jul 2020 13:50:37 +0300 > > On 2020-07-11 13:46, Mark Kettenis wrote: > >> From: Paul Irofti > >> Date: Sat, 11 Jul 2020 13:32:22 +0300 > >> > >> Hi, > >> > >> Getting lots of messages about people loving the new timekeep > >> functionality, which I am very ha

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-07-11 Thread Paul Irofti
On 2020-07-11 13:46, Mark Kettenis wrote: From: Paul Irofti Date: Sat, 11 Jul 2020 13:32:22 +0300 Hi, Getting lots of messages about people loving the new timekeep functionality, which I am very happy about, but also some that have the skew too large for it to be enabled. I plan on sending a

Re: timekeep: fixing large skews on amd64 with RDTSCP

2020-07-11 Thread Mark Kettenis
> From: Paul Irofti > Date: Sat, 11 Jul 2020 13:32:22 +0300 > > Hi, > > Getting lots of messages about people loving the new timekeep > functionality, which I am very happy about, but also some that have the > skew too large for it to be enabled. > > I plan on sending a diff next week to impr

Re: change some drm locks from IPL_TTY to IPL_NONE

2020-07-11 Thread Mark Kettenis
> Date: Sat, 11 Jul 2020 14:45:44 +1000 > From: Jonathan Gray > > In drm linux spinlocks are mapped to mutex(9). > > Locks without calls to spin_lock_irqsave(), spin_lock_irq() and the like > (which block interrupts) can be changed to IPL_NONE. This shouldn't really make a difference, although

timekeep: fixing large skews on amd64 with RDTSCP

2020-07-11 Thread Paul Irofti
Hi, Getting lots of messages about people loving the new timekeep functionality, which I am very happy about, but also some that have the skew too large for it to be enabled. I plan on sending a diff next week to improve the situation via RDTSCP on the machines that have it. Which is basical

Re: xhci(4) isoc: fix bogus handling of chained TRBs

2020-07-11 Thread Marcus Glocker
On Fri, 10 Jul 2020 14:32:47 +0200 Marcus Glocker wrote: > On Fri, 10 Jul 2020 14:19:00 +0200 > Patrick Wildt wrote: > > > On Fri, Jul 10, 2020 at 01:00:31PM +0200, Marcus Glocker wrote: > > > Hi All, > > > > > > Laurence Tratt was reporting about corrupted video images when > > > using uvid

Re: pppac(4): fix races in pppacopen()

2020-07-11 Thread Martin Pieuchot
On 10/07/20(Fri) 14:38, Vitaliy Makkoveev wrote: > On Fri, Jul 10, 2020 at 01:22:40PM +0200, Martin Pieuchot wrote: > > On 10/07/20(Fri) 14:07, Vitaliy Makkoveev wrote: > > > We have some races in pppac(4) > > > 1. malloc(9) can sleep so we must check `sc' presence after malloc(9) > > > > Makes se