Re: UNIX sockets: make `unp_rights', `unp_msgcount' and `unp_file' atomic

2021-11-04 Thread Martin Pieuchot
On 30/10/21(Sat) 21:22, Vitaliy Makkoveev wrote: > This completely removes global rwlock(9) from the unp_internalize() and > unp_externalize() normal paths but only leaves it in unp_externalize() > error path. Also we don't need to simultaneously hold both fdplock() > and `unp_lock' in unp_internal

Re: vmd(8): fix broken bootorder for cdrom

2021-11-04 Thread Mike Larkin
On Thu, Nov 04, 2021 at 08:09:16PM +0100, Jan Klemkow wrote: > On Thu, Nov 04, 2021 at 10:43:46AM -0400, Dave Voutila wrote: > > Jan Klemkow writes: > > > This fix [1] in seabios breaks our "boot device cdrom" feature. > > > > > > # vmctl start -Lc -d disk.img -r cd70.iso -B cdrom vm > > > ... > >

Re: Stop mentioning ld(1) warning messages in mktemp.3 and tmpnam.3

2021-11-04 Thread Theo de Raadt
Joerg Sonnenberger wrote: > On Thu, Nov 04, 2021 at 06:30:29PM -0600, Theo de Raadt wrote: > > Joerg Sonnenberger wrote: > > > > > On Thu, Nov 04, 2021 at 10:12:32PM +0100, Frederic Cambus wrote: > > > > I'm building myself a small tool [1] to display .gnu.warning.* sections > > > > names in EL

Re: Stop mentioning ld(1) warning messages in mktemp.3 and tmpnam.3

2021-11-04 Thread Joerg Sonnenberger
On Thu, Nov 04, 2021 at 06:30:29PM -0600, Theo de Raadt wrote: > Joerg Sonnenberger wrote: > > > On Thu, Nov 04, 2021 at 10:12:32PM +0100, Frederic Cambus wrote: > > > I'm building myself a small tool [1] to display .gnu.warning.* sections > > > names in ELF objects along with their content, and

Re: Stop mentioning ld(1) warning messages in mktemp.3 and tmpnam.3

2021-11-04 Thread Theo de Raadt
Joerg Sonnenberger wrote: > On Thu, Nov 04, 2021 at 10:12:32PM +0100, Frederic Cambus wrote: > > I'm building myself a small tool [1] to display .gnu.warning.* sections > > names in ELF objects along with their content, and will check which > > other projects use those sections. So far, aside fro

Re: userret: take/release kernel lock once

2021-11-04 Thread Scott Cheloha
On Thu, Nov 04, 2021 at 04:04:43PM -0500, Scott Cheloha wrote: > During userret() we can take/release the kernel lock up to four times. > Nobody actually uses SIGPROF or SIGVTALRM, but a double-lock with a > signal and a temporary signal mask is plausible. > > Is there any reason we can't take/rel

Re: amd4/bsd.rd: make "config -e" work

2021-11-04 Thread Klemens Nanni
On Thu, Nov 04, 2021 at 10:49:46PM +, Klemens Nanni wrote: > amd64, alpha, i386 and macppc strip all symbols off the ramdisk bsd.rd > (before gzipping it) and thus break config(8)'s modification feature: > > $ gzcat bsd.rd > bsd.rd.raw > $ config -e bsd.rd.raw > WARNING no ou

amd4/bsd.rd: make "config -e" work

2021-11-04 Thread Klemens Nanni
amd64, alpha, i386 and macppc strip all symbols off the ramdisk bsd.rd (before gzipping it) and thus break config(8)'s modification feature: $ gzcat bsd.rd > bsd.rd.raw $ config -e bsd.rd.raw WARNING no output file specified WARNING this kernel doesn't contain all i

Re: Stop mentioning ld(1) warning messages in mktemp.3 and tmpnam.3

2021-11-04 Thread Joerg Sonnenberger
On Thu, Nov 04, 2021 at 10:12:32PM +0100, Frederic Cambus wrote: > I'm building myself a small tool [1] to display .gnu.warning.* sections > names in ELF objects along with their content, and will check which > other projects use those sections. So far, aside from us, FreeBSD, > NetBSD, and DragonF

Re: Stop mentioning ld(1) warning messages in mktemp.3 and tmpnam.3

2021-11-04 Thread Frederic Cambus
On Mon, Oct 25, 2021 at 07:41:51AM -0600, Todd C. Miller wrote: > On Mon, 25 Oct 2021 12:48:01 +1100, Jonathan Gray wrote: > > > Shouldn't lld instead be changed to show warnings? > > That was my thinking as well. After discussing the matter with other developers during h2k21, this is indeed the

userret: take/release kernel lock once

2021-11-04 Thread Scott Cheloha
During userret() we can take/release the kernel lock up to four times. Nobody actually uses SIGPROF or SIGVTALRM, but a double-lock with a signal and a temporary signal mask is plausible. Is there any reason we can't take/release the kernel lock just once? Do we need to drop the kernel lock in be

Re: [patch] httpd static gzip compression

2021-11-04 Thread Maxim
Stuart Henderson, 2021-11-04 14:44:44 +: > On 2021/11/04 08:27, Theo de Raadt wrote: > > > Does any other program work this way? > > > > Where you request one filename, and it gives you another? > > Some of the webservers do, for language selection etc. Sometimes it's > useful. Fortunately t

Re: rpki-client X509_free XXX fix

2021-11-04 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.11.04 18:31:54 +0100: > There is this bit in parser.c > X509_free(x509); // needed? XXX > > As tb@ properly noted this X509_free() is needed because the cert_parse() > returns an up referenced x509 pointer back. > > I moved the X509_free() so

Re: rpki-client better exit behaviour when something goes wrong

2021-11-04 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.11.04 18:43:10 +0100: > On Thu, Nov 04, 2021 at 11:27:46AM -0600, Theo de Raadt wrote: > > Claudio Jeker wrote: > > > > > This diff replaces the errx() call in the poll fd check with warnings plus > > > an exit of the main event loop. It also prints

Re: [patch] httpd static gzip compression

2021-11-04 Thread Sebastian Benoit
Theo de Raadt(dera...@openbsd.org) on 2021.11.04 08:53:13 -0600: > Stuart Henderson wrote: > > > In some ways it would be better if it *did* compress on the fly, as then > > you don't have so much to consider with the effect on block/match rules, > > whether a request is passed to a fastcgi handl

distrib/CDs: typofix in application ID

2021-11-04 Thread Klemens Nanni
All volume IDs use a dash and now I can't unsee it missing. OK? Index: alpha/miniroot/Makefile === RCS file: /cvs/src/distrib/alpha/miniroot/Makefile,v retrieving revision 1.23 diff -u -p -r1.23 Makefile --- alpha/miniroot/Makefile

Re: rpki-client X509_free XXX fix

2021-11-04 Thread Theo Buehler
On Thu, Nov 04, 2021 at 06:31:54PM +0100, Claudio Jeker wrote: > There is this bit in parser.c > X509_free(x509); // needed? XXX > > As tb@ properly noted this X509_free() is needed because the cert_parse() > returns an up referenced x509 pointer back. > > I moved the X509_free() so the erro

Re: rpki-client better exit behaviour when something goes wrong

2021-11-04 Thread Claudio Jeker
On Thu, Nov 04, 2021 at 11:27:46AM -0600, Theo de Raadt wrote: > Claudio Jeker wrote: > > > This diff replaces the errx() call in the poll fd check with warnings plus > > an exit of the main event loop. It also prints an error in case not all > > files have been processed. > > > > An example aft

rpki-client X509_free XXX fix

2021-11-04 Thread Claudio Jeker
There is this bit in parser.c X509_free(x509); // needed? XXX As tb@ properly noted this X509_free() is needed because the cert_parse() returns an up referenced x509 pointer back. I moved the X509_free() so the error cases become simpler and we no longer leak a reference on success. At le

Re: rpki-client better exit behaviour when something goes wrong

2021-11-04 Thread Theo de Raadt
Claudio Jeker wrote: > This diff replaces the errx() call in the poll fd check with warnings plus > an exit of the main event loop. It also prints an error in case not all > files have been processed. > > An example after kill -9 of the rsync process is: > rpki-client: https://rrdp.lacnic.net/rr

Re: rpki-client better exit behaviour when something goes wrong

2021-11-04 Thread Theo Buehler
On Thu, Nov 04, 2021 at 06:18:59PM +0100, Claudio Jeker wrote: > This diff replaces the errx() call in the poll fd check with warnings plus > an exit of the main event loop. It also prints an error in case not all > files have been processed. > > An example after kill -9 of the rsync process is: >

rpki-client better exit behaviour when something goes wrong

2021-11-04 Thread Claudio Jeker
This diff replaces the errx() call in the poll fd check with warnings plus an exit of the main event loop. It also prints an error in case not all files have been processed. An example after kill -9 of the rsync process is: rpki-client: https://rrdp.lacnic.net/rrdp/notification.xml: loaded from ne

libc/asr: remove unused variables

2021-11-04 Thread Klemens Nanni
Old diff laying around. OK? Index: libc/asr/asr.c === RCS file: /cvs/src/lib/libc/asr/asr.c,v retrieving revision 1.65 diff -u -p -r1.65 asr.c --- libc/asr/asr.c 6 Jan 2021 19:54:17 - 1.65 +++ libc/asr/asr.c 5 Apr

Re: [patch] httpd static gzip compression

2021-11-04 Thread Chris Cappuccio
Solene Rapenne [sol...@perso.pw] wrote: > On jeudi 4 novembre 2021 15:09:39 CET, Stuart Henderson wrote: > > > > btw this was rejected before, > > > > https://github.com/reyk/httpd/issues/21 > > It's not clear if "static" compression is rejected. Sure, on-the-fly > compilation is complicated and

Re: [patch] httpd static gzip compression

2021-11-04 Thread Florian Obser
On 2021-11-04 08:53 -06, "Theo de Raadt" wrote: > Oh, httpd was written for only that reason? That's incorrect. The other reason is need to know. -- I'm not entirely sure you are real.

better audio defaults: please test

2021-11-04 Thread Alexandre Ratchov
The current sndiod latency (minimum time between when the program plays something and when sound reaches Joe's ears) is too large and makes OpenBSD unpleasant to use for telephony, games, and makes controls of video players slugish. The defaut latency (of 160ms) was set ~10 years ago to workaround

Re: [patch] httpd static gzip compression

2021-11-04 Thread Theo de Raadt
Stuart Henderson wrote: > In some ways it would be better if it *did* compress on the fly, as then > you don't have so much to consider with the effect on block/match rules, > whether a request is passed to a fastcgi handler, etc. (But of course > then you have CPU use issues). I don't want my w

Re: vmd(8): fix broken bootorder for cdrom

2021-11-04 Thread Dave Voutila
Jan Klemkow writes: > Hi, > > This fix [1] in seabios breaks our "boot device cdrom" feature. > > # vmctl start -Lc -d disk.img -r cd70.iso -B cdrom vm > ... > No bootable device. Retrying in 60 seconds. > > # vmctl start -Lc -d disk.img -r cd70.iso vm > doas vmctl start -c -r cd70.iso vm > ..

Re: [patch] httpd static gzip compression

2021-11-04 Thread Stuart Henderson
On 2021/11/04 08:27, Theo de Raadt wrote: > prx wrote: > > > * Stuart Henderson le [04-11-2021 14:09:39 +]: > > > On 2021/11/04 14:21, prx wrote: > > > > Hello, > > > > The attached patch add support for static gzip compression. > > > > > > > > In other words, if a client support gzip compr

Re: [patch] httpd static gzip compression

2021-11-04 Thread Theo de Raadt
prx wrote: > * Stuart Henderson le [04-11-2021 14:09:39 +]: > > On 2021/11/04 14:21, prx wrote: > > > Hello, > > > The attached patch add support for static gzip compression. > > > > > > In other words, if a client support gzip compression, when "file" is > > > requested, httpd will check i

Re: vmd(8): fix broken bootorder for cdrom

2021-11-04 Thread Bryan Steele
On Thu, Nov 04, 2021 at 02:44:18PM +0100, Jan Klemkow wrote: > Hi, > > This fix [1] in seabios breaks our "boot device cdrom" feature. > > # vmctl start -Lc -d disk.img -r cd70.iso -B cdrom vm > ... > No bootable device. Retrying in 60 seconds. > > # vmctl start -Lc -d disk.img -r cd70.iso vm >

Re: [patch] httpd static gzip compression

2021-11-04 Thread prx
* Stuart Henderson le [04-11-2021 14:09:39 +]: > On 2021/11/04 14:21, prx wrote: > > Hello, > > The attached patch add support for static gzip compression. > > > > In other words, if a client support gzip compression, when "file" is > > requested, httpd will check if "file.gz" is avaiable to

Re: [patch] httpd static gzip compression

2021-11-04 Thread Stuart Henderson
On 2021/11/04 14:21, prx wrote: > Hello, > The attached patch add support for static gzip compression. > > In other words, if a client support gzip compression, when "file" is > requested, httpd will check if "file.gz" is avaiable to serve. > > Regards. > > prx btw this was rejected before, ht

[patch] httpd static gzip compression

2021-11-04 Thread prx
Hello, The attached patch add support for static gzip compression. In other words, if a client support gzip compression, when "file" is requested, httpd will check if "file.gz" is avaiable to serve. Regards. prx Index: httpd.conf.5

rpki-client refactor repo code a bit

2021-11-04 Thread Claudio Jeker
When RRDP support was added a repo was added for every caRepository URI that was different from the others. Now the big RIR repos have many caRepoistory URIs that are just subdirs and are covered by the same rsync or RRDP source. This diff changes this back to not create a new repo for every caRep

Re: rpki-client refactor tal handling

2021-11-04 Thread Theo Buehler
On Wed, Nov 03, 2021 at 08:01:38PM +0100, Claudio Jeker wrote: > On Wed, Nov 03, 2021 at 12:41:52PM -0600, Theo de Raadt wrote: > > + size_t talid; /* covered by which TAL */ > > > > You shouldn't use size_t > > > > It is 32bit on ILP32 systems, and 64bit on I32LP64 machines, beca