Re: wskbd_set_mixervolume

2022-02-05 Thread Anton Lindqvist
On Sat, Feb 05, 2022 at 02:46:53PM +0100, Anton Lindqvist wrote: > On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > > From: Anton Lindqvist > > > > > > Hi, > > > I recently got a USB headset with physical volume buttons, handled by > >

Re: Ship ubsan_minimal library in base?

2022-02-05 Thread Greg Steuck
Sweet, let's look at the two patches below. No sets yet. I tested on amd64 with the UBSan sample program and also with games/battlestar. If somebody could repeat the steps I listed in the previous email on a non-amd64 platform, that would be useful. Jeremie Courreges-Anglas writes: > On Sat,

Re: request for testing: malloc and large allocations

2022-02-05 Thread Otto Moerbeek
On Sat, Feb 05, 2022 at 08:07:42PM +0100, Jan Stary wrote: > On Feb 05 17:35:46, o...@drijf.net wrote: > > On Sat, Feb 05, 2022 at 05:22:50PM +0100, Jan Stary wrote: > > > > > On Feb 02 00:04:37, alexander.bl...@gmx.net wrote: > > > > On Tue, Feb 01, 2022 at 08:00:36AM +0100, Otto Moerbeek

Re: request for testing: malloc and large allocations

2022-02-05 Thread Jan Stary
On Feb 05 17:35:46, o...@drijf.net wrote: > On Sat, Feb 05, 2022 at 05:22:50PM +0100, Jan Stary wrote: > > > On Feb 02 00:04:37, alexander.bl...@gmx.net wrote: > > > On Tue, Feb 01, 2022 at 08:00:36AM +0100, Otto Moerbeek wrote: > > > > > Are you running with any malloc flags? > > > > > > > >

Re: Add rtable capability to login.conf

2022-02-05 Thread Matthew Martin
On Sat, Jan 29, 2022 at 06:25:32PM -0600, Matthew Martin wrote: > On Sat, Jan 29, 2022 at 07:10:00PM -0500, Ted Unangst wrote: > > I believe it would be better to add setrtable to id pledge. ping Also are there any opinions on adding LOGIN_SETRTABLE to doas? diff --git include/login_cap.h

Re: wskbd_set_mixervolume

2022-02-05 Thread Claudio Jeker
On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > From: Anton Lindqvist > > > > Hi, > > I recently got a USB headset with physical volume buttons, handled by > > ucc(4). However, after enabling the device in sndiod the volume buttons > >

Re: Ship ubsan_minimal library in base?

2022-02-05 Thread Jeremie Courreges-Anglas
On Sat, Feb 05 2022, Jeremie Courreges-Anglas wrote: > On Fri, Feb 04 2022, Greg Steuck wrote: >> How do people feel about shipping the minimal UBSan runtime library[1] >> in the base system? It takes very little to build (Makefile + a few >> ifdefs that both jca@ and I hacked together). The

Re: request for testing: malloc and large allocations

2022-02-05 Thread Otto Moerbeek
On Sat, Feb 05, 2022 at 05:22:50PM +0100, Jan Stary wrote: > On Feb 02 00:04:37, alexander.bl...@gmx.net wrote: > > On Tue, Feb 01, 2022 at 08:00:36AM +0100, Otto Moerbeek wrote: > > > > Are you running with any malloc flags? > > > > > > This bug report enabled me to find a bug that would pop up

Re: request for testing: malloc and large allocations

2022-02-05 Thread Jan Stary
On Feb 02 00:04:37, alexander.bl...@gmx.net wrote: > On Tue, Feb 01, 2022 at 08:00:36AM +0100, Otto Moerbeek wrote: > > > Are you running with any malloc flags? > > > > This bug report enabled me to find a bug that would pop up if G mode > > is enabled. > > > > New diff below. New tests

Re: Ship ubsan_minimal library in base?

2022-02-05 Thread Jeremie Courreges-Anglas
On Fri, Feb 04 2022, Greg Steuck wrote: > How do people feel about shipping the minimal UBSan runtime library[1] > in the base system? It takes very little to build (Makefile + a few > ifdefs that both jca@ and I hacked together). The library is tiny and > useful enough for finding UB in base.

Re: ypldap: fix -Wunused-but-set-variable warnings

2022-02-05 Thread Todd C . Miller
On Sat, 05 Feb 2022 14:38:14 +0100, Christian Weisgerber wrote: > Anybody? > The commit history of ypldap does not suggest a single responsible > person I could pin down. OK millert@ - todd

Re: drop please from manual pages

2022-02-05 Thread Todd C . Miller
On Sat, 05 Feb 2022 23:06:32 +1100, Jonathan Gray wrote: > drop please from manual pages excluding third party parts of tree > suggested by multiple documentation style guides OK millert@ - todd

Re: Ship ubsan_minimal library in base?

2022-02-05 Thread Todd C . Miller
On Fri, 04 Feb 2022 20:46:48 -0800, Greg Steuck wrote: > How do people feel about shipping the minimal UBSan runtime library[1] > in the base system? It takes very little to build (Makefile + a few > ifdefs that both jca@ and I hacked together). The library is tiny and > useful enough for finding

Re: drop please from manual pages

2022-02-05 Thread Jason McIntyre
On Sat, Feb 05, 2022 at 11:06:32PM +1100, Jonathan Gray wrote: > drop please from manual pages excluding third party parts of tree > suggested by multiple documentation style guides > hi. i'm ok with this. jmc > diff --git lib/libc/stdlib/atexit.3 lib/libc/stdlib/atexit.3 > index

Re: wskbd_set_mixervolume

2022-02-05 Thread Anton Lindqvist
On Sat, Feb 05, 2022 at 12:28:08PM +0100, Mark Kettenis wrote: > > Date: Sat, 5 Feb 2022 09:29:42 +0100 > > From: Anton Lindqvist > > > > Hi, > > I recently got a USB headset with physical volume buttons, handled by > > ucc(4). However, after enabling the device in sndiod the volume buttons > >

Re: ypldap: fix -Wunused-but-set-variable warnings

2022-02-05 Thread Christian Weisgerber
Christian Weisgerber: > usr.sbin/ypldap: fix -Wunused-but-set-variable warnings > > * "wrlen" has been write-only since the code was imported. > * Removing "dns_pid" replicates ntpd/ntp.c 1.122 (aece4353519f). > * yp_check() looks like unfinished code. Rather than removing it > we can ifdef

Re: Use km_alloc(9) in drm

2022-02-05 Thread Mark Kettenis
> Date: Sat, 5 Feb 2022 22:34:10 +1100 > From: Jonathan Gray > > On Sat, Feb 05, 2022 at 11:44:03AM +0100, Mark Kettenis wrote: > > We want to get rid of the uvm_km_valloc() interfaces in favour of > > km_alloc(). This changes the calls in drm(4) over. The kv_physwait > > struct is made static

drop please from manual pages

2022-02-05 Thread Jonathan Gray
drop please from manual pages excluding third party parts of tree suggested by multiple documentation style guides diff --git lib/libc/stdlib/atexit.3 lib/libc/stdlib/atexit.3 index a95a45b92e4..891641489e3 100644 --- lib/libc/stdlib/atexit.3 +++ lib/libc/stdlib/atexit.3 @@ -68,7 +68,7 @@ that

Re: Use km_alloc(9) in drm

2022-02-05 Thread Jonathan Gray
On Sat, Feb 05, 2022 at 11:44:03AM +0100, Mark Kettenis wrote: > We want to get rid of the uvm_km_valloc() interfaces in favour of > km_alloc(). This changes the calls in drm(4) over. The kv_physwait > struct is made static to prevent collission with a symbol in > vm_machdep.c on some

Re: wskbd_set_mixervolume

2022-02-05 Thread Mark Kettenis
> Date: Sat, 5 Feb 2022 09:29:42 +0100 > From: Anton Lindqvist > > Hi, > I recently got a USB headset with physical volume buttons, handled by > ucc(4). However, after enabling the device in sndiod the volume buttons > does not cause the volume to change. Turns out wskbd_set_mixervolume() > is

Use km_alloc(9) in drm

2022-02-05 Thread Mark Kettenis
We want to get rid of the uvm_km_valloc() interfaces in favour of km_alloc(). This changes the calls in drm(4) over. The kv_physwait struct is made static to prevent collission with a symbol in vm_machdep.c on some architectures. The goal is to move this into uvm/uvm_km.c eventually. Just to

wskbd_set_mixervolume

2022-02-05 Thread Anton Lindqvist
Hi, I recently got a USB headset with physical volume buttons, handled by ucc(4). However, after enabling the device in sndiod the volume buttons does not cause the volume to change. Turns out wskbd_set_mixervolume() is only propagating volume changes to first attached audio device. Is their any