Re: remove pre-486 code from i386 platform

2022-07-28 Thread Daniel Dickman
> On Jul 29, 2022, at 2:18 AM, Tomasz Rola wrote: > > On Thu, Jul 28, 2022 at 08:06:28PM -0400, Daniel Dickman wrote: >>> On Thu, Jul 28, 2022 at 3:37 AM Jeroen Massar wrote: >>> > [...] >>> >>> I personally would not touch the .h definitions: >>> Index: i386/include/cputypes.h

Re: remove pre-486 code from i386 platform

2022-07-28 Thread Jonathan Gray
On Fri, Jul 29, 2022 at 06:58:08AM +0200, Tomasz Rola wrote: > On Thu, Jul 28, 2022 at 08:06:28PM -0400, Daniel Dickman wrote: > > On Thu, Jul 28, 2022 at 3:37 AM Jeroen Massar wrote: > > > > [...] > > > > > > I personally would not touch the .h definitions: > > > > > > > > > > > Index: i386/inclu

Re: remove pre-486 code from i386 platform

2022-07-28 Thread Tomasz Rola
On Thu, Jul 28, 2022 at 08:06:28PM -0400, Daniel Dickman wrote: > On Thu, Jul 28, 2022 at 3:37 AM Jeroen Massar wrote: > > [...] > > > > I personally would not touch the .h definitions: > > > > > > > > Index: i386/include/cputypes.h > > > [..] > > > > > > -#define CPUCLASS_3860 > > > #def

Re: [v4] amd64: simplify TSC sync testing

2022-07-28 Thread Timo Myyrä
Scott Cheloha [2022-07-28, 20:34 -0500]: > On Thu, Jul 28, 2022 at 04:57:41PM -0400, Dave Voutila wrote: > >> >> Stuart Henderson writes: >> >> > On 2022/07/28 12:57, Scott Cheloha wrote: >> >> On Thu, Jul 28, 2022 at 07:55:40AM -0400, Dave Voutila wrote: >> >> > >> >> > This is breaking timec

Re: remove pre-486 code from i386 platform

2022-07-28 Thread Jonathan Gray
On Wed, Jul 27, 2022 at 10:18:55PM -0400, Daniel Dickman wrote: > The diff below removes support for 386SX/DX processors. We already claim > we don't support anything older than a Pentium so there's no point to keep > this code. > > The main code change is in locore0.S and is to stop checking if

Re: Consistency and cleanup in /share/misc/airport

2022-07-28 Thread Mike Fischer
> Am 29.07.2022 um 03:45 schrieb Daniel Dickman : > >> -HAM:Fuhlsbuettel Hamburg, Germany >> +HAM:Fuhlsbuettel, Hamburg, Germany > > Wikipedia states this airport is now called Hamburg Airport? Correct, see the official airport website: https://www.hamburg-airport.de/en Fuhlsbüttel is the nam

Re: Consistency and cleanup in /share/misc/airport

2022-07-28 Thread Daniel Dickman
On Mon, Jul 25, 2022 at 5:10 AM Thomas Wager wrote: > > Hi, > > some changes to /share/misc/airport to treat german umlauts more > consistently, remove the "Flugplatz" (german for airport, which is kind > of redundant as it is all airports in the list), remove NRW which does > not exist as IATA co

Re: [v4] amd64: simplify TSC sync testing

2022-07-28 Thread Scott Cheloha
On Thu, Jul 28, 2022 at 04:57:41PM -0400, Dave Voutila wrote: > > Stuart Henderson writes: > > > On 2022/07/28 12:57, Scott Cheloha wrote: > >> On Thu, Jul 28, 2022 at 07:55:40AM -0400, Dave Voutila wrote: > >> > > >> > This is breaking timecounter selection on my x13 Ryzen 5 Pro laptop > >> > r

Re: remove pre-486 code from i386 platform

2022-07-28 Thread Daniel Dickman
On Thu, Jul 28, 2022 at 3:37 AM Jeroen Massar wrote: > > > > > On 28 Jul 2022, at 04:18, Daniel Dickman wrote: > > > > The diff below removes support for 386SX/DX processors. We already claim > > we don't support anything older than a Pentium so there's no point to keep > > this code. > [..] > >

Re: [v4] amd64: simplify TSC sync testing

2022-07-28 Thread Dave Voutila
Stuart Henderson writes: > On 2022/07/28 12:57, Scott Cheloha wrote: >> On Thu, Jul 28, 2022 at 07:55:40AM -0400, Dave Voutila wrote: >> > >> > This is breaking timecounter selection on my x13 Ryzen 5 Pro laptop >> > running the latest kernel from snaps. >> >> Define "breaking". > > That's clea

Re: [v4] amd64: simplify TSC sync testing

2022-07-28 Thread Scott Cheloha
> On Jul 28, 2022, at 13:41, Stuart Henderson wrote: > > On 2022/07/28 12:57, Scott Cheloha wrote: >>> On Thu, Jul 28, 2022 at 07:55:40AM -0400, Dave Voutila wrote: >>> >>> This is breaking timecounter selection on my x13 Ryzen 5 Pro laptop >>> running the latest kernel from snaps. >> >> Defin

Re: [v4] amd64: simplify TSC sync testing

2022-07-28 Thread Stuart Henderson
On 2022/07/28 12:57, Scott Cheloha wrote: > On Thu, Jul 28, 2022 at 07:55:40AM -0400, Dave Voutila wrote: > > > > This is breaking timecounter selection on my x13 Ryzen 5 Pro laptop > > running the latest kernel from snaps. > > Define "breaking". That's clear from the output: : On 2022/07/28 07

Re: [v4] amd64: simplify TSC sync testing

2022-07-28 Thread Renato Aguiar
On Thursday, July 28th, 2022 at 4:55 AM, Dave Voutila wrote: > This is breaking timecounter selection on my x13 Ryzen 5 Pro laptop > running the latest kernel from snaps. sysctl entries immediately after > boot: > > $ sysctl -a | grep tsc > kern.timecounter.choice=i8254(0) tsc(-1000) acpihpet0(1

Re: [v4] amd64: simplify TSC sync testing

2022-07-28 Thread Scott Cheloha
On Thu, Jul 28, 2022 at 07:55:40AM -0400, Dave Voutila wrote: > > Scott Cheloha writes: > > > Hi, > > > > Thanks to everyone who tested v3. > > > > Attached is v4. I would like to put this into snaps (bcc: deraadt@). > > > > If you've been following along and testing these patches, feel free to

Re: remove pre-486 code from i386 platform

2022-07-28 Thread Mike Larkin
On Wed, Jul 27, 2022 at 10:18:55PM -0400, Daniel Dickman wrote: > The diff below removes support for 386SX/DX processors. We already claim > we don't support anything older than a Pentium so there's no point to keep > this code. > > The main code change is in locore0.S and is to stop checking if th

Re: Zap prototypes for nonexistent nd6_setmtu() and in6_ifdel()

2022-07-28 Thread Alexander Bluhm
On Thu, Jul 28, 2022 at 12:43:57PM +, Klemens Nanni wrote: > Removed in 2015 and 2002, respectively. > > OK? OK bluhm@ > diff --git a/sys/netinet6/nd6.h b/sys/netinet6/nd6.h > index 5eb9d9f4e9e..e03f4218a56 100644 > --- a/sys/netinet6/nd6.h > +++ b/sys/netinet6/nd6.h > @@ -162,7 +162,6 @@ vo

Re: Zap outdated nd6_free() comment about static

2022-07-28 Thread Alexander Bluhm
On Thu, Jul 28, 2022 at 12:34:02PM +, Klemens Nanni wrote: > On Fri, Jul 22, 2022 at 01:21:51PM +, Klemens Nanni wrote: > > Added in 2002 r1.48 "sync with latest KAME [...]" along the attribute, > > but nd6_free() became a global void function in 2017 r1.212. > > > > Afaik static kerne

ip input fragment mutex

2022-07-28 Thread Alexander Bluhm
Hi, Checking the fragment flags of an IP packet does not need the mutex for the fragment list. Move this code before the critical section. Use ISSET() to make obvious which flags are checked. ok? bluhm Index: netinet/ip_input.c =

Re: bgpd more kroute refactor

2022-07-28 Thread Claudio Jeker
On Thu, Jul 28, 2022 at 03:09:18PM +0200, Theo Buehler wrote: > On Thu, Jul 28, 2022 at 12:48:05PM +0200, Claudio Jeker wrote: > > Next step on the epic saga of cleaning up kroute.c > > > > Refactor kroute_remove() so that a struct kroute_full can be passed to the > > function. It updates the stru

Re: bgpd more kroute refactor

2022-07-28 Thread Theo Buehler
On Thu, Jul 28, 2022 at 12:48:05PM +0200, Claudio Jeker wrote: > Next step on the epic saga of cleaning up kroute.c > > Refactor kroute_remove() so that a struct kroute_full can be passed to the > function. It updates the struct kroute_full with the route that got removed. > > I split the code in

Re: [v4] amd64: simplify TSC sync testing

2022-07-28 Thread Dave Voutila
Scott Cheloha writes: > Hi, > > Thanks to everyone who tested v3. > > Attached is v4. I would like to put this into snaps (bcc: deraadt@). > > If you've been following along and testing these patches, feel free to > continue testing. If your results change from v3 to v4, please reply > with w

Zap prototypes for nonexistent nd6_setmtu() and in6_ifdel()

2022-07-28 Thread Klemens Nanni
Removed in 2015 and 2002, respectively. OK? diff --git a/sys/netinet6/nd6.h b/sys/netinet6/nd6.h index 5eb9d9f4e9e..e03f4218a56 100644 --- a/sys/netinet6/nd6.h +++ b/sys/netinet6/nd6.h @@ -162,7 +162,6 @@ void nd6_option_init(void *, int, union nd_opts *); struct nd_opt_hdr *nd6_option(union nd_

Re: Zap outdated nd6_free() comment about static

2022-07-28 Thread Klemens Nanni
On Fri, Jul 22, 2022 at 01:21:51PM +, Klemens Nanni wrote: > Added in 2002 r1.48 "sync with latest KAME [...]" along the attribute, > but nd6_free() became a global void function in 2017 r1.212. > > Afaik static kernel functions are avoided to aid ddb'ugging and I > presume the "significan

interface media without netlock

2022-07-28 Thread Alexander Bluhm
Hi, The netlock for SIOCSIFMEDIA and SIOCGIFMEDIA ioctl is not necessary. Legacy drivers run with kernel lock, interface media is MP safe or has kernel lock. ixl(4) talks about net lock but in fact has kernel lock. Problem is that smtpd(8) periodically checks media status. This stops network if

bgpd more kroute refactor

2022-07-28 Thread Claudio Jeker
Next step on the epic saga of cleaning up kroute.c Refactor kroute_remove() so that a struct kroute_full can be passed to the function. It updates the struct kroute_full with the route that got removed. I split the code into kroute[46]_remove() to make kroute_remove() less cluttered. The return v

Re: bgpd remove F_DOWN flag

2022-07-28 Thread Theo Buehler
On Thu, Jul 28, 2022 at 12:30:01PM +0200, Claudio Jeker wrote: > When the bgpctl show fib diff is committed nothing uses F_DOWN anymore. > Remove the flag and reshuffle some of the other flags to group them > a bit better. ok

Re: adjust bgpctl show fib formatting

2022-07-28 Thread Theo Buehler
On Thu, Jul 28, 2022 at 12:22:24PM +0200, Claudio Jeker wrote: > This adjusts the output of bgpctl show fib. It removes the F_DOWN check > since kroutes no longer track this. And it changes the flag printing code > to reserve the space needed so that adjusting the flags does not break the > output.

bgpd remove F_DOWN flag

2022-07-28 Thread Claudio Jeker
When the bgpctl show fib diff is committed nothing uses F_DOWN anymore. Remove the flag and reshuffle some of the other flags to group them a bit better. -- :wq Claudio Index: bgpd.h === RCS file: /cvs/src/usr.sbin/bgpd/bgpd.h,v ret

adjust bgpctl show fib formatting

2022-07-28 Thread Claudio Jeker
This adjusts the output of bgpctl show fib. It removes the F_DOWN check since kroutes no longer track this. And it changes the flag printing code to reserve the space needed so that adjusting the flags does not break the output. Last but not least increase the size of destination and gateway to 32b