swab.3: Use Fn consistently

2022-09-27 Thread Josiah Frentsos
Index: swab.3 === RCS file: /cvs/src/lib/libc/string/swab.3,v retrieving revision 1.9 diff -u -p -r1.9 swab.3 --- swab.3 12 Dec 2014 20:06:13 - 1.9 +++ swab.3 27 Sep 2022 22:09:45 - @@ -42,9 +42,9 @@ .Fa "ssize_

readpassphrase(3) in glibc, and agetpass() (Was: Is getpass(3) really obsolete?)

2022-09-27 Thread Alejandro Colomar
Hi Zack, On 10/29/21 16:53, Zack Weinberg via Libc-alpha wrote: On Fri, Oct 29, 2021, at 9:55 AM, Theo de Raadt wrote: wrote: On October 29, 2021 7:29 AM, Alejandro Colomar wrote: On 10/29/21 13:15, Alejandro Colomar wrote: Hi, As the manual pages says, SUSv2 marked it as LEGACY, and POSIX

setvbuf.c: fix 32-bit-ism

2022-09-27 Thread enh
The existing test is wrong for LP64, where size_t has twice as many relevant bits as int, not just one. (Found by inspection by rprichard.) diff --git a/lib/libc/stdio/setvbuf.c b/lib/libc/stdio/setvbuf.c index 9a08d133f5f..9909dbb8ecd 100644 --- a/lib/libc/stdio/setvbuf.c +++ b/lib/libc/stdio/set

Re: install.sub: Replace temporary file with variable

2022-09-27 Thread Todd C . Miller
On Tue, 27 Sep 2022 11:28:59 -0400, Josiah Frentsos wrote: > From ksh(1): > > [[ expression ]] > Similar to the test and [ ... ] commands (described later), with > the following exceptions: > > o Field splitting and file name generation are not >

Re: install.sub: Replace temporary file with variable

2022-09-27 Thread Josiah Frentsos
On Tue, Sep 27, 2022 at 09:09:45AM -0600, Todd C. Miller wrote: > On Tue, 27 Sep 2022 13:49:10 -, Klemens Nanni wrote: > > > The double quotes retain the newlines; without them column(1) would > > print a single line (possibly longer than 80 chars). > > Don't you also need double quotes arou

Re: install.sub: Replace temporary file with variable

2022-09-27 Thread Todd C . Miller
On Tue, 27 Sep 2022 13:49:10 -, Klemens Nanni wrote: > The double quotes retain the newlines; without them column(1) would > print a single line (possibly longer than 80 chars). Don't you also need double quotes around $_CKPATCH: if [[ -n $_CKPATCH ]]; then in case it contains mult

Re: Request for testing malloc and multi-threaded applications

2022-09-27 Thread Otto Moerbeek
On Tue, Sep 27, 2022 at 03:31:12PM +0200, Renaud Allard wrote: > On 1/16/19 19:09, Otto Moerbeek wrote: > > On Wed, Jan 16, 2019 at 01:25:25PM +, Stuart Henderson wrote: > > > > > On 2019/01/04 08:09, Otto Moerbeek wrote: > > > > On Thu, Dec 27, 2018 at 09:39:56AM +0100, Otto Moerbeek wrote:

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Theo de Raadt
Right. This is called "idiomatic programming". Sometimes it looks a bit idiotic (haha), but as the years go by, we've learned that stylistic reminders that a rarely used function's parameter is a variadic format string, helps us avoid introduction of new mistakes during future development. Stuar

install.sub: Replace temporary file with variable

2022-09-27 Thread Klemens Nanni
On supported -release systems, syspatch(8) -c is run from rc.firsttime(8) and the list of patches it pretty-printed if non-empty. -c output fits into a shell variable, not needing a temporary file, which is also what usr.sbin/syspatch/syspatch.sh does internally. Here's what the patch would do on

Re: Request for testing malloc and multi-threaded applications

2022-09-27 Thread Renaud Allard
On 1/16/19 19:09, Otto Moerbeek wrote: On Wed, Jan 16, 2019 at 01:25:25PM +, Stuart Henderson wrote: On 2019/01/04 08:09, Otto Moerbeek wrote: On Thu, Dec 27, 2018 at 09:39:56AM +0100, Otto Moerbeek wrote: Very little feedback so far. This diff can only give me valid feedback if the cov

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Martijn van Duren
On Tue, 2022-09-27 at 11:23 +0200, Florian Obser wrote: > On 2022-09-27 09:26 +02, Martijn van Duren wrote: > > The caveats section talks about "user-supplied data". These string are > > constant and don't contain any '%'. Most other daemons in base use the > > setproctitle("title"); format as wel

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Florian Obser
On 2022-09-27 09:26 +02, Martijn van Duren wrote: > The caveats section talks about "user-supplied data". These string are > constant and don't contain any '%'. Most other daemons in base use the > setproctitle("title"); format as well. It's not that clear cut, snmpd(8), a daemon you might be fam

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Martijn van Duren
The caveats section talks about "user-supplied data". These string are constant and don't contain any '%'. Most other daemons in base use the setproctitle("title"); format as well. On Tue, 2022-09-27 at 08:07 +0100, Stuart Henderson wrote: > These programs seem OK as-is, they are following the adv

Re: Remove some unnecessary setproctitle(3) format strings

2022-09-27 Thread Stuart Henderson
These programs seem OK as-is, they are following the advice in https://man.openbsd.org/setproctitle.3#CAVEATS On 2022/09/26 18:06, Josiah Frentsos wrote: > Index: sbin/dhcpleased/engine.c > === > RCS file: /cvs/src/sbin/dhcpleased/eng