ipv4 header checksum

2023-05-12 Thread Alexander Bluhm
Hi, Instead of implementing IPv4 header checksum everywhere differently, introduce in_hdr_cksum_out(). It is used like in_proto_cksum_out(). ok? bluhm Index: net/if_bridge.c === RCS file:

ix hardware tso

2023-05-12 Thread Alexander Bluhm
Hi, I merged jan@'s ix(4) TSO diff with my software TSO diff. It seems to work. # netstat -s -p tcp | grep TSO 1 output TSO packet software chopped 1824861 output TSO packets hardware processed 31668597 output TSO packets generated

Re: ifconfig: SIOCSIFFLAGS: device not configured

2023-05-12 Thread Hrvoje Popovski
On 12.5.2023. 16:21, Jan Klemkow wrote: > On Thu, May 11, 2023 at 09:17:37PM +0200, Hrvoje Popovski wrote: >> is it possible to change "ifconfig: SIOCSIFFLAGS: device not configured" >> message that it has an interface name in it, something like: >> ifconfig pfsync0: SIOCSIFFLAGS: device not

Re: ifconfig: SIOCSIFFLAGS: device not configured

2023-05-12 Thread Peter Hessler
On 2023 May 12 (Fri) at 16:21:10 +0200 (+0200), Jan Klemkow wrote: :On Thu, May 11, 2023 at 09:17:37PM +0200, Hrvoje Popovski wrote: :> ifconfig: SIOCSTRUNKPORT: Device busy :> ifconfig: SIOCSTRUNKPORT: Device busy :> :> to change :> ifconfig ix0: SIOCSTRUNKPORT: Device busy :> ifconfig ix1:

Re: ifconfig: SIOCSIFFLAGS: device not configured

2023-05-12 Thread Jan Klemkow
On Thu, May 11, 2023 at 09:17:37PM +0200, Hrvoje Popovski wrote: > is it possible to change "ifconfig: SIOCSIFFLAGS: device not configured" > message that it has an interface name in it, something like: > ifconfig pfsync0: SIOCSIFFLAGS: device not configured <- in my case. > > I have many vlans

Re: give softnet threads their own names

2023-05-12 Thread Alexandr Nedvedicky
On Fri, May 12, 2023 at 10:34:00AM +1000, David Gwynne wrote: > so in top you see softnet0, softnet1, etc. > > the real change is putting a struct softnet in place to wrap the name > and taskq up with. > > ok? sure, thanks sashan

Re: nd6 remove kernel lock

2023-05-12 Thread Vitaliy Makkoveev
> On 12 May 2023, at 15:07, Alexander Bluhm wrote: > > On Fri, May 12, 2023 at 11:43:42AM +, Klemens Nanni wrote: >>> Access rt_llinfo and check for NULL without checking RTF_LLINFO >>> flag before. They are changed togehter with the arp or nd6 mutex. >> >> It is the same change, but I'd

Re: nd6 remove kernel lock

2023-05-12 Thread Alexander Bluhm
On Fri, May 12, 2023 at 11:43:42AM +, Klemens Nanni wrote: > > Access rt_llinfo and check for NULL without checking RTF_LLINFO > > flag before. They are changed togehter with the arp or nd6 mutex. > > It is the same change, but I'd commit ARP separately (you don't change > any locking

Re: give softnet threads their own names

2023-05-12 Thread Vitaliy Makkoveev
> On 12 May 2023, at 03:34, David Gwynne wrote: > > so in top you see softnet0, softnet1, etc. > > the real change is putting a struct softnet in place to wrap the name > and taskq up with. > > ok? Makes sense. ok mvs > > Index: if.c >

Re: nd6 remove kernel lock

2023-05-12 Thread Klemens Nanni
On Fri, May 12, 2023 at 12:18:12AM +0200, Alexander Bluhm wrote: > Hi, > > I would like to remove the kernel lock from nd6 resolve and use nd6 > mutex instead. > > Access rt_llinfo and check for NULL without checking RTF_LLINFO > flag before. They are changed togehter with the arp or nd6 mutex.

Re: give softnet threads their own names

2023-05-12 Thread Alexander Bluhm
On Fri, May 12, 2023 at 10:34:00AM +1000, David Gwynne wrote: > so in top you see softnet0, softnet1, etc. > > the real change is putting a struct softnet in place to wrap the name > and taskq up with. > > ok? OK bluhm@ > Index: if.c >